From b8e699b84437b8e5d1098be655e57b879668ebd0 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Thu, 29 Jun 2017 11:24:30 -0700 Subject: [PATCH] Remove dependency in HttpContextFactory for HostingApplicationTests (#1121) --- .../HostingApplicationTests.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/Microsoft.AspNetCore.Hosting.Tests/HostingApplicationTests.cs b/test/Microsoft.AspNetCore.Hosting.Tests/HostingApplicationTests.cs index 082685eefc..e75ebbe778 100644 --- a/test/Microsoft.AspNetCore.Hosting.Tests/HostingApplicationTests.cs +++ b/test/Microsoft.AspNetCore.Hosting.Tests/HostingApplicationTests.cs @@ -12,6 +12,7 @@ using Microsoft.AspNetCore.Http.Features; using Microsoft.Extensions.Logging; using Microsoft.Extensions.ObjectPool; using Microsoft.Extensions.Options; +using Moq; using Xunit; namespace Microsoft.AspNetCore.Hosting.Tests @@ -262,19 +263,18 @@ namespace Microsoft.AspNetCore.Hosting.Tests private static HostingApplication CreateApplication(out FeatureCollection features, DiagnosticListener diagnosticSource = null) { - var httpContextFactory = new HttpContextFactory( - new DefaultObjectPoolProvider(), - Options.Create(new FormOptions()), - new HttpContextAccessor()); + var httpContextFactory = new Mock(); + + features = new FeatureCollection(); + features.Set(new HttpRequestFeature()); + httpContextFactory.Setup(s => s.Create(It.IsAny())).Returns(new DefaultHttpContext(features)); + httpContextFactory.Setup(s => s.Dispose(It.IsAny())); var hostingApplication = new HostingApplication( ctx => Task.FromResult(0), new NullScopeLogger(), diagnosticSource ?? new NoopDiagnosticSource(), - httpContextFactory); - - features = new FeatureCollection(); - features.Set(new HttpRequestFeature()); + httpContextFactory.Object); return hostingApplication; }