From b816b37658590c26ddb2064af0c1af332a4045e6 Mon Sep 17 00:00:00 2001
From: Jass Bagga <jabagga@microsoft.com>
Date: Thu, 6 Jul 2017 15:14:23 -0700
Subject: [PATCH] Add breakingchanges (#393)

Addresses #350
---
 .../Microsoft.Extensions.Localization.csproj  |  1 -
 .../breakingchanges.netcore.json              | 22 +++++++++++++++++++
 .../exceptions.net45.json                     |  9 --------
 .../exceptions.netcore.json                   |  9 --------
 4 files changed, 22 insertions(+), 19 deletions(-)
 create mode 100644 src/Microsoft.Extensions.Localization/breakingchanges.netcore.json
 delete mode 100644 src/Microsoft.Extensions.Localization/exceptions.net45.json
 delete mode 100644 src/Microsoft.Extensions.Localization/exceptions.netcore.json

diff --git a/src/Microsoft.Extensions.Localization/Microsoft.Extensions.Localization.csproj b/src/Microsoft.Extensions.Localization/Microsoft.Extensions.Localization.csproj
index 2d28e46cb0..e941a36cf3 100644
--- a/src/Microsoft.Extensions.Localization/Microsoft.Extensions.Localization.csproj
+++ b/src/Microsoft.Extensions.Localization/Microsoft.Extensions.Localization.csproj
@@ -9,7 +9,6 @@
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>localization</PackageTags>
-    <EnableApiCheck>false</EnableApiCheck>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Microsoft.Extensions.Localization/breakingchanges.netcore.json b/src/Microsoft.Extensions.Localization/breakingchanges.netcore.json
new file mode 100644
index 0000000000..5098d4cee4
--- /dev/null
+++ b/src/Microsoft.Extensions.Localization/breakingchanges.netcore.json
@@ -0,0 +1,22 @@
+[
+    {
+        "TypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizerFactory : Microsoft.Extensions.Localization.IStringLocalizerFactory",
+        "MemberId": "public .ctor(Microsoft.AspNetCore.Hosting.IHostingEnvironment hostingEnvironment, Microsoft.Extensions.Options.IOptions<Microsoft.Extensions.Localization.LocalizationOptions> localizationOptions)",
+        "Kind": "Removal"
+    },
+    {
+        "TypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizer : Microsoft.Extensions.Localization.IStringLocalizer",
+        "MemberId": "public .ctor(System.Resources.ResourceManager resourceManager, Microsoft.Extensions.Localization.Internal.AssemblyWrapper resourceAssemblyWrapper, System.String baseName, Microsoft.Extensions.Localization.IResourceNamesCache resourceNamesCache)",
+        "Kind": "Removal"
+    },
+    {
+        "TypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizer : Microsoft.Extensions.Localization.IStringLocalizer",
+        "MemberId": "public .ctor(System.Resources.ResourceManager resourceManager, System.Reflection.Assembly resourceAssembly, System.String baseName, Microsoft.Extensions.Localization.IResourceNamesCache resourceNamesCache)",
+        "Kind": "Removal"
+    },
+    {
+        "TypeId": "public class Microsoft.Extensions.Localization.ResourceManagerWithCultureStringLocalizer : Microsoft.Extensions.Localization.ResourceManagerStringLocalizer",
+        "MemberId": "public .ctor(System.Resources.ResourceManager resourceManager, System.Reflection.Assembly resourceAssembly, System.String baseName, Microsoft.Extensions.Localization.IResourceNamesCache resourceNamesCache, System.Globalization.CultureInfo culture)",
+        "Kind": "Removal"
+    }
+]
\ No newline at end of file
diff --git a/src/Microsoft.Extensions.Localization/exceptions.net45.json b/src/Microsoft.Extensions.Localization/exceptions.net45.json
deleted file mode 100644
index 02d37d7d31..0000000000
--- a/src/Microsoft.Extensions.Localization/exceptions.net45.json
+++ /dev/null
@@ -1,9 +0,0 @@
-[
-    {
-        "OldTypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizerFactory : Microsoft.Extensions.Localization.IStringLocalizerFactory",
-        "OldMemberId": "public .ctor(Microsoft.AspNetCore.Hosting.IHostingEnvironment hostingEnvironment, Microsoft.Extensions.Options.IOptions<Microsoft.Extensions.Localization.LocalizationOptions> localizationOptions)",
-        "NewTypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizerFactory : Microsoft.Extensions.Localization.IStringLocalizerFactory",
-        "NewMemberId": "public .ctor(Microsoft.Extensions.Options.IOptions<Microsoft.Extensions.Localization.LocalizationOptions> localizationOptions)",
-        "Kind": "Modification"
-    }
-]
\ No newline at end of file
diff --git a/src/Microsoft.Extensions.Localization/exceptions.netcore.json b/src/Microsoft.Extensions.Localization/exceptions.netcore.json
deleted file mode 100644
index 02d37d7d31..0000000000
--- a/src/Microsoft.Extensions.Localization/exceptions.netcore.json
+++ /dev/null
@@ -1,9 +0,0 @@
-[
-    {
-        "OldTypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizerFactory : Microsoft.Extensions.Localization.IStringLocalizerFactory",
-        "OldMemberId": "public .ctor(Microsoft.AspNetCore.Hosting.IHostingEnvironment hostingEnvironment, Microsoft.Extensions.Options.IOptions<Microsoft.Extensions.Localization.LocalizationOptions> localizationOptions)",
-        "NewTypeId": "public class Microsoft.Extensions.Localization.ResourceManagerStringLocalizerFactory : Microsoft.Extensions.Localization.IStringLocalizerFactory",
-        "NewMemberId": "public .ctor(Microsoft.Extensions.Options.IOptions<Microsoft.Extensions.Localization.LocalizationOptions> localizationOptions)",
-        "Kind": "Modification"
-    }
-]
\ No newline at end of file