diff --git a/src/Microsoft.AspNet.HttpFeature/IHttpTransportLayerSecurityFeature.cs b/src/Microsoft.AspNet.HttpFeature/IHttpClientCertificateFeature.cs similarity index 54% rename from src/Microsoft.AspNet.HttpFeature/IHttpTransportLayerSecurityFeature.cs rename to src/Microsoft.AspNet.HttpFeature/IHttpClientCertificateFeature.cs index 1eb020776f..ccaf9b1298 100644 --- a/src/Microsoft.AspNet.HttpFeature/IHttpTransportLayerSecurityFeature.cs +++ b/src/Microsoft.AspNet.HttpFeature/IHttpClientCertificateFeature.cs @@ -8,9 +8,17 @@ using Microsoft.Framework.Runtime; namespace Microsoft.AspNet.HttpFeature { [AssemblyNeutral] - public interface IHttpTransportLayerSecurityFeature + public interface IHttpClientCertificateFeature { + /// + /// Synchronously retrieves the client certificate, if any. + /// X509Certificate ClientCertificate { get; set; } - Task LoadAsync(); + + /// + /// Asynchronously retrieves the client certificate, if any. + /// + /// + Task GetClientCertificateAsync(); } } diff --git a/src/Microsoft.AspNet.HttpFeature/Microsoft.AspNet.HttpFeature.kproj b/src/Microsoft.AspNet.HttpFeature/Microsoft.AspNet.HttpFeature.kproj index 96237c3118..d9f328a5d5 100644 --- a/src/Microsoft.AspNet.HttpFeature/Microsoft.AspNet.HttpFeature.kproj +++ b/src/Microsoft.AspNet.HttpFeature/Microsoft.AspNet.HttpFeature.kproj @@ -29,7 +29,7 @@ - + diff --git a/src/Microsoft.AspNet.Owin/OwinEnvironment.cs b/src/Microsoft.AspNet.Owin/OwinEnvironment.cs index 38cb35443c..82656dcba9 100644 --- a/src/Microsoft.AspNet.Owin/OwinEnvironment.cs +++ b/src/Microsoft.AspNet.Owin/OwinEnvironment.cs @@ -67,9 +67,9 @@ namespace Microsoft.AspNet.Owin if (context.Request.IsSecure) { - _entries.Add(OwinConstants.CommonKeys.ClientCertificate, new FeatureMap(feature => feature.ClientCertificate, + _entries.Add(OwinConstants.CommonKeys.ClientCertificate, new FeatureMap(feature => feature.ClientCertificate, (feature, value) => feature.ClientCertificate = (X509Certificate)value)); - _entries.Add(OwinConstants.CommonKeys.LoadClientCertAsync, new FeatureMap(feature => new Func(feature.LoadAsync))); + _entries.Add(OwinConstants.CommonKeys.LoadClientCertAsync, new FeatureMap(feature => new Func(feature.GetClientCertificateAsync))); } _context.Items[typeof(HttpContext).FullName] = _context; // Store for lookup when we transition back out of OWIN diff --git a/src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs b/src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs index c0f75caa46..0e0a5abeb9 100644 --- a/src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs +++ b/src/Microsoft.AspNet.Owin/OwinFeatureCollection.cs @@ -24,7 +24,7 @@ namespace Microsoft.AspNet.Owin IHttpResponseFeature, IHttpConnectionFeature, IHttpSendFileFeature, - IHttpTransportLayerSecurityFeature, + IHttpClientCertificateFeature, IOwinEnvironmentFeature { public IDictionary Environment { get; set; } @@ -197,13 +197,13 @@ namespace Microsoft.AspNet.Owin } } - X509Certificate IHttpTransportLayerSecurityFeature.ClientCertificate + X509Certificate IHttpClientCertificateFeature.ClientCertificate { get { return Prop(OwinConstants.CommonKeys.ClientCertificate); } set { Prop(OwinConstants.CommonKeys.ClientCertificate, value); } } - Task IHttpTransportLayerSecurityFeature.LoadAsync() + Task IHttpClientCertificateFeature.GetClientCertificateAsync() { throw new NotImplementedException(); } @@ -228,7 +228,7 @@ namespace Microsoft.AspNet.Owin { return SupportsSendFile; } - else if (key == typeof(IHttpTransportLayerSecurityFeature)) + else if (key == typeof(IHttpClientCertificateFeature)) { return SupportsClientCerts; } @@ -256,7 +256,7 @@ namespace Microsoft.AspNet.Owin } if (SupportsClientCerts) { - keys.Add(typeof(IHttpTransportLayerSecurityFeature)); + keys.Add(typeof(IHttpClientCertificateFeature)); } return keys; } diff --git a/src/Microsoft.AspNet.PipelineCore/DefaultHttpRequest.cs b/src/Microsoft.AspNet.PipelineCore/DefaultHttpRequest.cs index e99c7e0b02..29a1e34b4c 100644 --- a/src/Microsoft.AspNet.PipelineCore/DefaultHttpRequest.cs +++ b/src/Microsoft.AspNet.PipelineCore/DefaultHttpRequest.cs @@ -22,7 +22,7 @@ namespace Microsoft.AspNet.PipelineCore private FeatureReference _request = FeatureReference.Default; private FeatureReference _connection = FeatureReference.Default; - private FeatureReference _transportLayerSecurity = FeatureReference.Default; + private FeatureReference _clientCertificate = FeatureReference.Default; private FeatureReference _query = FeatureReference.Default; private FeatureReference _form = FeatureReference.Default; private FeatureReference _cookies = FeatureReference.Default; @@ -43,9 +43,9 @@ namespace Microsoft.AspNet.PipelineCore get { return _connection.Fetch(_features); } } - private IHttpTransportLayerSecurityFeature HttpTransportLayerSecurityFeature + private IHttpClientCertificateFeature HttpClientCertificateFeature { - get { return _transportLayerSecurity.Fetch(_features); } + get { return _clientCertificate.Fetch(_features); } } private IQueryFeature QueryFeature