From b64a32f089f06c8c403f8bb9ee085a580c9555e2 Mon Sep 17 00:00:00 2001
From: Hao Kung <haok@microsoft.com>
Date: Fri, 13 Jan 2017 12:55:24 -0800
Subject: [PATCH] Expose options/other services on managers

---
 src/Microsoft.AspNetCore.Identity/RoleManager.cs   |  8 ++++----
 src/Microsoft.AspNetCore.Identity/SignInManager.cs | 12 +++++-------
 src/Microsoft.AspNetCore.Identity/UserManager.cs   | 14 +++++++-------
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/src/Microsoft.AspNetCore.Identity/RoleManager.cs b/src/Microsoft.AspNetCore.Identity/RoleManager.cs
index 38be51f521..b64facc200 100644
--- a/src/Microsoft.AspNetCore.Identity/RoleManager.cs
+++ b/src/Microsoft.AspNetCore.Identity/RoleManager.cs
@@ -69,13 +69,13 @@ namespace Microsoft.AspNetCore.Identity
         /// <value>
         /// The <see cref="ILogger"/> used to log messages from the manager.
         /// </value>
-        protected internal virtual ILogger Logger { get; set; }
+        public virtual ILogger Logger { get; set; }
 
         /// <summary>
         /// Gets a list of validators for roles to call before persistence.
         /// </summary>
         /// <value>A list of validators for roles to call before persistence.</value>
-        internal IList<IRoleValidator<TRole>> RoleValidators { get; } = new List<IRoleValidator<TRole>>();
+        public IList<IRoleValidator<TRole>> RoleValidators { get; } = new List<IRoleValidator<TRole>>();
 
         /// <summary>
         /// Gets the <see cref="IdentityErrorDescriber"/> used to provider error messages.
@@ -83,7 +83,7 @@ namespace Microsoft.AspNetCore.Identity
         /// <value>
         /// The <see cref="IdentityErrorDescriber"/> used to provider error messages.
         /// </value>
-        internal IdentityErrorDescriber ErrorDescriber { get; set; }
+        public IdentityErrorDescriber ErrorDescriber { get; set; }
 
         /// <summary>
         /// Gets the normalizer to use when normalizing role names to keys.
@@ -91,7 +91,7 @@ namespace Microsoft.AspNetCore.Identity
         /// <value>
         /// The normalizer to use when normalizing role names to keys.
         /// </value>
-        internal ILookupNormalizer KeyNormalizer { get; set; }
+        public ILookupNormalizer KeyNormalizer { get; set; }
 
         /// <summary>
         /// Gets an IQueryable collection of Roles if the persistence store is an <see cref="IQueryableRoleStore{TRole}"/>,
diff --git a/src/Microsoft.AspNetCore.Identity/SignInManager.cs b/src/Microsoft.AspNetCore.Identity/SignInManager.cs
index 665bb74276..a93d2ca14d 100644
--- a/src/Microsoft.AspNetCore.Identity/SignInManager.cs
+++ b/src/Microsoft.AspNetCore.Identity/SignInManager.cs
@@ -5,8 +5,6 @@ using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Security.Claims;
-using System.Security.Cryptography;
-using System.Text;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Builder;
@@ -71,27 +69,27 @@ namespace Microsoft.AspNetCore.Identity
         /// <value>
         /// The <see cref="ILogger"/> used to log messages from the manager.
         /// </value>
-        protected internal virtual ILogger Logger { get; set; }
+        public virtual ILogger Logger { get; set; }
 
         /// <summary>
         /// The <see cref="UserManager{TUser}"/> used.
         /// </summary>
-        protected internal UserManager<TUser> UserManager { get; set; }
+        public UserManager<TUser> UserManager { get; set; }
 
         /// <summary>
         /// The <see cref="IUserClaimsPrincipalFactory{TUser}"/> used.
         /// </summary>
-        protected internal IUserClaimsPrincipalFactory<TUser> ClaimsFactory { get; set; }
+        public IUserClaimsPrincipalFactory<TUser> ClaimsFactory { get; set; }
 
         /// <summary>
         /// The <see cref="IdentityOptions"/> used.
         /// </summary>
-        protected internal IdentityOptions Options { get; set; }
+        public IdentityOptions Options { get; set; }
 
         /// <summary>
         /// The <see cref="HttpContext"/> used.
         /// </summary>
-        protected internal HttpContext Context { 
+        public HttpContext Context { 
             get
             {
                 var context = _context ?? _contextAccessor?.HttpContext;
diff --git a/src/Microsoft.AspNetCore.Identity/UserManager.cs b/src/Microsoft.AspNetCore.Identity/UserManager.cs
index 1ff42833ad..9a969107be 100644
--- a/src/Microsoft.AspNetCore.Identity/UserManager.cs
+++ b/src/Microsoft.AspNetCore.Identity/UserManager.cs
@@ -122,37 +122,37 @@ namespace Microsoft.AspNetCore.Identity
         /// <value>
         /// The <see cref="ILogger"/> used to log messages from the manager.
         /// </value>
-        protected internal virtual ILogger Logger { get; set; }
+        public virtual ILogger Logger { get; set; }
 
         /// <summary>
         /// The <see cref="IPasswordHasher{TUser}"/> used to hash passwords.
         /// </summary>
-        protected internal IPasswordHasher<TUser> PasswordHasher { get; set; }
+        public IPasswordHasher<TUser> PasswordHasher { get; set; }
 
         /// <summary>
         /// The <see cref="IUserValidator{TUser}"/> used to validate users.
         /// </summary>
-        protected internal IList<IUserValidator<TUser>> UserValidators { get; } = new List<IUserValidator<TUser>>();
+        public IList<IUserValidator<TUser>> UserValidators { get; } = new List<IUserValidator<TUser>>();
 
         /// <summary>
         /// The <see cref="IPasswordValidator{TUser}"/> used to validate passwords.
         /// </summary>
-        protected internal IList<IPasswordValidator<TUser>> PasswordValidators { get; } = new List<IPasswordValidator<TUser>>();
+        public IList<IPasswordValidator<TUser>> PasswordValidators { get; } = new List<IPasswordValidator<TUser>>();
 
         /// <summary>
         /// The <see cref="ILookupNormalizer"/> used to normalize things like user and role names.
         /// </summary>
-        protected internal ILookupNormalizer KeyNormalizer { get; set; }
+        public ILookupNormalizer KeyNormalizer { get; set; }
 
         /// <summary>
         /// The <see cref="IdentityErrorDescriber"/> used to generate error messages.
         /// </summary>
-        protected internal IdentityErrorDescriber ErrorDescriber { get; set; }
+        public IdentityErrorDescriber ErrorDescriber { get; set; }
 
         /// <summary>
         /// The <see cref="IdentityOptions"/> used to configure Identity.
         /// </summary>
-        protected internal IdentityOptions Options { get; set; }
+        public IdentityOptions Options { get; set; }
 
         /// <summary>
         /// Gets a flag indicating whether the backing user store supports authentication tokens.