From b5a2fcb96aeb55f1053a335df4fdaafc7eb5caf4 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Fri, 30 Mar 2018 01:57:14 -0700 Subject: [PATCH] Dispose the http client in DisposeAsync (#1780) - This layer of the stack is no longer reusable and this disposable was removed (I assume by mistake) in the big refactoring --- src/Microsoft.AspNetCore.Sockets.Client.Http/HttpConnection.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Microsoft.AspNetCore.Sockets.Client.Http/HttpConnection.cs b/src/Microsoft.AspNetCore.Sockets.Client.Http/HttpConnection.cs index ecae0d7d3c..80d6bbecf3 100644 --- a/src/Microsoft.AspNetCore.Sockets.Client.Http/HttpConnection.cs +++ b/src/Microsoft.AspNetCore.Sockets.Client.Http/HttpConnection.cs @@ -190,6 +190,8 @@ namespace Microsoft.AspNetCore.Sockets.Client.Http { Log.SkippingDispose(_logger); } + + _httpClient?.Dispose(); } finally {