Corrects spelling of some comments, method name and remove an excess flag
This commit is contained in:
parent
f15c995a2a
commit
b53d39e16f
|
|
@ -8,7 +8,7 @@ namespace Microsoft.AspNetCore.Blazor.Browser.Rendering
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Provides mechanisms for locating <see cref="BrowserRenderer"/> instances
|
/// Provides mechanisms for locating <see cref="BrowserRenderer"/> instances
|
||||||
/// by ID. This is used when receiving incoming events from the browser. It
|
/// by ID. This is used when receiving incoming events from the browser. It
|
||||||
/// implictly ensures that the <see cref="BrowserRenderer"/> instances and
|
/// implicitly ensures that the <see cref="BrowserRenderer"/> instances and
|
||||||
/// their associated component instances aren't GCed when events may still
|
/// their associated component instances aren't GCed when events may still
|
||||||
/// be received for them.
|
/// be received for them.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
|
|
|
||||||
|
|
@ -84,7 +84,7 @@ namespace Microsoft.AspNetCore.Blazor.Build.Test
|
||||||
$"Hello from @MyService1 and @MyService2").GetType();
|
$"Hello from @MyService1 and @MyService2").GetType();
|
||||||
|
|
||||||
// Assert 1: Compiled type has correct properties
|
// Assert 1: Compiled type has correct properties
|
||||||
var propertyFlags = BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.NonPublic;
|
var propertyFlags = BindingFlags.Instance | BindingFlags.NonPublic;
|
||||||
var injectableProperties = componentType.GetProperties(propertyFlags)
|
var injectableProperties = componentType.GetProperties(propertyFlags)
|
||||||
.Where(p => p.GetCustomAttribute<InjectAttribute>() != null);
|
.Where(p => p.GetCustomAttribute<InjectAttribute>() != null);
|
||||||
Assert.Collection(injectableProperties.OrderBy(p => p.Name),
|
Assert.Collection(injectableProperties.OrderBy(p => p.Name),
|
||||||
|
|
|
||||||
|
|
@ -85,13 +85,13 @@ namespace Test
|
||||||
// No documentation in this test
|
// No documentation in this test
|
||||||
Assert.Null(component.Documentation);
|
Assert.Null(component.Documentation);
|
||||||
|
|
||||||
// These are all trivally derived from the assembly/namespace/type name
|
// These are all trivially derived from the assembly/namespace/type name
|
||||||
Assert.Equal("TestAssembly", component.AssemblyName);
|
Assert.Equal("TestAssembly", component.AssemblyName);
|
||||||
Assert.Equal("Test.MyComponent", component.Name);
|
Assert.Equal("Test.MyComponent", component.Name);
|
||||||
Assert.Equal("Test.MyComponent", component.DisplayName);
|
Assert.Equal("Test.MyComponent", component.DisplayName);
|
||||||
Assert.Equal("Test.MyComponent", component.GetTypeName());
|
Assert.Equal("Test.MyComponent", component.GetTypeName());
|
||||||
|
|
||||||
// Our use of matching rules is also very simple, and derived from the name. Veriying
|
// Our use of matching rules is also very simple, and derived from the name. Verifying
|
||||||
// it once in detail here and then ignoring it.
|
// it once in detail here and then ignoring it.
|
||||||
var rule = Assert.Single(component.TagMatchingRules);
|
var rule = Assert.Single(component.TagMatchingRules);
|
||||||
Assert.Empty(rule.Attributes);
|
Assert.Empty(rule.Attributes);
|
||||||
|
|
@ -329,7 +329,7 @@ namespace Test
|
||||||
Assert.True(attribute.IsDelegateProperty());
|
Assert.True(attribute.IsDelegateProperty());
|
||||||
}
|
}
|
||||||
|
|
||||||
// For simplicity in testing, exlude the built-in components. We'll add more and we
|
// For simplicity in testing, exclude the built-in components. We'll add more and we
|
||||||
// don't want to update the tests when that happens.
|
// don't want to update the tests when that happens.
|
||||||
private TagHelperDescriptor[] ExcludeBuiltInComponents(TagHelperDescriptorProviderContext context)
|
private TagHelperDescriptor[] ExcludeBuiltInComponents(TagHelperDescriptorProviderContext context)
|
||||||
{
|
{
|
||||||
|
|
|
||||||
|
|
@ -134,7 +134,7 @@ namespace Microsoft.AspNetCore.Blazor.Test
|
||||||
var nestedComponent = (MessageComponent)nestedComponentFrame.Component;
|
var nestedComponent = (MessageComponent)nestedComponentFrame.Component;
|
||||||
var nestedComponentId = nestedComponentFrame.ComponentId;
|
var nestedComponentId = nestedComponentFrame.ComponentId;
|
||||||
|
|
||||||
// Assert: inital render
|
// Assert: initial render
|
||||||
nestedComponent.Message = "Render 1";
|
nestedComponent.Message = "Render 1";
|
||||||
nestedComponent.TriggerRender();
|
nestedComponent.TriggerRender();
|
||||||
var batch = renderer.Batches[1];
|
var batch = renderer.Batches[1];
|
||||||
|
|
|
||||||
|
|
@ -279,7 +279,7 @@ namespace Microsoft.AspNetCore.Blazor.Test.Routing
|
||||||
[InlineData("/{parameter}", "/{parameter}/")]
|
[InlineData("/{parameter}", "/{parameter}/")]
|
||||||
[InlineData("/literal/{parameter}", "/Literal/{something}")]
|
[InlineData("/literal/{parameter}", "/Literal/{something}")]
|
||||||
[InlineData("/{parameter}/literal/{something}", "{param}/Literal/{else}")]
|
[InlineData("/{parameter}/literal/{something}", "{param}/Literal/{else}")]
|
||||||
public void DetectsAmbigousRoutes(string left, string right)
|
public void DetectsAmbiguousRoutes(string left, string right)
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var expectedMessage = $@"The following routes are ambiguous:
|
var expectedMessage = $@"The following routes are ambiguous:
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue