From b2731d652d55488cf7e428662bd30ebd123f2ad6 Mon Sep 17 00:00:00 2001 From: Ben Adams Date: Thu, 13 Dec 2018 23:40:09 +0000 Subject: [PATCH] .IndexOf(...) >= 0 to .Contains(...) (#4688) --- src/Servers/Kestrel/Core/src/Internal/Http/HttpParser.cs | 2 +- src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpParser.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpParser.cs index 5e31fca253..c3a8fc2e8f 100644 --- a/src/Servers/Kestrel/Core/src/Internal/Http/HttpParser.cs +++ b/src/Servers/Kestrel/Core/src/Internal/Http/HttpParser.cs @@ -394,7 +394,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http // Check for CR in value var valueBuffer = new Span(headerLine + valueStart, valueEnd - valueStart + 1); - if (valueBuffer.IndexOf(ByteCR) >= 0) + if (valueBuffer.Contains(ByteCR)) { RejectRequestHeader(headerLine, length); } diff --git a/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs b/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs index bd89cb4d46..da9bbc9dfe 100644 --- a/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs +++ b/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs @@ -290,7 +290,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2 return false; } - var pathEncoded = pathSegment.IndexOf('%') >= 0; + var pathEncoded = pathSegment.Contains('%'); // Compare with Http1Connection.OnOriginFormTarget