Fix some spelling (#8378)

This commit is contained in:
Simon Cropp 2018-09-07 00:39:01 +10:00 committed by Pranav K
parent c0f3a46ffe
commit b156dee4f1
124 changed files with 297 additions and 297 deletions

View File

@ -105,7 +105,7 @@ namespace Microsoft.AspNetCore.Mvc.Performance
var state = routeContext.RouteData.PushState(MockRouter.Instance, routeValues, null); var state = routeContext.RouteData.PushState(MockRouter.Instance, routeValues, null);
var actual = NaiveSelectCandiates(_actions, routeContext.RouteData.Values); var actual = NaiveSelectCandidates(_actions, routeContext.RouteData.Values);
Verify(expected, actual); Verify(expected, actual);
state.Restore(); state.Restore();
@ -113,7 +113,7 @@ namespace Microsoft.AspNetCore.Mvc.Performance
} }
// A naive implementation we can use to generate match data for inputs, and for a baseline. // A naive implementation we can use to generate match data for inputs, and for a baseline.
private static IReadOnlyList<ActionDescriptor> NaiveSelectCandiates(ActionDescriptor[] actions, RouteValueDictionary routeValues) private static IReadOnlyList<ActionDescriptor> NaiveSelectCandidates(ActionDescriptor[] actions, RouteValueDictionary routeValues)
{ {
var results = new List<ActionDescriptor>(); var results = new List<ActionDescriptor>();
for (var i = 0; i < actions.Length; i++) for (var i = 0; i < actions.Length; i++)
@ -175,7 +175,7 @@ namespace Microsoft.AspNetCore.Mvc.Performance
{ {
var action = actions[i]; var action = actions[i];
var routeValues = new RouteValueDictionary(action.RouteValues); var routeValues = new RouteValueDictionary(action.RouteValues);
var matches = NaiveSelectCandiates(actions, routeValues); var matches = NaiveSelectCandidates(actions, routeValues);
if (matches.Count == 0) if (matches.Count == 0)
{ {
throw new InvalidOperationException("This should have at least one match."); throw new InvalidOperationException("This should have at least one match.");
@ -193,7 +193,7 @@ namespace Microsoft.AspNetCore.Mvc.Performance
// Make one of the route values not match. // Make one of the route values not match.
routeValues[routeValues.First().Key] = ((string)routeValues.First().Value) + "fkdkfdkkf"; routeValues[routeValues.First().Key] = ((string)routeValues.First().Value) + "fkdkfdkkf";
var matches = NaiveSelectCandiates(actions, routeValues); var matches = NaiveSelectCandidates(actions, routeValues);
if (matches.Count != 0) if (matches.Count != 0)
{ {
throw new InvalidOperationException("This should have 0 matches."); throw new InvalidOperationException("This should have 0 matches.");

View File

@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Mvc
} }
/// <summary> /// <summary>
/// Intializes a new instance of <see cref="ActionResult{TValue}"/> using the specified <see cref="ActionResult"/>. /// Initializes a new instance of <see cref="ActionResult{TValue}"/> using the specified <see cref="ActionResult"/>.
/// </summary> /// </summary>
/// <param name="result">The <see cref="ActionResult"/>.</param> /// <param name="result">The <see cref="ActionResult"/>.</param>
public ActionResult(ActionResult result) public ActionResult(ActionResult result)

View File

@ -60,7 +60,7 @@ namespace Microsoft.AspNetCore.Mvc
} }
else if (methods.Length > 1) else if (methods.Length > 1)
{ {
throw new ArgumentException(Resources.FormatApiConventionMethod_AmbigiousMethodName(methodName, conventionType), nameof(methodName)); throw new ArgumentException(Resources.FormatApiConventionMethod_AmbiguousMethodName(methodName, conventionType), nameof(methodName));
} }
return methods[0]; return methods[0];

View File

@ -23,7 +23,7 @@ namespace Microsoft.AspNetCore.Mvc.ApplicationParts
/// Gets the list of <see cref="ApplicationPart"/> instances. /// Gets the list of <see cref="ApplicationPart"/> instances.
/// <para> /// <para>
/// Instances in this collection are stored in precedence order. An <see cref="ApplicationPart"/> that appears /// Instances in this collection are stored in precedence order. An <see cref="ApplicationPart"/> that appears
/// earlier in the list has a higher precendence. /// earlier in the list has a higher precedence.
/// An <see cref="IApplicationFeatureProvider"/> may choose to use this an interface as a way to resolve conflicts when /// An <see cref="IApplicationFeatureProvider"/> may choose to use this an interface as a way to resolve conflicts when
/// multiple <see cref="ApplicationPart"/> instances resolve equivalent feature values. /// multiple <see cref="ApplicationPart"/> instances resolve equivalent feature values.
/// </para> /// </para>

View File

@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Mvc
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// By default, this maps to <see cref="ProblemDetails.Title"/> and should not change /// By default, this maps to <see cref="ProblemDetails.Title"/> and should not change
/// between multiple occurences of the same error. /// between multiple occurrences of the same error.
/// </remarks> /// </remarks>
public string Title { get; set; } public string Title { get; set; }
} }

View File

@ -32,7 +32,7 @@ namespace Microsoft.AspNetCore.Mvc
/// </example> /// </example>
/// </para> /// </para>
/// <para> /// <para>
/// Setting compatiblity version to a specific version will change the default values of various /// Setting compatibility version to a specific version will change the default values of various
/// settings to match a particular minor release of ASP.NET Core MVC. /// settings to match a particular minor release of ASP.NET Core MVC.
/// </para> /// </para>
/// </remarks> /// </remarks>

View File

@ -189,7 +189,7 @@ namespace Microsoft.AspNetCore.Mvc
// If there are multiple IConsumeActionConstraints which are defined at the class and // If there are multiple IConsumeActionConstraints which are defined at the class and
// at the action level, the one closest to the action overrides the others. To ensure this // at the action level, the one closest to the action overrides the others. To ensure this
// we take advantage of the fact that ConsumesAttribute is both an IActionFilter and an // we take advantage of the fact that ConsumesAttribute is both an IActionFilter and an
// IConsumeActionConstraint. Since filterdescriptor collection is ordered (the last filter is the one // IConsumeActionConstraint. Since FilterDescriptor collection is ordered (the last filter is the one
// closest to the action), we apply this constraint only if there is no IConsumeActionConstraint after this. // closest to the action), we apply this constraint only if there is no IConsumeActionConstraint after this.
return actionDescriptor.FilterDescriptors.Last( return actionDescriptor.FilterDescriptors.Last(
filter => filter.Filter is IConsumesActionConstraint).Filter == this; filter => filter.Filter is IConsumesActionConstraint).Filter == this;

View File

@ -16,9 +16,9 @@ namespace Microsoft.AspNetCore.Mvc
/// ///
/// <code> /// <code>
/// [HttpGet] /// [HttpGet]
/// public ProductModel GetProduct([FromServices] IProductModelRequestService productModelReqest) /// public ProductModel GetProduct([FromServices] IProductModelRequestService productModelRequest)
/// { /// {
/// return productModelReqest.Value; /// return productModelRequest.Value;
/// } /// }
/// </code> /// </code>
/// </example> /// </example>

View File

@ -61,7 +61,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
throw new ArgumentNullException(nameof(options)); throw new ArgumentNullException(nameof(options));
} }
// Evaluate DefaultValues onces so subclasses don't have to cache. // Evaluate DefaultValues once so subclasses don't have to cache.
var defaultValues = DefaultValues; var defaultValues = DefaultValues;
foreach (var @switch in options) foreach (var @switch in options)

View File

@ -134,7 +134,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
// Consumers who poll will observe a new action descriptor collection at step 2 - they will see // Consumers who poll will observe a new action descriptor collection at step 2 - they will see
// the new collection and ignore the change token. // the new collection and ignore the change token.
// //
// Consumers who listen to the change token will requery at step 4 - they will see the new collection // Consumers who listen to the change token will re-query at step 4 - they will see the new collection
// and new change token. // and new change token.
// //
// Anyone who acquires the collection and change token between steps 2 and 3 will be notified of // Anyone who acquires the collection and change token between steps 2 and 3 will be notified of

View File

@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
///</para> ///</para>
///<para> ///<para>
/// To be reactively notified of changes, downcast to <see cref="ActionDescriptorCollectionProvider"/> and /// To be reactively notified of changes, downcast to <see cref="ActionDescriptorCollectionProvider"/> and
/// subcribe to the change token returned from <see cref="ActionDescriptorCollectionProvider.GetChangeToken"/> /// subscribe to the change token returned from <see cref="ActionDescriptorCollectionProvider.GetChangeToken"/>
/// using <see cref="ChangeToken.OnChange(System.Func{IChangeToken}, System.Action)"/>. /// using <see cref="ChangeToken.OnChange(System.Func{IChangeToken}, System.Action)"/>.
/// </para> /// </para>
/// <para> /// <para>

View File

@ -12,14 +12,14 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
/// </summary> /// </summary>
/// <typeparam name="TResult">The type of <see cref="IActionResult"/>.</typeparam> /// <typeparam name="TResult">The type of <see cref="IActionResult"/>.</typeparam>
/// <remarks> /// <remarks>
/// Implementions of <see cref="IActionResultExecutor{TResult}"/> are typically called by the /// Implementations of <see cref="IActionResultExecutor{TResult}"/> are typically called by the
/// <see cref="IActionResult.ExecuteResultAsync(ActionContext)"/> method of the corresponding action result type. /// <see cref="IActionResult.ExecuteResultAsync(ActionContext)"/> method of the corresponding action result type.
/// Implementations should be registered as singleton services. /// Implementations should be registered as singleton services.
/// </remarks> /// </remarks>
public interface IActionResultExecutor<in TResult> where TResult : IActionResult public interface IActionResultExecutor<in TResult> where TResult : IActionResult
{ {
/// <summary> /// <summary>
/// Asynchronously excecutes the action result, by modifying the <see cref="HttpResponse"/>. /// Asynchronously executes the action result, by modifying the <see cref="HttpResponse"/>.
/// </summary> /// </summary>
/// <param name="context">The <see cref="ActionContext"/> associated with the current request."/></param> /// <param name="context">The <see cref="ActionContext"/> associated with the current request."/></param>
/// <param name="result">The action result to execute.</param> /// <param name="result">The action result to execute.</param>

View File

@ -165,7 +165,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
=> typeof(Task<IActionResult>).IsAssignableFrom(executor.MethodReturnType); => typeof(Task<IActionResult>).IsAssignableFrom(executor.MethodReturnType);
} }
// Task<PhysicalfileResult> DownloadFile(..) // Task<PhysicalFileResult> DownloadFile(..)
// ValueTask<ViewResult> GetViewsAsync(..) // ValueTask<ViewResult> GetViewsAsync(..)
private class TaskOfActionResultExecutor : ActionMethodExecutor private class TaskOfActionResultExecutor : ActionMethodExecutor
{ {

View File

@ -365,7 +365,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// We also want to add the same (as in reference equality) list of actions to the ordinal entries. // We also want to add the same (as in reference equality) list of actions to the ordinal entries.
// We'll keep updating `entries` to include all of the actions in the same equivalence class - // We'll keep updating `entries` to include all of the actions in the same equivalence class -
// meaning, all conventionally routed actions for which the route values are equalignoring case. // meaning, all conventionally routed actions for which the route values are equal ignoring case.
// //
// `entries` will appear in `OrdinalIgnoreCaseEntries` exactly once and in `OrdinalEntries` once // `entries` will appear in `OrdinalIgnoreCaseEntries` exactly once and in `OrdinalEntries` once
// for each variation of casing that we've seen. // for each variation of casing that we've seen.

View File

@ -30,7 +30,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
public RequestDelegate GetPipeline(Type configurationType) public RequestDelegate GetPipeline(Type configurationType)
{ {
// Build the pipeline only once. This is similar to how middlewares registered in Startup are constructed. // Build the pipeline only once. This is similar to how middleware registered in Startup are constructed.
var requestDelegate = _pipelinesCache.GetOrAdd( var requestDelegate = _pipelinesCache.GetOrAdd(
configurationType, configurationType,
@ -77,7 +77,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
// Ideally we want the experience of a middleware pipeline to behave the same as if it was registered // Ideally we want the experience of a middleware pipeline to behave the same as if it was registered
// in Startup. In this scenario, an Exception thrown in a middelware later in the pipeline gets // in Startup. In this scenario, an Exception thrown in a middleware later in the pipeline gets
// propagated back to earlier middleware. So, check if a later resource filter threw an Exception and // propagated back to earlier middleware. So, check if a later resource filter threw an Exception and
// propagate that back to the middleware pipeline. // propagate that back to the middleware pipeline.
resourceExecutedContext.ExceptionDispatchInfo?.Throw(); resourceExecutedContext.ExceptionDispatchInfo?.Throw();

View File

@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// - /Home/Index/{id?} // - /Home/Index/{id?}
// - /Home // - /Home
// - / // - /
if (UseDefaultValuePlusRemainingSegementsOptional(i, action, endpointInfo, newPathSegments)) if (UseDefaultValuePlusRemainingSegmentsOptional(i, action, endpointInfo, newPathSegments))
{ {
var subPathSegments = newPathSegments.Take(i); var subPathSegments = newPathSegments.Take(i);
@ -270,7 +270,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
} }
private bool UseDefaultValuePlusRemainingSegementsOptional( private bool UseDefaultValuePlusRemainingSegmentsOptional(
int segmentIndex, int segmentIndex,
ActionDescriptor action, ActionDescriptor action,
MvcEndpointInfo endpointInfo, MvcEndpointInfo endpointInfo,

View File

@ -45,7 +45,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
} }
// If the model type is IEnumerable<> then we need to know if we can assign a List<> to it, since // If the model type is IEnumerable<> then we need to know if we can assign a List<> to it, since
// that's what we would create. (The cases handled here are IEnumerable<>, IReadOnlyColection<> and // that's what we would create. (The cases handled here are IEnumerable<>, IReadOnlyCollection<> and
// IReadOnlyList<>). // IReadOnlyList<>).
var enumerableType = ClosedGenericMatcher.ExtractGenericInterface(modelType, typeof(IEnumerable<>)); var enumerableType = ClosedGenericMatcher.ExtractGenericInterface(modelType, typeof(IEnumerable<>));
if (enumerableType != null) if (enumerableType != null)

View File

@ -256,7 +256,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
// //
// If a property does not have a binding source, then it's fair game for any value provider. // If a property does not have a binding source, then it's fair game for any value provider.
// //
// If any property meets the above conditions and has a value from valueproviders, then we'll // If any property meets the above conditions and has a value from ValueProviders, then we'll
// create the model and try to bind it. OR if ALL properties of the model have a greedy source, // create the model and try to bind it. OR if ALL properties of the model have a greedy source,
// then we go ahead and create it. // then we go ahead and create it.
// //

View File

@ -82,11 +82,11 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
// enum FlagsEnum { Value1 = 1, Value2 = 2, Value4 = 4 } // enum FlagsEnum { Value1 = 1, Value2 = 2, Value4 = 4 }
// //
// Valid Scenarios: // Valid Scenarios:
// 1. valueproviderresult="Value2,Value4", model=Value2 | Value4, underlying=6, converted=Value2, Value4 // 1. valueProviderResult="Value2,Value4", model=Value2 | Value4, underlying=6, converted=Value2, Value4
// 2. valueproviderresult="2,4", model=Value2 | Value4, underlying=6, converted=Value2, Value4 // 2. valueProviderResult="2,4", model=Value2 | Value4, underlying=6, converted=Value2, Value4
// //
// Invalid Scenarios: // Invalid Scenarios:
// 1. valueproviderresult="2,10", model=12, underlying=12, converted=12 // 1. valueProviderResult="2,10", model=12, underlying=12, converted=12
// //
var underlying = Convert.ChangeType( var underlying = Convert.ChangeType(
model, model,

View File

@ -81,7 +81,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
var headerName = bindingContext.FieldName; var headerName = bindingContext.FieldName;
// Do not set ModelBindingResult to Failed on not finding the value in the header as we want the inner // Do not set ModelBindingResult to Failed on not finding the value in the header as we want the inner
// modelbinder to do that. This would give a chance to the inner binder to add more useful information. // ModelBinder to do that. This would give a chance to the inner binder to add more useful information.
// For example, SimpleTypeModelBinder adds a model error when binding to let's say an integer and the // For example, SimpleTypeModelBinder adds a model error when binding to let's say an integer and the
// model is null. // model is null.
var request = bindingContext.HttpContext.Request; var request = bindingContext.HttpContext.Request;

View File

@ -9,7 +9,7 @@ using Microsoft.Extensions.Primitives;
namespace Microsoft.AspNetCore.Mvc.ModelBinding namespace Microsoft.AspNetCore.Mvc.ModelBinding
{ {
// Normalizes keys, in a keyvaluepair collection, from jQuery format to a format that MVC understands. // Normalizes keys, in a KeyValuePair collection, from jQuery format to a format that MVC understands.
internal static class JQueryKeyValuePairNormalizer internal static class JQueryKeyValuePairNormalizer
{ {
public static IDictionary<string, StringValues> GetValues( public static IDictionary<string, StringValues> GetValues(

View File

@ -79,7 +79,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Metadata
var cacheEntry = GetCacheEntry(modelType); var cacheEntry = GetCacheEntry(modelType);
// We're relying on a safe race-condition for Properties - take care only // We're relying on a safe race-condition for Properties - take care only
// to set the value onces the properties are fully-initialized. // to set the value once the properties are fully-initialized.
if (cacheEntry.Details.Properties == null) if (cacheEntry.Details.Properties == null)
{ {
var key = ModelMetadataIdentity.ForType(modelType); var key = ModelMetadataIdentity.ForType(modelType);

View File

@ -1509,18 +1509,18 @@ namespace Microsoft.AspNetCore.Mvc.Core
=> string.Format(CultureInfo.CurrentCulture, GetString("ApiConvention_UnsupportedAttributesOnConvention"), p0, p1, p2); => string.Format(CultureInfo.CurrentCulture, GetString("ApiConvention_UnsupportedAttributesOnConvention"), p0, p1, p2);
/// <summary> /// <summary>
/// Method name '{0}' is ambigous for convention type '{1}'. More than one method found with the name '{0}'. /// Method name '{0}' is ambiguous for convention type '{1}'. More than one method found with the name '{0}'.
/// </summary> /// </summary>
internal static string ApiConventionMethod_AmbigiousMethodName internal static string ApiConventionMethod_AmbiguousMethodName
{ {
get => GetString("ApiConventionMethod_AmbigiousMethodName"); get => GetString("ApiConventionMethod_AmbiguousMethodName");
} }
/// <summary> /// <summary>
/// Method name '{0}' is ambigous for convention type '{1}'. More than one method found with the name '{0}'. /// Method name '{0}' is ambiguous for convention type '{1}'. More than one method found with the name '{0}'.
/// </summary> /// </summary>
internal static string FormatApiConventionMethod_AmbigiousMethodName(object p0, object p1) internal static string FormatApiConventionMethod_AmbiguousMethodName(object p0, object p1)
=> string.Format(CultureInfo.CurrentCulture, GetString("ApiConventionMethod_AmbigiousMethodName"), p0, p1); => string.Format(CultureInfo.CurrentCulture, GetString("ApiConventionMethod_AmbiguousMethodName"), p0, p1);
/// <summary> /// <summary>
/// A method named '{0}' was not found on convention type '{1}'. /// A method named '{0}' was not found on convention type '{1}'.

View File

@ -451,8 +451,8 @@
<data name="ApiConvention_UnsupportedAttributesOnConvention" xml:space="preserve"> <data name="ApiConvention_UnsupportedAttributesOnConvention" xml:space="preserve">
<value>Method {0} is decorated with the following attributes that are not allowed on an API convention method:{1}The following attributes are allowed on API convention methods: {2}.</value> <value>Method {0} is decorated with the following attributes that are not allowed on an API convention method:{1}The following attributes are allowed on API convention methods: {2}.</value>
</data> </data>
<data name="ApiConventionMethod_AmbigiousMethodName" xml:space="preserve"> <data name="ApiConventionMethod_AmbiguousMethodName" xml:space="preserve">
<value>Method name '{0}' is ambigous for convention type '{1}'. More than one method found with the name '{0}'.</value> <value>Method name '{0}' is ambiguous for convention type '{1}'. More than one method found with the name '{0}'.</value>
</data> </data>
<data name="ApiConventionMethod_NoMethodFound" xml:space="preserve"> <data name="ApiConventionMethod_NoMethodFound" xml:space="preserve">
<value>A method named '{0}' was not found on convention type '{1}'.</value> <value>A method named '{0}' was not found on convention type '{1}'.</value>

View File

@ -462,7 +462,7 @@ namespace Microsoft.AspNetCore.Mvc
if (!routeValues.ContainsKey("handler") && if (!routeValues.ContainsKey("handler") &&
ambientValues.TryGetValue("handler", out var handler)) ambientValues.TryGetValue("handler", out var handler))
{ {
// Clear out formaction unless it's explicitly specified in the routeValues. // Clear out form action unless it's explicitly specified in the routeValues.
routeValues["handler"] = null; routeValues["handler"] = null;
} }
} }

View File

@ -14,7 +14,7 @@ namespace Microsoft.AspNetCore.Mvc
public class ValidationProblemDetails : ProblemDetails public class ValidationProblemDetails : ProblemDetails
{ {
/// <summary> /// <summary>
/// Intializes a new instance of <see cref="ValidationProblemDetails"/>. /// Initializes a new instance of <see cref="ValidationProblemDetails"/>.
/// </summary> /// </summary>
public ValidationProblemDetails() public ValidationProblemDetails()
{ {

View File

@ -32,7 +32,7 @@ namespace Microsoft.AspNetCore.Mvc
} }
/// <summary> /// <summary>
/// Gets or sets a flag to determine whether error messsages from JSON deserialization by the /// Gets or sets a flag to determine whether error messages from JSON deserialization by the
/// <see cref="JsonInputFormatter"/> will be added to the <see cref="ModelStateDictionary"/>. The default /// <see cref="JsonInputFormatter"/> will be added to the <see cref="ModelStateDictionary"/>. The default
/// value is <c>false</c>, meaning that a generic error message will be used instead. /// value is <c>false</c>, meaning that a generic error message will be used instead.
/// </summary> /// </summary>

View File

@ -25,12 +25,12 @@ namespace Microsoft.AspNetCore.Mvc.ApplicationParts
if (duplicates != null) if (duplicates != null)
{ {
var viewsDiffereningInCase = string.Join(Environment.NewLine, duplicates.Select(d => d.Identifier)); var viewsDifferingInCase = string.Join(Environment.NewLine, duplicates.Select(d => d.Identifier));
var message = string.Join( var message = string.Join(
Environment.NewLine, Environment.NewLine,
Resources.RazorViewCompiler_ViewPathsDifferOnlyInCase, Resources.RazorViewCompiler_ViewPathsDifferOnlyInCase,
viewsDiffereningInCase); viewsDifferingInCase);
throw new InvalidOperationException(message); throw new InvalidOperationException(message);
} }

View File

@ -35,12 +35,12 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Compilation
{ {
// Ensure parts do not specify views with differing cases. This is not supported // Ensure parts do not specify views with differing cases. This is not supported
// at runtime and we should flag at as such for precompiled views. // at runtime and we should flag at as such for precompiled views.
var viewsDiffereningInCase = string.Join(Environment.NewLine, duplicates.Select(d => d.RelativePath)); var viewsDifferingInCase = string.Join(Environment.NewLine, duplicates.Select(d => d.RelativePath));
var message = string.Join( var message = string.Join(
Environment.NewLine, Environment.NewLine,
Resources.RazorViewCompiler_ViewPathsDifferOnlyInCase, Resources.RazorViewCompiler_ViewPathsDifferOnlyInCase,
viewsDiffereningInCase); viewsDifferingInCase);
throw new InvalidOperationException(message); throw new InvalidOperationException(message);
} }

View File

@ -81,7 +81,7 @@ namespace Microsoft.Extensions.DependencyInjection
// ViewFeature items have precedence semantics - when two views have the same path \ identifier, // ViewFeature items have precedence semantics - when two views have the same path \ identifier,
// the one that appears earlier in the list wins. Therefore the ordering of // the one that appears earlier in the list wins. Therefore the ordering of
// RazorCompiledItemFeatureProvider and ViewsFeatureProvider is pertinent - any view compiled // RazorCompiledItemFeatureProvider and ViewsFeatureProvider is pertinent - any view compiled
// using the Sdk will be prefered to views compiled using MvcPrecompilation. // using the Sdk will be preferred to views compiled using MvcPrecompilation.
if (!builder.PartManager.FeatureProviders.OfType<RazorCompiledItemFeatureProvider>().Any()) if (!builder.PartManager.FeatureProviders.OfType<RazorCompiledItemFeatureProvider>().Any())
{ {
builder.PartManager.FeatureProviders.Add(new RazorCompiledItemFeatureProvider()); builder.PartManager.FeatureProviders.Add(new RazorCompiledItemFeatureProvider());

View File

@ -90,7 +90,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal
// from either the set of known precompiled views, or by being compiled. // from either the set of known precompiled views, or by being compiled.
_cache = cache; _cache = cache;
// We need to validate that the all of the precompiled views are unique by path (case-insenstive). // We need to validate that the all of the precompiled views are unique by path (case-insensitive).
// We do this because there's no good way to canonicalize paths on windows, and it will create // We do this because there's no good way to canonicalize paths on windows, and it will create
// problems when deploying to linux. Rather than deal with these issues, we just don't support // problems when deploying to linux. Rather than deal with these issues, we just don't support
// views that differ only by case. // views that differ only by case.
@ -293,7 +293,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal
_logger.ViewCompilerCouldNotFindFileAtPath(normalizedPath); _logger.ViewCompilerCouldNotFindFileAtPath(normalizedPath);
// If the file doesn't exist, we can't do compilation right now - we still want to cache // If the file doesn't exist, we can't do compilation right now - we still want to cache
// the fact that we tried. This will allow us to retrigger compilation if the view file // the fact that we tried. This will allow us to re-trigger compilation if the view file
// is added. // is added.
return new ViewCompilerWorkItem() return new ViewCompilerWorkItem()
{ {

View File

@ -41,7 +41,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
public void OnProvidersExecuting(PageRouteModelProviderContext context) public void OnProvidersExecuting(PageRouteModelProviderContext context)
{ {
// When RootDirectory and AreaRootDirectory overlap, e.g. RootDirectory = /, AreaRootDirectoryy = /Areas; // When RootDirectory and AreaRootDirectory overlap, e.g. RootDirectory = /, AreaRootDirectory = /Areas;
// we need to ensure that the page is only route-able via the area route. By adding area routes first, // we need to ensure that the page is only route-able via the area route. By adding area routes first,
// we'll ensure non area routes get skipped when it encounters an IsAlreadyRegistered check. // we'll ensure non area routes get skipped when it encounters an IsAlreadyRegistered check.
@ -128,7 +128,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
private static bool IsRouteable(RazorProjectItem item) private static bool IsRouteable(RazorProjectItem item)
{ {
// Pages like _ViewImports should not be routable. // Pages like _ViewImports should not be routeable.
return !item.FileName.StartsWith("_", StringComparison.OrdinalIgnoreCase); return !item.FileName.StartsWith("_", StringComparison.OrdinalIgnoreCase);
} }
} }

View File

@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers.Cache
public class CacheTagKey : IEquatable<CacheTagKey> public class CacheTagKey : IEquatable<CacheTagKey>
{ {
private static readonly char[] AttributeSeparator = new[] { ',' }; private static readonly char[] AttributeSeparator = new[] { ',' };
private static readonly Func<IRequestCookieCollection, string, string> CookieAcccessor = (c, key) => c[key]; private static readonly Func<IRequestCookieCollection, string, string> CookieAccessor = (c, key) => c[key];
private static readonly Func<IHeaderDictionary, string, string> HeaderAccessor = (c, key) => c[key]; private static readonly Func<IHeaderDictionary, string, string> HeaderAccessor = (c, key) => c[key];
private static readonly Func<IQueryCollection, string, string> QueryAccessor = (c, key) => c[key]; private static readonly Func<IQueryCollection, string, string> QueryAccessor = (c, key) => c[key];
private static readonly Func<RouteValueDictionary, string, string> RouteValueAccessor = (c, key) => c[key]?.ToString(); private static readonly Func<RouteValueDictionary, string, string> RouteValueAccessor = (c, key) => c[key]?.ToString();
@ -87,7 +87,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers.Cache
_expiresOn = tagHelper.ExpiresOn; _expiresOn = tagHelper.ExpiresOn;
_expiresSliding = tagHelper.ExpiresSliding; _expiresSliding = tagHelper.ExpiresSliding;
_varyBy = tagHelper.VaryBy; _varyBy = tagHelper.VaryBy;
_cookies = ExtractCollection(tagHelper.VaryByCookie, request.Cookies, CookieAcccessor); _cookies = ExtractCollection(tagHelper.VaryByCookie, request.Cookies, CookieAccessor);
_headers = ExtractCollection(tagHelper.VaryByHeader, request.Headers, HeaderAccessor); _headers = ExtractCollection(tagHelper.VaryByHeader, request.Headers, HeaderAccessor);
_queries = ExtractCollection(tagHelper.VaryByQuery, request.Query, QueryAccessor); _queries = ExtractCollection(tagHelper.VaryByQuery, request.Query, QueryAccessor);
_routeValues = ExtractCollection(tagHelper.VaryByRoute, tagHelper.ViewContext.RouteData.Values, RouteValueAccessor); _routeValues = ExtractCollection(tagHelper.VaryByRoute, tagHelper.ViewContext.RouteData.Values, RouteValueAccessor);

View File

@ -141,7 +141,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
// can't be put inside a using block. // can't be put inside a using block.
entry.Dispose(); entry.Dispose();
// Set the result on the TCS once we've commited the entry to the cache since commiting to the cache // Set the result on the TCS once we've committed the entry to the cache since commiting to the cache
// may throw. // may throw.
tcs.SetResult(content); tcs.SetResult(content);
return content; return content;

View File

@ -167,9 +167,9 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
} }
/// <inheritdoc /> /// <inheritdoc />
/// <remarks>Does nothing if user provides an <c>formaction</c> attribute.</remarks> /// <remarks>Does nothing if user provides an <c>FormAction</c> attribute.</remarks>
/// <exception cref="InvalidOperationException"> /// <exception cref="InvalidOperationException">
/// Thrown if <c>formaction</c> attribute is provided and <see cref="Action"/>, <see cref="Controller"/>, /// Thrown if <c>FormAction</c> attribute is provided and <see cref="Action"/>, <see cref="Controller"/>,
/// <see cref="Fragment"/> or <see cref="Route"/> are non-<c>null</c> or if the user provided <c>asp-route-*</c> attributes. /// <see cref="Fragment"/> or <see cref="Route"/> are non-<c>null</c> or if the user provided <c>asp-route-*</c> attributes.
/// Also thrown if <see cref="Route"/> and one or both of <see cref="Action"/> and <see cref="Controller"/> /// Also thrown if <see cref="Route"/> and one or both of <see cref="Action"/> and <see cref="Controller"/>
/// are non-<c>null</c> /// are non-<c>null</c>
@ -186,7 +186,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
throw new ArgumentNullException(nameof(output)); throw new ArgumentNullException(nameof(output));
} }
// If "formaction" is already set, it means the user is attempting to use a normal button or input element. // If "FormAction" is already set, it means the user is attempting to use a normal button or input element.
if (output.Attributes.ContainsName(FormAction)) if (output.Attributes.ContainsName(FormAction))
{ {
if (Action != null || if (Action != null ||
@ -198,7 +198,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
Route != null || Route != null ||
(_routeValues != null && _routeValues.Count > 0)) (_routeValues != null && _routeValues.Count > 0))
{ {
// User specified a formaction and one of the bound attributes; can't override that formaction // User specified a FormAction and one of the bound attributes; can't override that FormAction
// attribute. // attribute.
throw new InvalidOperationException( throw new InvalidOperationException(
Resources.FormatFormActionTagHelper_CannotOverrideFormAction( Resources.FormatFormActionTagHelper_CannotOverrideFormAction(

View File

@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
public class RenderAtEndOfFormTagHelper : TagHelper public class RenderAtEndOfFormTagHelper : TagHelper
{ {
// This TagHelper's order must be greater than the FormTagHelper's. I.e it must be executed after // This TagHelper's order must be greater than the FormTagHelper's. I.e it must be executed after
// FormTaghelper does. // FormTagHelper does.
/// <inheritdoc /> /// <inheritdoc />
public override int Order => -900; public override int Order => -900;

View File

@ -64,7 +64,7 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
var copiedAttribute = false; var copiedAttribute = false;
// We iterate context.AllAttributes backwards since we prioritize TagHelperOutput values occurring // We iterate context.AllAttributes backwards since we prioritize TagHelperOutput values occurring
// before the current context.AllAttribtes[i]. // before the current context.AllAttributes[i].
for (var i = context.AllAttributes.Count - 1; i >= 0; i--) for (var i = context.AllAttributes.Count - 1; i >= 0; i--)
{ {
// We look for the original attribute so we can restore the exact attribute name the user typed in // We look for the original attribute so we can restore the exact attribute name the user typed in

View File

@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Mvc.Testing.Handlers
/// <summary> /// <summary>
/// Creates a new instance of <see cref="RedirectHandler"/>. /// Creates a new instance of <see cref="RedirectHandler"/>.
/// </summary> /// </summary>
/// <param name="maxRedirects">The maximun number of redirect responses to follow. It must be /// <param name="maxRedirects">The maximum number of redirect responses to follow. It must be
/// equal or greater than 0.</param> /// equal or greater than 0.</param>
public RedirectHandler(int maxRedirects) public RedirectHandler(int maxRedirects)
{ {

View File

@ -41,7 +41,7 @@ namespace Microsoft.AspNetCore.Mvc.Testing
/// <see cref="WebApplicationFactoryContentRootAttribute"/> on the assembly containing the functional tests with /// <see cref="WebApplicationFactoryContentRootAttribute"/> on the assembly containing the functional tests with
/// a key equal to the <typeparamref name="TEntryPoint"/> assembly <see cref="Assembly.FullName"/>. /// a key equal to the <typeparamref name="TEntryPoint"/> assembly <see cref="Assembly.FullName"/>.
/// In case an attribute with the right key can't be found, <see cref="WebApplicationFactory{TEntryPoint}"/> /// In case an attribute with the right key can't be found, <see cref="WebApplicationFactory{TEntryPoint}"/>
/// will fall back to searching for a solution file (*.sln) and then appending <typeparamref name="TEntryPoint"/> asembly name /// will fall back to searching for a solution file (*.sln) and then appending <typeparamref name="TEntryPoint"/> assembly name
/// to the solution directory. The application root directory will be used to discover views and content files. /// to the solution directory. The application root directory will be used to discover views and content files.
/// </para> /// </para>
/// <para> /// <para>

View File

@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc
/// Gets or sets <see cref="ViewDataDictionary"/> used by <see cref="ViewResult"/> and <see cref="ViewBag"/>. /// Gets or sets <see cref="ViewDataDictionary"/> used by <see cref="ViewResult"/> and <see cref="ViewBag"/>.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// By default, this property is intiailized when <see cref="Controllers.IControllerActivator"/> activates /// By default, this property is initialized when <see cref="Controllers.IControllerActivator"/> activates
/// controllers. /// controllers.
/// <para> /// <para>
/// This property can be accessed after the controller has been activated, for example, in a controller action /// This property can be accessed after the controller has been activated, for example, in a controller action

View File

@ -91,7 +91,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
} }
/// <inheritdoc /> /// <inheritdoc />
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
public IHtmlContentBuilder Append(string unencoded) public IHtmlContentBuilder Append(string unencoded)
{ {
@ -106,7 +106,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
} }
/// <inheritdoc /> /// <inheritdoc />
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
public IHtmlContentBuilder AppendHtml(IHtmlContent content) public IHtmlContentBuilder AppendHtml(IHtmlContent content)
{ {
@ -119,7 +119,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
} }
/// <inheritdoc /> /// <inheritdoc />
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
public IHtmlContentBuilder AppendHtml(string encoded) public IHtmlContentBuilder AppendHtml(string encoded)
{ {
@ -131,7 +131,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
return this; return this;
} }
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
private void AppendValue(ViewBufferValue value) private void AppendValue(ViewBufferValue value)
{ {
@ -139,7 +139,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
page.Append(value); page.Append(value);
} }
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
private ViewBufferPage GetCurrentPage() private ViewBufferPage GetCurrentPage()
{ {

View File

@ -20,7 +20,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
public bool IsFull => Count == Capacity; public bool IsFull => Count == Capacity;
// Very common trival method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339 // Very common trivial method; nudge it to inline https://github.com/aspnet/Mvc/pull/8339
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Append(ViewBufferValue value) => Buffer[Count++] = value; public void Append(ViewBufferValue value) => Buffer[Count++] = value;
} }

View File

@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures
Order = int.MinValue + 100; Order = int.MinValue + 100;
} }
// <inheritdoc /> /// <inheritdoc />
public int Order { get; set; } public int Order { get; set; }
/// <inheritdoc /> /// <inheritdoc />

View File

@ -1565,10 +1565,10 @@ namespace Microsoft.AspNetCore.Mvc.Description
} }
[Fact] [Fact]
public void GetApiDescription_ParameterDescription_RedundentMetadata_NotMergedWithParent() public void GetApiDescription_ParameterDescription_RedundantMetadata_NotMergedWithParent()
{ {
// Arrange // Arrange
var action = CreateActionDescriptor(nameof(AcceptsRedundentMetadata)); var action = CreateActionDescriptor(nameof(AcceptsRedundantMetadata));
var parameterDescriptor = action.Parameters.Single(); var parameterDescriptor = action.Parameters.Single();
// Act // Act
@ -1590,7 +1590,7 @@ namespace Microsoft.AspNetCore.Mvc.Description
} }
[Fact] [Fact]
public void GetApiDescription_ParameterDescription_RedundentMetadata_WithParameterMetadata() public void GetApiDescription_ParameterDescription_RedundantMetadata_WithParameterMetadata()
{ {
// Arrange // Arrange
var action = CreateActionDescriptor(nameof(AcceptsPerson)); var action = CreateActionDescriptor(nameof(AcceptsPerson));
@ -2081,7 +2081,7 @@ namespace Microsoft.AspNetCore.Mvc.Description
{ {
} }
private void AcceptsRedundentMetadata([FromQuery] RedundentMetadata r) private void AcceptsRedundantMetadata([FromQuery] RedundentMetadata r)
{ {
} }

View File

@ -219,7 +219,7 @@ namespace Microsoft.AspNetCore.Mvc
} }
[Fact] [Fact]
public void OnFormatting_NullUrlHelperContextNoRequestServices_ThrowsArgumentNullExeption() public void OnFormatting_NullUrlHelperContextNoRequestServices_ThrowsArgumentNullException()
{ {
// Arrange // Arrange
var context = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); var context = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor());

View File

@ -68,7 +68,7 @@ namespace Microsoft.AspNetCore.Mvc
public void Convert_InfersDeclaredTypeFromActionResultTypeParameter() public void Convert_InfersDeclaredTypeFromActionResultTypeParameter()
{ {
// Arrange // Arrange
var value = new DeriviedItem(); var value = new DerivedItem();
var actionResultOfT = new ActionResult<BaseItem>(value); var actionResultOfT = new ActionResult<BaseItem>(value);
var convertToActionResult = (IConvertToActionResult)actionResultOfT; var convertToActionResult = (IConvertToActionResult)actionResultOfT;
@ -85,7 +85,7 @@ namespace Microsoft.AspNetCore.Mvc
{ {
} }
private class DeriviedItem : BaseItem private class DerivedItem : BaseItem
{ {
} }
} }

View File

@ -85,14 +85,14 @@ namespace Microsoft.AspNetCore.Mvc
} }
[Fact] [Fact]
public void Constructor_ThrowsIfMethodIsAmbigous() public void Constructor_ThrowsIfMethodIsAmbiguous()
{ {
// Arrange // Arrange
var methodName = typeof(ConventionWithProducesAttribute).FullName + '.' + nameof(ConventionWithProducesAttribute.Get); var methodName = typeof(ConventionWithProducesAttribute).FullName + '.' + nameof(ConventionWithProducesAttribute.Get);
var attribute = typeof(ProducesAttribute); var attribute = typeof(ProducesAttribute);
var type = typeof(TestConventions); var type = typeof(TestConventions);
var expected = $"Method name 'Method' is ambigous for convention type '{type}'. More than one method found with the name 'Method'."; var expected = $"Method name 'Method' is ambiguous for convention type '{type}'. More than one method found with the name 'Method'.";
// Act & Assert // Act & Assert
ExceptionAssert.ThrowsArgument( ExceptionAssert.ThrowsArgument(

View File

@ -151,7 +151,7 @@ namespace Microsoft.AspNetCore.Mvc.ApiExplorer
} }
[Fact] [Fact]
public void IsNameMatch_WithPrefix_ReturnsFalse_IfNameIsNotProperPrfix() public void IsNameMatch_WithPrefix_ReturnsFalse_IfNameIsNotProperPrefix()
{ {
// Arrange // Arrange
var name = "Postman"; var name = "Postman";
@ -386,7 +386,7 @@ namespace Microsoft.AspNetCore.Mvc.ApiExplorer
} }
[Fact] [Fact]
public void IsMatch_ReturnsTrue_IfMethodNameAndParametersMatchs() public void IsMatch_ReturnsTrue_IfMethodNameAndParametersMatches()
{ {
// Arrange // Arrange
var method = typeof(TestController).GetMethod(nameof(TestController.Get)); var method = typeof(TestController).GetMethod(nameof(TestController.Get));

View File

@ -80,7 +80,7 @@ namespace Microsoft.AspNetCore.Mvc
[InlineData("application/json")] [InlineData("application/json")]
[InlineData("application/json;Parameter1=12")] [InlineData("application/json;Parameter1=12")]
[InlineData("text/xml")] [InlineData("text/xml")]
public void ActionConstraint_Accept_MatchesForMachingRequestContentType(string contentType) public void ActionConstraint_Accept_MatchesForMatchingRequestContentType(string contentType)
{ {
// Arrange // Arrange
var constraint = new ConsumesAttribute("application/json", "text/xml"); var constraint = new ConsumesAttribute("application/json", "text/xml");

View File

@ -1027,10 +1027,10 @@ namespace Microsoft.AspNetCore.Mvc.Core.Test
// Arrange // Arrange
var controller = new TestableController(); var controller = new TestableController();
var pageName = "/Page-Name"; var pageName = "/Page-Name";
var routeVaues = new { key = "value" }; var routeValues = new { key = "value" };
// Act // Act
var result = controller.RedirectToPage(pageName, routeVaues); var result = controller.RedirectToPage(pageName, routeValues);
// Assert // Assert
Assert.IsType<RedirectToPageResult>(result); Assert.IsType<RedirectToPageResult>(result);

View File

@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
Pipeline1.ConfigurePipeline = (ab) => Pipeline1.ConfigurePipeline = (ab) =>
{ {
configureCallCount++; configureCallCount++;
ab.Use((httpCtxt, next) => ab.Use((httpContext, next) =>
{ {
return next(); return next();
}); });

View File

@ -75,7 +75,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
httpContext.Setup(c => c.Request.Query.ContainsKey("format")).Returns(true); httpContext.Setup(c => c.Request.Query.ContainsKey("format")).Returns(true);
httpContext.Setup(c => c.Request.Query["format"]).Returns("xml"); httpContext.Setup(c => c.Request.Query["format"]).Returns("xml");
// Routedata contains json // RouteData contains json
var data = new RouteData(); var data = new RouteData();
data.Values.Add("format", "json"); data.Values.Add("format", "json");

View File

@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
{ {
get get
{ {
// object value, bool useDeclaredTypeAsString, bool expectedCanwriteResult, bool useNonNullContentType // object value, bool useDeclaredTypeAsString, bool expectedCanWriteResult, bool useNonNullContentType
yield return new object[] { "valid value", true, false, true }; yield return new object[] { "valid value", true, false, true };
yield return new object[] { "valid value", false, false, true }; yield return new object[] { "valid value", false, false, true };
yield return new object[] { "", false, false, true }; yield return new object[] { "", false, false, true };

View File

@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
} }
[Fact] [Fact]
public void Constructor_WithNameAndInitalValue_IsValueSetIsFalse() public void Constructor_WithNameAndInitialValue_IsValueSetIsFalse()
{ {
// Arrange & Act // Arrange & Act
var @switch = new CompatibilitySwitch<bool>("TestProperty", initialValue: true); var @switch = new CompatibilitySwitch<bool>("TestProperty", initialValue: true);
@ -36,7 +36,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
var @switch = new CompatibilitySwitch<bool>("TestProperty"); var @switch = new CompatibilitySwitch<bool>("TestProperty");
// Act // Act
@switch.Value = false; // You don't need to actually change the value, just caling the setting works @switch.Value = false; // You don't need to actually change the value, just calling the setting works
// Assert // Assert
Assert.False(@switch.Value); Assert.False(@switch.Value);

View File

@ -65,7 +65,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure
} }
[Fact] [Fact]
public void ActionDescriptors_UpdatesAndResubscripes_WhenChangeTokenTriggers() public void ActionDescriptors_UpdatesAndResubscribes_WhenChangeTokenTriggers()
{ {
// Arrange // Arrange
var actionDescriptorProvider = new Mock<IActionDescriptorProvider>(); var actionDescriptorProvider = new Mock<IActionDescriptorProvider>();

View File

@ -8,7 +8,7 @@ using Xunit;
namespace Microsoft.AspNetCore.Mvc.Infrastructure namespace Microsoft.AspNetCore.Mvc.Infrastructure
{ {
public class ProblemDetalsClientErrorFactoryTest public class ProblemDetailsClientErrorFactoryTest
{ {
[Fact] [Fact]
public void GetClientError_ReturnsProblemDetails_IfNoMappingWasFound() public void GetClientError_ReturnsProblemDetails_IfNoMappingWasFound()

View File

@ -227,7 +227,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public void InferBindingSourceForParameter_ReturnsPath_IfParameterAppearsInAnyRoutes_MulitpleRoutes() public void InferBindingSourceForParameter_ReturnsPath_IfParameterAppearsInAnyRoutes_MultipleRoutes()
{ {
// Arrange // Arrange
var actionName = nameof(ParameterBindingController.ParameterInMultipleRoutes); var actionName = nameof(ParameterBindingController.ParameterInMultipleRoutes);
@ -1112,7 +1112,7 @@ Environment.NewLine + "int b";
} }
[Fact] [Fact]
public void DiscoverErrorResponseType_UsesValueFromApiErrorTypeAttribute_SpecifiedOnControllerAsssembly() public void DiscoverErrorResponseType_UsesValueFromApiErrorTypeAttribute_SpecifiedOnControllerAssembly()
{ {
// Arrange // Arrange
var expected = typeof(InvalidEnumArgumentException); var expected = typeof(InvalidEnumArgumentException);

View File

@ -1175,7 +1175,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
[Theory] [Theory]
[InlineData("A", typeof(ApiExplorerEnabledConventionalRoutedController))] [InlineData("A", typeof(ApiExplorerEnabledConventionalRoutedController))]
[InlineData("A", typeof(ApiExplorerEnabledActionConventionalRoutedController))] [InlineData("A", typeof(ApiExplorerEnabledActionConventionalRoutedController))]
public void ApiExplorer_ThrowsForContentionalRouting(string actionName, Type type) public void ApiExplorer_ThrowsForConventionalRouting(string actionName, Type type)
{ {
// Arrange // Arrange
var assemblyName = type.GetTypeInfo().Assembly.GetName().Name; var assemblyName = type.GetTypeInfo().Assembly.GetName().Name;

View File

@ -1206,7 +1206,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Theory] [Theory]
[InlineData(nameof(TestController.AsynActionMethodWithTestActionResult))] [InlineData(nameof(TestController.AsyncActionMethodWithTestActionResult))]
[InlineData(nameof(TestController.ActionMethodWithTestActionResult))] [InlineData(nameof(TestController.ActionMethodWithTestActionResult))]
public async Task InvokeAction_ReturnTypeAsIActionResult_ReturnsExpected(string methodName) public async Task InvokeAction_ReturnTypeAsIActionResult_ReturnsExpected(string methodName)
{ {
@ -1654,7 +1654,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
return new TestActionResult { Value = value }; return new TestActionResult { Value = value };
} }
public async Task<TestActionResult> AsynActionMethodWithTestActionResult(int value) public async Task<TestActionResult> AsyncActionMethodWithTestActionResult(int value)
{ {
return await Task.FromResult<TestActionResult>(new TestActionResult { Value = value }); return await Task.FromResult<TestActionResult>(new TestActionResult { Value = value });
} }

View File

@ -89,7 +89,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public void EnumerateElements_TwoEnumerableImplemenations() public void EnumerateElements_TwoEnumerableImplementations()
{ {
// Arrange // Arrange
var model = new TwiceEnumerable(new int[] { 2, 3, 5 }); var model = new TwiceEnumerable(new int[] { 2, 3, 5 });

View File

@ -1316,7 +1316,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
{ {
{ model, new ValidationStateEntry() } { model, new ValidationStateEntry() }
}; };
var method = GetType().GetMethod(nameof(Validate_Throws_ForTopLeveleMetadataData), BindingFlags.NonPublic | BindingFlags.Instance); var method = GetType().GetMethod(nameof(Validate_Throws_ForTopLevelMetadataData), BindingFlags.NonPublic | BindingFlags.Instance);
var metadata = MetadataProvider.GetMetadataForParameter(method.GetParameters()[0]); var metadata = MetadataProvider.GetMetadataForParameter(method.GetParameters()[0]);
// Act & Assert // Act & Assert
@ -1465,7 +1465,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
void DoSomething(); void DoSomething();
} }
private void Validate_Throws_ForTopLeveleMetadataData(DepthObject depthObject) { } private void Validate_Throws_ForTopLevelMetadataData(DepthObject depthObject) { }
// Custom validation attribute that returns multiple entries in ValidationResult.MemberNames and those member // Custom validation attribute that returns multiple entries in ValidationResult.MemberNames and those member
// names are indexers. An example scenario is an attribute that confirms all entries in a list are unique. // names are indexers. An example scenario is an attribute that confirms all entries in a list are unique.

View File

@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
{ {
// Arrange // Arrange
var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance); var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance);
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize); authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize);
@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// Arrange // Arrange
var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance); var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance);
var disableRequestSizeLimitResourceFilterFinal = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance); var disableRequestSizeLimitResourceFilterFinal = new DisableRequestSizeLimitFilter(NullLoggerFactory.Instance);
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { disableRequestSizeLimitResourceFilter, disableRequestSizeLimitResourceFilterFinal }); new IFilterMetadata[] { disableRequestSizeLimitResourceFilter, disableRequestSizeLimitResourceFilterFinal });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
@ -60,7 +60,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var loggerFactory = new TestLoggerFactory(sink, enabled: true); var loggerFactory = new TestLoggerFactory(sink, enabled: true);
var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory); var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory);
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter });
// Act // Act
disableRequestSizeLimitResourceFilter.OnAuthorization(authorizationFilterContext); disableRequestSizeLimitResourceFilter.OnAuthorization(authorizationFilterContext);
@ -79,7 +79,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var loggerFactory = new TestLoggerFactory(sink, enabled: true); var loggerFactory = new TestLoggerFactory(sink, enabled: true);
var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory); var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory);
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
httpMaxRequestBodySize.IsReadOnly = true; httpMaxRequestBodySize.IsReadOnly = true;
@ -101,7 +101,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var loggerFactory = new TestLoggerFactory(sink, enabled: true); var loggerFactory = new TestLoggerFactory(sink, enabled: true);
var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory); var disableRequestSizeLimitResourceFilter = new DisableRequestSizeLimitFilter(loggerFactory);
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { disableRequestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize); authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize);
@ -114,7 +114,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
Assert.Equal($"The request body size limit has been disabled.", write.State.ToString()); Assert.Equal($"The request body size limit has been disabled.", write.State.ToString());
} }
private static AuthorizationFilterContext CreateauthorizationFilterContext(IFilterMetadata[] filters) private static AuthorizationFilterContext CreateAuthorizationFilterContext(IFilterMetadata[] filters)
{ {
return new AuthorizationFilterContext(CreateActionContext(), filters); return new AuthorizationFilterContext(CreateActionContext(), filters);
} }

View File

@ -90,7 +90,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public void EnumerateElements_TwoEnumerableImplemenations() public void EnumerateElements_TwoEnumerableImplementations()
{ {
// Arrange // Arrange
var model = new TwiceEnumerable(new int[] { 2, 3, 5 }); var model = new TwiceEnumerable(new int[] { 2, 3, 5 });

View File

@ -36,13 +36,13 @@ namespace Microsoft.AspNetCore.Mvc.Internal
{ {
// Arrange // Arrange
Task requestDelegate(HttpContext context) => Task.FromResult(true); Task requestDelegate(HttpContext context) => Task.FromResult(true);
var middlwareFilter = new MiddlewareFilter(requestDelegate); var middlewareFilter = new MiddlewareFilter(requestDelegate);
var httpContext = new DefaultHttpContext(); var httpContext = new DefaultHttpContext();
var resourceExecutingContext = GetResourceExecutingContext(httpContext); var resourceExecutingContext = GetResourceExecutingContext(httpContext);
var resourceExecutionDelegate = GetResourceExecutionDelegate(httpContext); var resourceExecutionDelegate = GetResourceExecutionDelegate(httpContext);
// Act // Act
await middlwareFilter.OnResourceExecutionAsync(resourceExecutingContext, resourceExecutionDelegate); await middlewareFilter.OnResourceExecutionAsync(resourceExecutingContext, resourceExecutionDelegate);
// Assert // Assert
var feature = resourceExecutingContext.HttpContext.Features.Get<IMiddlewareFilterFeature>(); var feature = resourceExecutingContext.HttpContext.Features.Get<IMiddlewareFilterFeature>();
@ -398,7 +398,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
logger, logger,
diagnosticSource, diagnosticSource,
mapper, mapper,
CreatControllerContext(actionContext, valueProviderFactories, maxAllowedErrorsInModelState), CreateControllerContext(actionContext, valueProviderFactories, maxAllowedErrorsInModelState),
CreateCacheEntry((ControllerActionDescriptor)actionContext.ActionDescriptor, controllerFactory), CreateCacheEntry((ControllerActionDescriptor)actionContext.ActionDescriptor, controllerFactory),
filters) filters)
{ {
@ -420,7 +420,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
return ObjectMethodExecutor.Create(actionDescriptor.MethodInfo, actionDescriptor.ControllerTypeInfo); return ObjectMethodExecutor.Create(actionDescriptor.MethodInfo, actionDescriptor.ControllerTypeInfo);
} }
private static ControllerContext CreatControllerContext( private static ControllerContext CreateControllerContext(
ActionContext actionContext, ActionContext actionContext,
IReadOnlyList<IValueProviderFactory> valueProviderFactories, IReadOnlyList<IValueProviderFactory> valueProviderFactories,
int maxAllowedErrorsInModelState) int maxAllowedErrorsInModelState)

View File

@ -112,9 +112,9 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var asyncResultFilter = Mock.Of<IAsyncResultFilter>(); var asyncResultFilter = Mock.Of<IAsyncResultFilter>();
var resourceFilter = Mock.Of<IResourceFilter>(); var resourceFilter = Mock.Of<IResourceFilter>();
var asyncResourceFilter = Mock.Of<IAsyncResourceFilter>(); var asyncResourceFilter = Mock.Of<IAsyncResourceFilter>();
var orderedresourceFilterMock = new Mock<IOrderedResourceFilter>(); var orderedResourceFilterMock = new Mock<IOrderedResourceFilter>();
orderedresourceFilterMock.SetupGet(f => f.Order).Returns(-100); orderedResourceFilterMock.SetupGet(f => f.Order).Returns(-100);
var orderedResourceFilter = orderedresourceFilterMock.Object; var orderedResourceFilter = orderedResourceFilterMock.Object;
var filters = new IFilterMetadata[] var filters = new IFilterMetadata[]
{ {
actionFilter, actionFilter,

View File

@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// Arrange // Arrange
var requestFormLimitsFilter = new RequestFormLimitsFilter(NullLoggerFactory.Instance); var requestFormLimitsFilter = new RequestFormLimitsFilter(NullLoggerFactory.Instance);
requestFormLimitsFilter.FormOptions = new FormOptions(); requestFormLimitsFilter.FormOptions = new FormOptions();
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestFormLimitsFilter }); new IFilterMetadata[] { requestFormLimitsFilter });
// Set to null explicitly as we want to make sure the filter adds one // Set to null explicitly as we want to make sure the filter adds one
authorizationFilterContext.HttpContext.Features.Set<IFormFeature>(null); authorizationFilterContext.HttpContext.Features.Set<IFormFeature>(null);
@ -40,7 +40,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// Arrange // Arrange
var requestFormLimitsFilter = new RequestFormLimitsFilter(NullLoggerFactory.Instance); var requestFormLimitsFilter = new RequestFormLimitsFilter(NullLoggerFactory.Instance);
requestFormLimitsFilter.FormOptions = new FormOptions(); requestFormLimitsFilter.FormOptions = new FormOptions();
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestFormLimitsFilter }); new IFilterMetadata[] { requestFormLimitsFilter });
var oldFormFeature = new FormFeature(authorizationFilterContext.HttpContext.Request); var oldFormFeature = new FormFeature(authorizationFilterContext.HttpContext.Request);
// Set to null explicitly as we want to make sure the filter adds one // Set to null explicitly as we want to make sure the filter adds one
@ -63,7 +63,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory); var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory);
requestFormLimitsFilter.FormOptions = new FormOptions(); requestFormLimitsFilter.FormOptions = new FormOptions();
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestFormLimitsFilter }); new IFilterMetadata[] { requestFormLimitsFilter });
authorizationFilterContext.HttpContext.Request.Form = new FormCollection(null); authorizationFilterContext.HttpContext.Request.Form = new FormCollection(null);
@ -87,7 +87,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory); var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory);
requestFormLimitsFilter.FormOptions = new FormOptions(); requestFormLimitsFilter.FormOptions = new FormOptions();
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestFormLimitsFilter }); new IFilterMetadata[] { requestFormLimitsFilter });
// Set to null explicitly as we want to make sure the filter adds one // Set to null explicitly as we want to make sure the filter adds one
authorizationFilterContext.HttpContext.Features.Set<IFormFeature>(null); authorizationFilterContext.HttpContext.Features.Set<IFormFeature>(null);
@ -112,7 +112,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory); var requestFormLimitsFilter = new RequestFormLimitsFilter(loggerFactory);
requestFormLimitsFilter.FormOptions = new FormOptions(); requestFormLimitsFilter.FormOptions = new FormOptions();
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestFormLimitsFilter }); new IFilterMetadata[] { requestFormLimitsFilter });
// Set to null explicitly as we want to make sure the filter adds one // Set to null explicitly as we want to make sure the filter adds one
authorizationFilterContext.HttpContext.Features.Set<IFormFeature>( authorizationFilterContext.HttpContext.Features.Set<IFormFeature>(
@ -129,7 +129,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
write.State.ToString()); write.State.ToString());
} }
private static AuthorizationFilterContext CreateauthorizationFilterContext(IFilterMetadata[] filters) private static AuthorizationFilterContext CreateAuthorizationFilterContext(IFilterMetadata[] filters)
{ {
return new AuthorizationFilterContext(CreateActionContext(), filters); return new AuthorizationFilterContext(CreateActionContext(), filters);
} }

View File

@ -20,7 +20,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
// Arrange // Arrange
var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(NullLoggerFactory.Instance); var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(NullLoggerFactory.Instance);
requestSizeLimitResourceFilter.Bytes = 12345; requestSizeLimitResourceFilter.Bytes = 12345;
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize); authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize);
@ -40,7 +40,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
requestSizeLimitResourceFilter.Bytes = 12345; requestSizeLimitResourceFilter.Bytes = 12345;
var requestSizeLimitResourceFilterFinal = new RequestSizeLimitFilter(NullLoggerFactory.Instance); var requestSizeLimitResourceFilterFinal = new RequestSizeLimitFilter(NullLoggerFactory.Instance);
requestSizeLimitResourceFilterFinal.Bytes = 0; requestSizeLimitResourceFilterFinal.Bytes = 0;
var authorizationFilterContext = CreateauthorizationFilterContext( var authorizationFilterContext = CreateAuthorizationFilterContext(
new IFilterMetadata[] { requestSizeLimitResourceFilter, requestSizeLimitResourceFilterFinal }); new IFilterMetadata[] { requestSizeLimitResourceFilter, requestSizeLimitResourceFilterFinal });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
@ -64,7 +64,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory); var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory);
requestSizeLimitResourceFilter.Bytes = 12345; requestSizeLimitResourceFilter.Bytes = 12345;
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter });
// Act // Act
requestSizeLimitResourceFilter.OnAuthorization(authorizationFilterContext); requestSizeLimitResourceFilter.OnAuthorization(authorizationFilterContext);
@ -84,7 +84,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory); var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory);
requestSizeLimitResourceFilter.Bytes = 12345; requestSizeLimitResourceFilter.Bytes = 12345;
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
httpMaxRequestBodySize.IsReadOnly = true; httpMaxRequestBodySize.IsReadOnly = true;
@ -107,7 +107,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory); var requestSizeLimitResourceFilter = new RequestSizeLimitFilter(loggerFactory);
requestSizeLimitResourceFilter.Bytes = 12345; requestSizeLimitResourceFilter.Bytes = 12345;
var authorizationFilterContext = CreateauthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter }); var authorizationFilterContext = CreateAuthorizationFilterContext(new IFilterMetadata[] { requestSizeLimitResourceFilter });
var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature(); var httpMaxRequestBodySize = new TestHttpMaxRequestBodySizeFeature();
authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize); authorizationFilterContext.HttpContext.Features.Set<IHttpMaxRequestBodySizeFeature>(httpMaxRequestBodySize);
@ -120,7 +120,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
Assert.Equal($"The maximum request body size has been set to 12345.", write.State.ToString()); Assert.Equal($"The maximum request body size has been set to 12345.", write.State.ToString());
} }
private static AuthorizationFilterContext CreateauthorizationFilterContext(IFilterMetadata[] filters) private static AuthorizationFilterContext CreateAuthorizationFilterContext(IFilterMetadata[] filters)
{ {
return new AuthorizationFilterContext(CreateActionContext(), filters); return new AuthorizationFilterContext(CreateActionContext(), filters);
} }

View File

@ -467,7 +467,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
[Theory] [Theory]
[MemberData(nameof(DerivedInputFormattersThrowingNonInputFormatterException))] [MemberData(nameof(DerivedInputFormattersThrowingNonInputFormatterException))]
public async Task BindModel_DerivedXmlInputFormatters_ThrowingNonInputFormatingException_AddsErrorToModelState( public async Task BindModel_DerivedXmlInputFormatters_ThrowingNonInputFormattingException_AddsErrorToModelState(
IInputFormatter formatter, IInputFormatter formatter,
string contentType, string contentType,
InputFormatterExceptionPolicy inputFormatterExceptionPolicy) InputFormatterExceptionPolicy inputFormatterExceptionPolicy)

View File

@ -42,14 +42,14 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
[InlineData(false, typeof(IntEnum))] [InlineData(false, typeof(IntEnum))]
[InlineData(false, typeof(FlagsEnum))] [InlineData(false, typeof(FlagsEnum))]
public async Task BindModel_AddsErrorToModelState_ForEmptyValue_AndNonNullableEnumTypes( public async Task BindModel_AddsErrorToModelState_ForEmptyValue_AndNonNullableEnumTypes(
bool suprressBindingUndefinedValueToEnumType, bool suppressBindingUndefinedValueToEnumType,
Type modelType) Type modelType)
{ {
// Arrange // Arrange
var message = "The value '' is invalid."; var message = "The value '' is invalid.";
var binderInfo = GetBinderAndContext( var binderInfo = GetBinderAndContext(
modelType, modelType,
suprressBindingUndefinedValueToEnumType, suppressBindingUndefinedValueToEnumType,
valueProviderValue: ""); valueProviderValue: "");
var bindingContext = binderInfo.Item1; var bindingContext = binderInfo.Item1;
var binder = binderInfo.Item2; var binder = binderInfo.Item2;

View File

@ -12,7 +12,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
{ {
[Theory] [Theory]
[InlineData(typeof(FormCollection))] [InlineData(typeof(FormCollection))]
[InlineData(typeof(DerviedFormCollection))] [InlineData(typeof(DerivedFormCollection))]
public void Create_ThrowsException_ForFormCollectionModelType(Type modelType) public void Create_ThrowsException_ForFormCollectionModelType(Type modelType)
{ {
// Arrange // Arrange
@ -62,9 +62,9 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
{ {
} }
private class DerviedFormCollection : FormCollection private class DerivedFormCollection : FormCollection
{ {
public DerviedFormCollection() : base(fields: null, files: null) { } public DerivedFormCollection() : base(fields: null, files: null) { }
} }
} }
} }

View File

@ -607,7 +607,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
} }
[Fact] [Fact]
public async Task TryUpdataModel_ModelTypeDifferentFromModel_Throws() public async Task TryUpdateModel_ModelTypeDifferentFromModel_Throws()
{ {
// Arrange // Arrange
var metadataProvider = new EmptyModelMetadataProvider(); var metadataProvider = new EmptyModelMetadataProvider();

View File

@ -21,10 +21,10 @@ namespace Microsoft.AspNetCore.Mvc
// Act & Assert // Act & Assert
foreach (var property in formOptionsProperties) foreach (var property in formOptionsProperties)
{ {
var formLimiAttributeProperty = formLimitsAttributeProperties var formLimitAttributeProperty = formLimitsAttributeProperties
.Where(pi => property.Name == pi.Name && pi.PropertyType == property.PropertyType) .Where(pi => property.Name == pi.Name && pi.PropertyType == property.PropertyType)
.SingleOrDefault(); .SingleOrDefault();
Assert.NotNull(formLimiAttributeProperty); Assert.NotNull(formLimitAttributeProperty);
} }
} }

View File

@ -196,7 +196,7 @@ namespace Microsoft.AspNetCore.Mvc
[InlineData(null, false)] [InlineData(null, false)]
[InlineData(true, false)] [InlineData(true, false)]
[InlineData(false, true)] [InlineData(false, true)]
public void OnAuthorization_RedirectsToHttpsEndpoint_WithSpecifiedStatusCodeAndrequireHttpsPermanentOption(bool? permanent, bool requireHttpsPermanent) public void OnAuthorization_RedirectsToHttpsEndpoint_WithSpecifiedStatusCodeAndRequireHttpsPermanentOption(bool? permanent, bool requireHttpsPermanent)
{ {
var requestContext = new DefaultHttpContext(); var requestContext = new DefaultHttpContext();
requestContext.RequestServices = CreateServices(null, requireHttpsPermanent); requestContext.RequestServices = CreateServices(null, requireHttpsPermanent);

View File

@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Mvc.Routing
"testController", "testController",
"testAction"); "testAction");
actionDescriptor.RouteValues.Add("randomKey", "testRandom"); actionDescriptor.RouteValues.Add("randomKey", "testRandom");
var descriptorCollectionProvider = CreateActionDesciprtorCollectionProvider(actionDescriptor); var descriptorCollectionProvider = CreateActionDescriptorCollectionProvider(actionDescriptor);
var services = new ServiceCollection(); var services = new ServiceCollection();
services.AddRouting(); services.AddRouting();
@ -214,7 +214,7 @@ namespace Microsoft.AspNetCore.Mvc.Routing
"testAction"); "testAction");
actionDescriptor.RouteValues.Add("randomKey", "testRandom"); actionDescriptor.RouteValues.Add("randomKey", "testRandom");
var provider = CreateActionDesciprtorCollectionProvider(actionDescriptor); var provider = CreateActionDescriptorCollectionProvider(actionDescriptor);
var constraint = new KnownRouteValueConstraint(provider); var constraint = new KnownRouteValueConstraint(provider);
@ -235,7 +235,7 @@ namespace Microsoft.AspNetCore.Mvc.Routing
private static HttpContext GetHttpContext(ActionDescriptor actionDescriptor, bool setupRequestServices = true) private static HttpContext GetHttpContext(ActionDescriptor actionDescriptor, bool setupRequestServices = true)
{ {
var descriptorCollectionProvider = CreateActionDesciprtorCollectionProvider(actionDescriptor); var descriptorCollectionProvider = CreateActionDescriptorCollectionProvider(actionDescriptor);
var context = new Mock<HttpContext>(); var context = new Mock<HttpContext>();
if (setupRequestServices) if (setupRequestServices)
@ -247,7 +247,7 @@ namespace Microsoft.AspNetCore.Mvc.Routing
return context.Object; return context.Object;
} }
private static IActionDescriptorCollectionProvider CreateActionDesciprtorCollectionProvider(ActionDescriptor actionDescriptor) private static IActionDescriptorCollectionProvider CreateActionDescriptorCollectionProvider(ActionDescriptor actionDescriptor)
{ {
var actionProvider = new Mock<IActionDescriptorProvider>(MockBehavior.Strict); var actionProvider = new Mock<IActionDescriptorProvider>(MockBehavior.Strict);

View File

@ -340,7 +340,7 @@ namespace Microsoft.AspNetCore.Mvc.Core.Test.Routing
} }
[Fact] [Fact]
public void Page_UsesValueFromRouteValueIfPageHandlerIsNotExplicitySpecified() public void Page_UsesValueFromRouteValueIfPageHandlerIsNotExplicitlySpecified()
{ {
// Arrange // Arrange
UrlRouteContext actual = null; UrlRouteContext actual = null;

View File

@ -1555,7 +1555,7 @@ namespace Microsoft.AspNetCore.Mvc
var invoker = CreateInvoker( var invoker = CreateInvoker(
new IFilterMetadata[] new IFilterMetadata[]
{ {
resourceFilter1.Object, // This filter should see the result retured from resourceFilter2 resourceFilter1.Object, // This filter should see the result returned from resourceFilter2
resourceFilter2.Object, // This filter will short circuit resourceFilter2.Object, // This filter will short circuit
resourceFilter3.Object, // This shouldn't run - it will throw if it does resourceFilter3.Object, // This shouldn't run - it will throw if it does
exceptionFilter.Object, // This shouldn't run - it will throw if it does exceptionFilter.Object, // This shouldn't run - it will throw if it does
@ -1603,7 +1603,7 @@ namespace Microsoft.AspNetCore.Mvc
var invoker = CreateInvoker( var invoker = CreateInvoker(
new IFilterMetadata[] new IFilterMetadata[]
{ {
resourceFilter1.Object, // This filter should see the result retured from resourceFilter2 resourceFilter1.Object, // This filter should see the result returned from resourceFilter2
resourceFilter2.Object, // This filter will short circuit resourceFilter2.Object, // This filter will short circuit
resourceFilter3.Object, // This shouldn't run - it will throw if it does resourceFilter3.Object, // This shouldn't run - it will throw if it does
exceptionFilter.Object, // This shouldn't run - it will throw if it does exceptionFilter.Object, // This shouldn't run - it will throw if it does
@ -1653,7 +1653,7 @@ namespace Microsoft.AspNetCore.Mvc
var invoker = CreateInvoker( var invoker = CreateInvoker(
new IFilterMetadata[] new IFilterMetadata[]
{ {
resourceFilter1.Object, // This filter should see the result retured from resourceFilter2 resourceFilter1.Object, // This filter should see the result returned from resourceFilter2
resourceFilter2.Object, resourceFilter2.Object,
resourceFilter3.Object, // This shouldn't run - it will throw if it does resourceFilter3.Object, // This shouldn't run - it will throw if it does
resultFilter.Object // This shouldn't run - it will throw if it does resultFilter.Object // This shouldn't run - it will throw if it does

View File

@ -181,7 +181,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
{ {
private List<Action<BindingMetadata>> _bindingActions = new List<Action<BindingMetadata>>(); private List<Action<BindingMetadata>> _bindingActions = new List<Action<BindingMetadata>>();
private List<Action<DisplayMetadata>> _displayActions = new List<Action<DisplayMetadata>>(); private List<Action<DisplayMetadata>> _displayActions = new List<Action<DisplayMetadata>>();
private List<Action<ValidationMetadata>> _valiationActions = new List<Action<ValidationMetadata>>(); private List<Action<ValidationMetadata>> _validationActions = new List<Action<ValidationMetadata>>();
private readonly ModelMetadataIdentity _key; private readonly ModelMetadataIdentity _key;
@ -216,7 +216,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
{ {
if (_key.Equals(context.Key)) if (_key.Equals(context.Key))
{ {
foreach (var action in _valiationActions) foreach (var action in _validationActions)
{ {
action(context.ValidationMetadata); action(context.ValidationMetadata);
} }
@ -237,7 +237,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
public IMetadataBuilder ValidationDetails(Action<ValidationMetadata> action) public IMetadataBuilder ValidationDetails(Action<ValidationMetadata> action)
{ {
_valiationActions.Add(action); _validationActions.Add(action);
return this; return this;
} }
} }

View File

@ -17,8 +17,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Json
public void OnProvidersExecuting_FindsJsonPatchDocuments_ProvidesOperationsArray() public void OnProvidersExecuting_FindsJsonPatchDocuments_ProvidesOperationsArray()
{ {
// Arrange // Arrange
var metadataprovider = new TestModelMetadataProvider(); var metadataProvider = new TestModelMetadataProvider();
var provider = new JsonPatchOperationsArrayProvider(metadataprovider); var provider = new JsonPatchOperationsArrayProvider(metadataProvider);
var jsonPatchParameterDescription = new ApiParameterDescription var jsonPatchParameterDescription = new ApiParameterDescription
{ {
Type = typeof(JsonPatchDocument) Type = typeof(JsonPatchDocument)

View File

@ -78,7 +78,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml.Internal
[InlineData(typeof(List<Person>))] [InlineData(typeof(List<Person>))]
[InlineData(typeof(List<SerializableError>))] [InlineData(typeof(List<SerializableError>))]
[InlineData(typeof(PersonList))] [InlineData(typeof(PersonList))]
public void ThrowsArugmentExceptionFor_ConcreteEnumerableOfT(Type declaredType) public void ThrowsArgumentExceptionFor_ConcreteEnumerableOfT(Type declaredType)
{ {
// Arrange // Arrange
var expectedMessage = "The type must be an interface and must be or derive from 'IEnumerable`1'."; var expectedMessage = "The type must be an interface and must be or derive from 'IEnumerable`1'.";

View File

@ -13,10 +13,10 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml.Internal
public void Creates_WrapperProvider_ForSerializableErrorType(bool isSerialization) public void Creates_WrapperProvider_ForSerializableErrorType(bool isSerialization)
{ {
// Arrange // Arrange
var serializableErroWrapperProviderFactory = new SerializableErrorWrapperProviderFactory(); var serializableErrorWrapperProviderFactory = new SerializableErrorWrapperProviderFactory();
// Act // Act
var wrapperProvider = serializableErroWrapperProviderFactory.GetProvider( var wrapperProvider = serializableErrorWrapperProviderFactory.GetProvider(
new WrapperProviderContext(typeof(SerializableError), isSerialization)); new WrapperProviderContext(typeof(SerializableError), isSerialization));
// Assert // Assert
@ -28,10 +28,10 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml.Internal
public void ReturnsNullFor_NonSerializableErrorTypes() public void ReturnsNullFor_NonSerializableErrorTypes()
{ {
// Arrange // Arrange
var serializableErroWrapperProviderFactory = new SerializableErrorWrapperProviderFactory(); var serializableErrorWrapperProviderFactory = new SerializableErrorWrapperProviderFactory();
// Act // Act
var wrapperProvider = serializableErroWrapperProviderFactory.GetProvider( var wrapperProvider = serializableErrorWrapperProviderFactory.GetProvider(
new WrapperProviderContext(typeof(Person), isSerialization: true)); new WrapperProviderContext(typeof(Person), isSerialization: true));
// Assert // Assert

View File

@ -110,7 +110,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[Fact] [Fact]
public void HasProperSuppportedMediaTypes() public void HasProperSupportedMediaTypes()
{ {
// Arrange & Act // Arrange & Act
var formatter = new XmlDataContractSerializerInputFormatter(new MvcOptions()); var formatter = new XmlDataContractSerializerInputFormatter(new MvcOptions());
@ -123,7 +123,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[Fact] [Fact]
public void HasProperSuppportedEncodings() public void HasProperSupportedEncodings()
{ {
// Arrange & Act // Arrange & Act
var formatter = new XmlDataContractSerializerInputFormatter(new MvcOptions()); var formatter = new XmlDataContractSerializerInputFormatter(new MvcOptions());

View File

@ -349,7 +349,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[Fact] [Fact]
public void HasProperSuppportedMediaTypes() public void HasProperSupportedMediaTypes()
{ {
// Arrange & Act // Arrange & Act
var formatter = new XmlSerializerInputFormatter(new MvcOptions()); var formatter = new XmlSerializerInputFormatter(new MvcOptions());
@ -362,7 +362,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[Fact] [Fact]
public void HasProperSuppportedEncodings() public void HasProperSupportedEncodings()
{ {
// Arrange & Act // Arrange & Act
var formatter = new XmlSerializerInputFormatter(new MvcOptions()); var formatter = new XmlSerializerInputFormatter(new MvcOptions());

View File

@ -1359,7 +1359,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[Fact] [Fact]
public async Task ApiConvention_ForActionWtihApiConventionMethod() public async Task ApiConvention_ForActionWithApiConventionMethod()
{ {
// Arrange // Arrange
var expectedMediaTypes = new[] { "application/json", "application/xml", "text/json", "text/xml" }; var expectedMediaTypes = new[] { "application/json", "application/xml", "text/json", "text/xml" };

View File

@ -85,7 +85,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
[Theory] [Theory]
[InlineData("application/json")] [InlineData("application/json")]
[InlineData("text/json")] [InlineData("text/json")]
public async Task ActionLevelAttribute_OveridesClassLevel(string requestContentType) public async Task ActionLevelAttribute_OverridesClassLevel(string requestContentType)
{ {
// Arrange // Arrange
var input = "{SampleString:\"" + requestContentType + "\"}"; var input = "{SampleString:\"" + requestContentType + "\"}";

View File

@ -24,7 +24,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
private const string EnumUrl = "http://localhost/Enum/Enum"; private const string EnumUrl = "http://localhost/Enum/Enum";
[Fact] [Fact]
public async Task DataAnnotationLocalizionOfEnums_FromDataAnnotationLocalizerProvider() public async Task DataAnnotationLocalizationOfEnums_FromDataAnnotationLocalizerProvider()
{ {
// Arrange & Act // Arrange & Act
var response = await Client.GetAsync(EnumUrl); var response = await Client.GetAsync(EnumUrl);

View File

@ -404,7 +404,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(expected2, response2.Trim()); Assert.Equal(expected2, response2.Trim());
// Act - 3 // Act - 3
// Resend the cookiesless request and cached result from the first response. // Resend the cookieless request and cached result from the first response.
var response3 = await Client.GetStringAsync("/catalog/cart?correlationid=3"); var response3 = await Client.GetStringAsync("/catalog/cart?correlationid=3");
// Assert - 3 // Assert - 3

View File

@ -1422,7 +1422,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore.InjectedPa
} }
[Fact] [Fact]
public async Task ViewDataAvaialableInPageFilter_AfterHandlerMethod_ReturnsPageResult() public async Task ViewDataAwaitableInPageFilter_AfterHandlerMethod_ReturnsPageResult()
{ {
// Act // Act
var content = await Client.GetStringAsync("http://localhost/Pages/ViewDataAvailableAfterHandlerExecuted"); var content = await Client.GetStringAsync("http://localhost/Pages/ViewDataAvailableAfterHandlerExecuted");

View File

@ -384,7 +384,7 @@ Hello from /Pages/Shared/";
} }
[Fact] [Fact]
public async Task AllowAnonymouseToPageConvention_CanBeAppliedToAreaPages() public async Task AllowAnonymousToPageConvention_CanBeAppliedToAreaPages()
{ {
// Act // Act
var response = await Client.GetStringAsync("/Accounts/RequiresAuth/AllowAnonymous"); var response = await Client.GetStringAsync("/Accounts/RequiresAuth/AllowAnonymous");
@ -395,7 +395,7 @@ Hello from /Pages/Shared/";
// These test is important as it covers a feature that allows razor pages to use a different // These test is important as it covers a feature that allows razor pages to use a different
// model at runtime that wasn't known at compile time. Like a non-generic model used at compile // model at runtime that wasn't known at compile time. Like a non-generic model used at compile
// time and overrided at runtime with a closed-generic model that performs the actual implementation. // time and overriden at runtime with a closed-generic model that performs the actual implementation.
// An example of this is how the Identity UI library defines a base page model in their views, // An example of this is how the Identity UI library defines a base page model in their views,
// like how the Register.cshtml view defines its model as RegisterModel and then, at runtime it replaces // like how the Register.cshtml view defines its model as RegisterModel and then, at runtime it replaces
// that model with RegisterModel<TUser> where TUser is the type of the user used to configure identity. // that model with RegisterModel<TUser> where TUser is the type of the user used to configure identity.
@ -506,7 +506,7 @@ Hello from /Pages/Shared/";
} }
[Fact] [Fact]
public async Task ViewDataAttributes_SetInPageModel_AreTransferedToLayout() public async Task ViewDataAttributes_SetInPageModel_AreTransferredToLayout()
{ {
// Arrange // Arrange
var document = await Client.GetHtmlDocumentAsync("/ViewData/ViewDataInPage"); var document = await Client.GetHtmlDocumentAsync("/ViewData/ViewDataInPage");
@ -526,7 +526,7 @@ Hello from /Pages/Shared/";
} }
[Fact] [Fact]
public async Task ViewDataAttributes_SetInPageWithoutModel_AreTransferedToLayout() public async Task ViewDataAttributes_SetInPageWithoutModel_AreTransferredToLayout()
{ {
// Arrange // Arrange
var document = await Client.GetHtmlDocumentAsync("/ViewData/ViewDataInPageWithoutModel"); var document = await Client.GetHtmlDocumentAsync("/ViewData/ViewDataInPageWithoutModel");

View File

@ -921,7 +921,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[Fact] [Fact]
public virtual async Task AttributeRoutedAction_LinkWithName_WithNameOverrridenFromController() public virtual async Task AttributeRoutedAction_LinkWithName_WithNameOverridenFromController()
{ {
// Arrange & Act // Arrange & Act
var response = await Client.DeleteAsync("http://localhost/api/Company/5"); var response = await Client.DeleteAsync("http://localhost/api/Company/5");

View File

@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
public HttpClient Client { get; } public HttpClient Client { get; }
[Fact] [Fact]
public async Task JsonSerializeFormated() public async Task JsonSerializeFormatted()
{ {
// Arrange // Arrange
var expected = "{" + Environment.NewLine var expected = "{" + Environment.NewLine

View File

@ -89,7 +89,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[Fact] [Fact]
public async Task ReregisteringAntiforgeryTokenInsideFormTagHelper_DoesNotAddDuplicateAntiforgeryTokenFields() public async Task ReRegisteringAntiforgeryTokenInsideFormTagHelper_DoesNotAddDuplicateAntiforgeryTokenFields()
{ {
// Arrange // Arrange
var expectedMediaType = MediaTypeHeaderValue.Parse("text/html; charset=utf-8"); var expectedMediaType = MediaTypeHeaderValue.Parse("text/html; charset=utf-8");

View File

@ -104,7 +104,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[Fact] [Fact]
public async Task ActionThrowsHttpResponseException_EnsureGlobalHttpresponseExceptionActionFilter_IsInvoked() public async Task ActionThrowsHttpResponseException_EnsureGlobalHttpResponseExceptionActionFilter_IsInvoked()
{ {
// Arrange & Act // Arrange & Act
var response = await Client.GetAsync( var response = await Client.GetAsync(

View File

@ -78,7 +78,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
// Verifies that the model state has errors related to body model validation. // Verifies that the model state has errors related to body model validation.
[Fact] [Fact]
public async Task DataMissingForRefereneceTypeProperties_AndModelIsBound_AndHasMixedValidationErrors() public async Task DataMissingForReferenceTypeProperties_AndModelIsBound_AndHasMixedValidationErrors()
{ {
// Arrange // Arrange
var input = "<Store xmlns=\"http://schemas.datacontract.org/2004/07/XmlFormattersWebSite\"" + var input = "<Store xmlns=\"http://schemas.datacontract.org/2004/07/XmlFormattersWebSite\"" +

View File

@ -2403,7 +2403,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task MutableObjectModelBinder_WithRequiredProperty_NoData_CustomPrefix_GetsErros() public async Task MutableObjectModelBinder_WithRequiredProperty_NoData_CustomPrefix_GetsErrors()
{ {
// Arrange // Arrange
var parameter = new ParameterDescriptor() var parameter = new ParameterDescriptor()
@ -2507,7 +2507,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task MutableObjectModelBinder_WithRequiredCollectionProperty_NoData_GetsErros() public async Task MutableObjectModelBinder_WithRequiredCollectionProperty_NoData_GetsErrors()
{ {
// Arrange // Arrange
var parameter = new ParameterDescriptor() var parameter = new ParameterDescriptor()
@ -2555,7 +2555,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task MutableObjectModelBinder_WithRequiredCollectionProperty_NoData_CustomPrefix_GetsErros() public async Task MutableObjectModelBinder_WithRequiredCollectionProperty_NoData_CustomPrefix_GetsErrors()
{ {
// Arrange // Arrange
var parameter = new ParameterDescriptor() var parameter = new ParameterDescriptor()

View File

@ -115,7 +115,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
var categoryRequired = ValidationAttributeUtil.GetRequiredErrorMessage("Category"); var categoryRequired = ValidationAttributeUtil.GetRequiredErrorMessage("Category");
var priceRange = ValidationAttributeUtil.GetRangeErrorMessage(20, 100, "Price"); var priceRange = ValidationAttributeUtil.GetRangeErrorMessage(20, 100, "Price");
var contactUsMax = ValidationAttributeUtil.GetStringLengthErrorMessage(null, 20, "Contact Us"); var contactUsMax = ValidationAttributeUtil.GetStringLengthErrorMessage(null, 20, "Contact Us");
var contactusRegEx = ValidationAttributeUtil.GetRegExErrorMessage("^[0-9]*$", "Contact Us"); var contactUsRegEx = ValidationAttributeUtil.GetRegExErrorMessage("^[0-9]*$", "Contact Us");
// Act // Act
var result = controller.TryValidateModel(model); var result = controller.TryValidateModel(model);
@ -128,11 +128,11 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
Assert.Equal("CompanyName cannot be null or empty.", modelStateErrors["[0].CompanyName"]); Assert.Equal("CompanyName cannot be null or empty.", modelStateErrors["[0].CompanyName"]);
Assert.Equal(priceRange, modelStateErrors["[0].Price"]); Assert.Equal(priceRange, modelStateErrors["[0].Price"]);
Assert.Equal(categoryRequired, modelStateErrors["[0].Category"]); Assert.Equal(categoryRequired, modelStateErrors["[0].Category"]);
AssertErrorEquals(contactUsMax + contactusRegEx, modelStateErrors["[0].Contact"]); AssertErrorEquals(contactUsMax + contactUsRegEx, modelStateErrors["[0].Contact"]);
Assert.Equal("CompanyName cannot be null or empty.", modelStateErrors["[1].CompanyName"]); Assert.Equal("CompanyName cannot be null or empty.", modelStateErrors["[1].CompanyName"]);
Assert.Equal(priceRange, modelStateErrors["[1].Price"]); Assert.Equal(priceRange, modelStateErrors["[1].Price"]);
Assert.Equal(categoryRequired, modelStateErrors["[1].Category"]); Assert.Equal(categoryRequired, modelStateErrors["[1].Category"]);
AssertErrorEquals(contactUsMax + contactusRegEx, modelStateErrors["[1].Contact"]); AssertErrorEquals(contactUsMax + contactUsRegEx, modelStateErrors["[1].Contact"]);
} }
[Fact] [Fact]

View File

@ -1023,7 +1023,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task Validation_StringLengthAttribute_OnProperyOfCollectionElement_Valid() public async Task Validation_StringLengthAttribute_OnPropertyOfCollectionElement_Valid()
{ {
// Arrange // Arrange
var parameterBinder = ModelBindingTestHelper.GetParameterBinder(); var parameterBinder = ModelBindingTestHelper.GetParameterBinder();
@ -1060,7 +1060,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task Validation_StringLengthAttribute_OnProperyOfCollectionElement_Invalid() public async Task Validation_StringLengthAttribute_OnPropertyOfCollectionElement_Invalid()
{ {
// Arrange // Arrange
var parameterBinder = ModelBindingTestHelper.GetParameterBinder(); var parameterBinder = ModelBindingTestHelper.GetParameterBinder();
@ -1100,7 +1100,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
} }
[Fact] [Fact]
public async Task Validation_StringLengthAttribute_OnProperyOfCollectionElement_NoData() public async Task Validation_StringLengthAttribute_OnPropertyOfCollectionElement_NoData()
{ {
// Arrange // Arrange
var parameterBinder = ModelBindingTestHelper.GetParameterBinder(); var parameterBinder = ModelBindingTestHelper.GetParameterBinder();
@ -1701,7 +1701,7 @@ namespace Microsoft.AspNetCore.Mvc.IntegrationTests
// basically result in clearing out all model errors, which is BAD. // basically result in clearing out all model errors, which is BAD.
// //
// The fix is to treat non-user-input as have a key of null, which means that the MSD // The fix is to treat non-user-input as have a key of null, which means that the MSD
// isn't even examined when it comes to supressing validation. // isn't even examined when it comes to suppressing validation.
[Fact] [Fact]
public async Task CancellationToken_WithEmptyPrefix_DoesNotSuppressUnrelatedErrors() public async Task CancellationToken_WithEmptyPrefix_DoesNotSuppressUnrelatedErrors()
{ {

View File

@ -72,7 +72,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal
[InlineData(@"Areas\Finances\Views\Home\Index.cshtml")] [InlineData(@"Areas\Finances\Views\Home\Index.cshtml")]
[InlineData(@"\Areas\Finances\Views\Home\Index.cshtml")] [InlineData(@"\Areas\Finances\Views\Home\Index.cshtml")]
[InlineData(@"\Areas\Finances\Views/Home\Index.cshtml")] [InlineData(@"\Areas\Finances\Views/Home\Index.cshtml")]
public async Task CompileAsync_NormalizesPathSepartorForPaths(string relativePath) public async Task CompileAsync_NormalizesPathSeparatorForPaths(string relativePath)
{ {
// Arrange // Arrange
var viewPath = "/Areas/Finances/Views/Home/Index.cshtml"; var viewPath = "/Areas/Finances/Views/Home/Index.cshtml";
@ -731,7 +731,7 @@ this should fail";
} }
[Fact] [Fact]
public void Compile_InvokessCallback() public void Compile_InvokesCallback()
{ {
// Arrange // Arrange
var content = "public class MyTestType {}"; var content = "public class MyTestType {}";

View File

@ -101,7 +101,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Same(DiagnosticSource, instance.DiagnosticSource); Assert.Same(DiagnosticSource, instance.DiagnosticSource);
Assert.Same(HtmlEncoder, instance.HtmlEncoder); Assert.Same(HtmlEncoder, instance.HtmlEncoder);
// When we don't have a model property, the activator will just leave viewdata alone. // When we don't have a model property, the activator will just leave ViewData alone.
Assert.NotNull(viewContext.ViewData); Assert.NotNull(viewContext.ViewData);
} }

View File

@ -303,7 +303,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(1, bufferScope.CreatedBuffers.Count); Assert.Equal(1, bufferScope.CreatedBuffers.Count);
Assert.Equal(0, bufferScope.ReturnedBuffers.Count); Assert.Equal(0, bufferScope.ReturnedBuffers.Count);
v.Write("Level:1-A"); // Creates a new buffer for the taghelper. v.Write("Level:1-A"); // Creates a new buffer for the TagHelper.
Assert.Equal(2, bufferScope.CreatedBuffers.Count); Assert.Equal(2, bufferScope.CreatedBuffers.Count);
Assert.Equal(0, bufferScope.ReturnedBuffers.Count); Assert.Equal(0, bufferScope.ReturnedBuffers.Count);
@ -318,7 +318,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(2, bufferScope.CreatedBuffers.Count); Assert.Equal(2, bufferScope.CreatedBuffers.Count);
Assert.Equal(0, bufferScope.ReturnedBuffers.Count); Assert.Equal(0, bufferScope.ReturnedBuffers.Count);
v.Write(outputLevel1); // Writing the taghelper to output returns a buffer. v.Write(outputLevel1); // Writing the TagHelper to output returns a buffer.
Assert.Equal(2, bufferScope.CreatedBuffers.Count); Assert.Equal(2, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
} }
@ -335,7 +335,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(2, bufferScope.CreatedBuffers.Count); Assert.Equal(2, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
v.Write("Level:1-B"); // Creates a new buffer for the taghelper. v.Write("Level:1-B"); // Creates a new buffer for the TagHelper.
Assert.Equal(3, bufferScope.CreatedBuffers.Count); Assert.Equal(3, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
@ -351,7 +351,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(3, bufferScope.CreatedBuffers.Count); Assert.Equal(3, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
v.Write("Level:2"); // Creates a new buffer for the taghelper. v.Write("Level:2"); // Creates a new buffer for the TagHelper.
Assert.Equal(4, bufferScope.CreatedBuffers.Count); Assert.Equal(4, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
@ -366,7 +366,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(4, bufferScope.CreatedBuffers.Count); Assert.Equal(4, bufferScope.CreatedBuffers.Count);
Assert.Equal(1, bufferScope.ReturnedBuffers.Count); Assert.Equal(1, bufferScope.ReturnedBuffers.Count);
v.Write(outputLevel2); // Writing the taghelper to output returns a buffer. v.Write(outputLevel2); // Writing the TagHelper to output returns a buffer.
Assert.Equal(4, bufferScope.CreatedBuffers.Count); Assert.Equal(4, bufferScope.CreatedBuffers.Count);
Assert.Equal(2, bufferScope.ReturnedBuffers.Count); Assert.Equal(2, bufferScope.ReturnedBuffers.Count);
} }
@ -382,7 +382,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
Assert.Equal(4, bufferScope.CreatedBuffers.Count); Assert.Equal(4, bufferScope.CreatedBuffers.Count);
Assert.Equal(2, bufferScope.ReturnedBuffers.Count); Assert.Equal(2, bufferScope.ReturnedBuffers.Count);
v.Write(outputLevel1); // Writing the taghelper to output returns a buffer. v.Write(outputLevel1); // Writing the TagHelper to output returns a buffer.
Assert.Equal(4, bufferScope.CreatedBuffers.Count); Assert.Equal(4, bufferScope.CreatedBuffers.Count);
Assert.Equal(3, bufferScope.ReturnedBuffers.Count); Assert.Equal(3, bufferScope.ReturnedBuffers.Count);
} }

View File

@ -749,7 +749,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor
} }
[Fact] [Fact]
public void FindView_NoramlizesPaths_ReturnedByViewLocationExpanders() public void FindView_NormalizesPaths_ReturnedByViewLocationExpanders()
{ {
// Arrange // Arrange
var pageFactory = new Mock<IRazorPageFactoryProvider>(); var pageFactory = new Mock<IRazorPageFactoryProvider>();
@ -2040,8 +2040,8 @@ namespace Microsoft.AspNetCore.Mvc.Razor
routeData.Values.Add(kvp.Key, kvp.Value); routeData.Values.Add(kvp.Key, kvp.Value);
} }
var actionDesciptor = new ActionDescriptor(); var actionDescriptor = new ActionDescriptor();
return new ActionContext(httpContext, routeData, actionDesciptor); return new ActionContext(httpContext, routeData, actionDescriptor);
} }
private static ActionContext GetActionContextWithActionDescriptor( private static ActionContext GetActionContextWithActionDescriptor(

Some files were not shown because too many files have changed in this diff Show More