From d226b20756b18b28b73534d9d6c4bf585f0fe840 Mon Sep 17 00:00:00 2001 From: Pawel Kadluczka Date: Wed, 13 Sep 2017 09:46:17 -0700 Subject: [PATCH] Rename With/GetTransportType to With/GetTransport --- .../HubConnectionBuilderHttpExtensions.cs | 6 +++--- .../HubConnectionTests.cs | 2 +- .../HubConnectionBuilderExtensionsTests.cs | 6 +++--- test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Microsoft.AspNetCore.SignalR.Client/HubConnectionBuilderHttpExtensions.cs b/src/Microsoft.AspNetCore.SignalR.Client/HubConnectionBuilderHttpExtensions.cs index 4d5e0fb908..5ba00304ec 100644 --- a/src/Microsoft.AspNetCore.SignalR.Client/HubConnectionBuilderHttpExtensions.cs +++ b/src/Microsoft.AspNetCore.SignalR.Client/HubConnectionBuilderHttpExtensions.cs @@ -33,14 +33,14 @@ namespace Microsoft.AspNetCore.SignalR.Client hubConnectionBuilder.ConfigureConnectionFactory(() => { return new HttpConnection(url, - hubConnectionBuilder.GetTransportType(), + hubConnectionBuilder.GetTransport(), hubConnectionBuilder.GetLoggerFactory(), hubConnectionBuilder.GetMessageHandler()); }); return hubConnectionBuilder; } - public static IHubConnectionBuilder WithTransportType(this IHubConnectionBuilder hubConnectionBuilder, TransportType transportType) + public static IHubConnectionBuilder WithTransport(this IHubConnectionBuilder hubConnectionBuilder, TransportType transportType) { hubConnectionBuilder.AddSetting(TransportTypeKey, transportType); return hubConnectionBuilder; @@ -52,7 +52,7 @@ namespace Microsoft.AspNetCore.SignalR.Client return hubConnectionBuilder; } - public static TransportType GetTransportType(this IHubConnectionBuilder hubConnectionBuilder) + public static TransportType GetTransport(this IHubConnectionBuilder hubConnectionBuilder) { if (hubConnectionBuilder.TryGetSetting(TransportTypeKey, out var transportType)) { diff --git a/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs b/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs index 799c059f03..debddd6198 100644 --- a/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs @@ -46,7 +46,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests { var connection = new HubConnectionBuilder() .WithUrl(_serverFixture.BaseUrl + path) - .WithTransportType(transportType) + .WithTransport(transportType) .WithLoggerFactory(loggerFactory) .WithHubProtocol(protocol) .Build(); diff --git a/test/Microsoft.AspNetCore.SignalR.Client.Tests/HubConnectionBuilderExtensionsTests.cs b/test/Microsoft.AspNetCore.SignalR.Client.Tests/HubConnectionBuilderExtensionsTests.cs index d93c28ebaa..d1d297cf42 100644 --- a/test/Microsoft.AspNetCore.SignalR.Client.Tests/HubConnectionBuilderExtensionsTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Client.Tests/HubConnectionBuilderExtensionsTests.cs @@ -71,11 +71,11 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests [InlineData(TransportType.WebSockets)] [InlineData(TransportType.ServerSentEvents)] [InlineData(TransportType.LongPolling)] - public void WithTransportTypeRegistersGivenTransportType(TransportType transportType) + public void WithTransportRegistersGivenTransportType(TransportType transportType) { var connectionBuilder = new HubConnectionBuilder(); - connectionBuilder.WithTransportType(transportType); - Assert.Equal(transportType, connectionBuilder.GetTransportType()); + connectionBuilder.WithTransport(transportType); + Assert.Equal(transportType, connectionBuilder.GetTransport()); } } } diff --git a/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs b/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs index 5006ada18c..4c3b6a0067 100644 --- a/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs @@ -286,7 +286,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests var connection = new HubConnectionBuilder() .WithUrl(new Uri(url)) - .WithTransportType(transportType) + .WithTransport(transportType) .WithLoggerFactory(loggerFactory) .Build(); try