Don't use depricated methods (#751)

Don't use depricated methods
This commit is contained in:
Ryan Brandenburg 2018-09-26 12:50:24 -07:00 committed by GitHub
parent c6347f035f
commit b07338b618
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 27 additions and 20 deletions

View File

@ -14,18 +14,20 @@ function Test-Template($templateName, $templateArgs, $templateNupkg, $isSPA) {
try { try {
Run-DotnetNew $templateArgs, "--no-restore" Run-DotnetNew $templateArgs, "--no-restore"
if($templateArgs -match 'F#') if ($templateArgs -match 'F#') {
{
$extension = "fsproj" $extension = "fsproj"
} }
else else {
{
$extension = "csproj" $extension = "csproj"
} }
$proj = "$tmpDir/$templateName.$extension" $proj = "$tmpDir/$templateName.$extension"
$projContent = Get-Content -Path $proj -Raw $projContent = Get-Content -Path $proj -Raw
$projContent = $projContent -replace ('<Project Sdk="Microsoft.NET.Sdk.Web">', "<Project Sdk=""Microsoft.NET.Sdk.Web"">`n<Import Project=""$PSScriptRoot/../test/Templates.Test/bin/Debug/netcoreapp2.2/TemplateTests.props"" />") $projContent = $projContent -replace ('<Project Sdk="Microsoft.NET.Sdk.Web">', "<Project Sdk=""Microsoft.NET.Sdk.Web"">
<Import Project=""$PSScriptRoot/../test/Templates.Test/bin/Debug/netcoreapp2.2/TemplateTests.props"" />
<ItemGroup>
<PackageReference Include=""Microsoft.NET.Sdk.Razor"" Version=""`$(MicrosoftNETSdkRazorPackageVersion)"" />
</ItemGroup>")
$projContent | Set-Content $proj $projContent | Set-Content $proj
dotnet publish --configuration Release dotnet publish --configuration Release

View File

@ -1,5 +1,6 @@
import React, { Component } from 'react'; import React, { Component } from 'react';
import { Collapse, Container, Navbar, NavbarBrand, NavbarToggler, NavItem, NavLink } from 'reactstrap'; import { Collapse, Container, Navbar, NavbarBrand, NavbarToggler, NavItem, NavLink } from 'reactstrap';
import { Link } from 'react-router-dom';
import './NavMenu.css'; import './NavMenu.css';
export class NavMenu extends Component { export class NavMenu extends Component {
@ -25,18 +26,18 @@ export class NavMenu extends Component {
<header> <header>
<Navbar className="navbar-expand-sm navbar-toggleable-sm ng-white border-bottom box-shadow mb-3" light> <Navbar className="navbar-expand-sm navbar-toggleable-sm ng-white border-bottom box-shadow mb-3" light>
<Container> <Container>
<NavbarBrand href="/">Company.WebApplication1</NavbarBrand> <NavbarBrand tag={Link} to="/">Company.WebApplication1</NavbarBrand>
<NavbarToggler onClick={this.toggleNavbar} className="mr-2" /> <NavbarToggler onClick={this.toggleNavbar} className="mr-2" />
<Collapse className="d-sm-inline-flex flex-sm-row-reverse" isOpen={!this.state.collapsed} navbar> <Collapse className="d-sm-inline-flex flex-sm-row-reverse" isOpen={!this.state.collapsed} navbar>
<ul className="navbar-nav flex-grow"> <ul className="navbar-nav flex-grow">
<NavItem> <NavItem>
<NavLink className="text-dark" href="/">Home</NavLink> <NavLink tag={Link} className="text-dark" to="/">Home</NavLink>
</NavItem> </NavItem>
<NavItem> <NavItem>
<NavLink className="text-dark" href="/counter">Counter</NavLink> <NavLink tag={Link} className="text-dark" to="/counter">Counter</NavLink>
</NavItem> </NavItem>
<NavItem> <NavItem>
<NavLink className="text-dark" href="/fetch-data">Fetch data</NavLink> <NavLink tag={Link} className="text-dark" to="/fetch-data">Fetch data</NavLink>
</NavItem> </NavItem>
</ul> </ul>
</Collapse> </Collapse>

View File

@ -5,15 +5,18 @@ import { Link } from 'react-router-dom';
import { actionCreators } from '../store/WeatherForecasts'; import { actionCreators } from '../store/WeatherForecasts';
class FetchData extends Component { class FetchData extends Component {
componentWillMount() { componentDidMount() {
// This method runs when the component is first added to the page // This method is called when the component is first added to the document
const startDateIndex = parseInt(this.props.match.params.startDateIndex, 10) || 0; this.ensureDataFetched();
this.props.requestWeatherForecasts(startDateIndex);
} }
componentWillReceiveProps(nextProps) { componentDidUpdate() {
// This method runs when incoming props (e.g., route params) change // This method is called when the route parameters change
const startDateIndex = parseInt(nextProps.match.params.startDateIndex, 10) || 0; this.ensureDataFetched();
}
ensureDataFetched() {
const startDateIndex = parseInt(this.props.match.params.startDateIndex, 10) || 0;
this.props.requestWeatherForecasts(startDateIndex); this.props.requestWeatherForecasts(startDateIndex);
} }

View File

@ -1,5 +1,6 @@
import React from 'react'; import React from 'react';
import { Collapse, Container, Navbar, NavbarBrand, NavbarToggler, NavItem, NavLink } from 'reactstrap'; import { Collapse, Container, Navbar, NavbarBrand, NavbarToggler, NavItem, NavLink } from 'reactstrap';
import { Link } from 'react-router-dom';
import './NavMenu.css'; import './NavMenu.css';
export default class NavMenu extends React.Component { export default class NavMenu extends React.Component {
@ -21,18 +22,18 @@ export default class NavMenu extends React.Component {
<header> <header>
<Navbar className="navbar-expand-sm navbar-toggleable-sm border-bottom box-shadow mb-3" light > <Navbar className="navbar-expand-sm navbar-toggleable-sm border-bottom box-shadow mb-3" light >
<Container> <Container>
<NavbarBrand href="/">Company.WebApplication1</NavbarBrand> <NavbarBrand tag={Link} to="/">Company.WebApplication1</NavbarBrand>
<NavbarToggler onClick={this.toggle} className="mr-2" /> <NavbarToggler onClick={this.toggle} className="mr-2" />
<Collapse className="d-sm-inline-flex flex-sm-row-reverse" isOpen={this.state.isOpen} navbar> <Collapse className="d-sm-inline-flex flex-sm-row-reverse" isOpen={this.state.isOpen} navbar>
<ul className="navbar-nav flex-grow"> <ul className="navbar-nav flex-grow">
<NavItem> <NavItem>
<NavLink className="text-dark" href="/">Home</NavLink> <NavLink tag={Link} className="text-dark" to="/">Home</NavLink>
</NavItem> </NavItem>
<NavItem> <NavItem>
<NavLink className="text-dark" href="/counter">Counter</NavLink> <NavLink tag={Link} className="text-dark" to="/counter">Counter</NavLink>
</NavItem> </NavItem>
<NavItem> <NavItem>
<NavLink className="text-dark" href="/fetch-data">Fetch data</NavLink> <NavLink tag={Link} className="text-dark" to="/fetch-data">Fetch data</NavLink>
</NavItem> </NavItem>
</ul> </ul>
</Collapse> </Collapse>