From afa89b39932f3f0a9567779029d996f5e78b210a Mon Sep 17 00:00:00 2001 From: Cesar Blum Silveira Date: Fri, 16 Sep 2016 09:09:26 -0700 Subject: [PATCH] Change SkipReason for ThreadCountTests on OS X. --- .../ThreadCountTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ThreadCountTests.cs b/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ThreadCountTests.cs index ebcf01b09a..e4a723a9d1 100644 --- a/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ThreadCountTests.cs +++ b/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ThreadCountTests.cs @@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests { [ConditionalTheory] [MemberData(nameof(OneToTen))] - [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Test failures pending investigation.")] + [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Tests fail on OS X due to low file descriptor limit.")] public async Task OneToTenThreads(int threadCount) { var hostBuilder = new WebHostBuilder() @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests { return context.Response.WriteAsync("Hello World"); }); - }); + }); using (var host = hostBuilder.Build()) { @@ -46,7 +46,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var requestTask = client.GetStringAsync($"http://localhost:{host.GetPort()}/"); requestTasks.Add(requestTask); } - + foreach (var result in await Task.WhenAll(requestTasks)) { Assert.Equal("Hello World", result);