huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Re-enable AssemblyTestLogTests (#19686)

This commit is contained in:
John Luo 2020-03-08 22:19:55 -07:00 committed by GitHub
parent 124a0b6b38
commit aebb921320
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Testing/test/AssemblyTestLogTests.cs
View File

@ -18,7 +18,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
{ {
private static readonly Assembly ThisAssembly = typeof(AssemblyTestLogTests).GetTypeInfo().Assembly; private static readonly Assembly ThisAssembly = typeof(AssemblyTestLogTests).GetTypeInfo().Assembly;
private static readonly string ThisAssemblyName = ThisAssembly.GetName().Name; private static readonly string ThisAssemblyName = ThisAssembly.GetName().Name;
private static readonly string TFM = new DirectoryInfo(AppContext.BaseDirectory).Name; private static readonly string TFM = ThisAssembly.GetCustomAttributes().OfType<TestOutputDirectoryAttribute>().FirstOrDefault().TargetFramework;
[Fact] [Fact]
public void FunctionalLogs_LogsPreservedFromNonQuarantinedTest() public void FunctionalLogs_LogsPreservedFromNonQuarantinedTest()
@ -76,7 +76,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
} }
}); });
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")] [Fact]
public Task TestLogWritesToGlobalLogFile() => public Task TestLogWritesToGlobalLogFile() =>
RunTestLogFunctionalTest((tempDir) => RunTestLogFunctionalTest((tempDir) =>
{ {
@ -120,7 +120,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
", testLogContent, ignoreLineEndingDifferences: true); ", testLogContent, ignoreLineEndingDifferences: true);
}); });
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")] [Fact]
public Task TestLogTruncatesTestNameToAvoidLongPaths() => public Task TestLogTruncatesTestNameToAvoidLongPaths() =>
RunTestLogFunctionalTest((tempDir) => RunTestLogFunctionalTest((tempDir) =>
{ {
@ -147,7 +147,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
Assert.Equal(longTestName.Substring(longTestName.Length - testFileName.Length / 2, testFileName.Length / 2), testFileName.Substring(testFileName.Length - testFileName.Length / 2, testFileName.Length / 2)); Assert.Equal(longTestName.Substring(longTestName.Length - testFileName.Length / 2, testFileName.Length / 2), testFileName.Substring(testFileName.Length - testFileName.Length / 2, testFileName.Length / 2));
}); });
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")] [Fact]
public Task TestLogEnumerateFilenamesToAvoidCollisions() => public Task TestLogEnumerateFilenamesToAvoidCollisions() =>
RunTestLogFunctionalTest((tempDir) => RunTestLogFunctionalTest((tempDir) =>
{ {