From ad8ecf96a1d9840167a87faf080cc2f48531a307 Mon Sep 17 00:00:00 2001 From: Chris Ross Date: Wed, 15 Jan 2020 11:07:50 -0800 Subject: [PATCH] React to runtime/594 Encoder.Convert change (#17747) --- .../src/Extensions/HttpResponseWritingExtensions.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Http/Http.Abstractions/src/Extensions/HttpResponseWritingExtensions.cs b/src/Http/Http.Abstractions/src/Extensions/HttpResponseWritingExtensions.cs index 7d4532c4c8..c94118a82e 100644 --- a/src/Http/Http.Abstractions/src/Extensions/HttpResponseWritingExtensions.cs +++ b/src/Http/Http.Abstractions/src/Extensions/HttpResponseWritingExtensions.cs @@ -133,7 +133,8 @@ namespace Microsoft.AspNetCore.Http // Therefore, we check encodedLength - totalBytesUsed too. while (!completed || encodedLength - totalBytesUsed != 0) { - encoder.Convert(source, destination, flush: source.Length == 0, out var charsUsed, out var bytesUsed, out completed); + // 'text' is a complete string, the converter should always flush its buffer. + encoder.Convert(source, destination, flush: true, out var charsUsed, out var bytesUsed, out completed); totalBytesUsed += bytesUsed; writer.Advance(bytesUsed);