huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update build tools and exclude symbols.nupkg files from signcheck (#6939) 

Changes:
* Update BuildTools
* Normalize slashes to avoid double restore
* Exclude .symbols.nupkg files from signcheck. These are not shipped to customers and do not need to be signed. We can save time and bandwidth by not code-signing these. After this merges, I will re-enable signcheck on CI.
This commit is contained in:
Nate McMaster 2019-01-23 07:52:17 -08:00 committed by GitHub
parent a1d49e19b5
commit ad8975001a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
build.ps1
View File

@ -273,6 +273,7 @@ $MSBuildArguments += "/p:_RunSign=$Sign"
Import-Module -Force -Scope Local (Join-Path $korebuildPath 'KoreBuild.psd1')
try {
$RepoRoot = Resolve-Path $RepoRoot
Set-KoreBuildSettings -ToolsSource $ToolsSource -DotNetHome $DotNetHome -RepoPath $RepoRoot -ConfigFile $ConfigFile -CI:$CI
if ($ForceCoreMsbuild) {
$global:KoreBuildSettings.MSBuildType = 'core'

2
build/RepositoryBuild.targets
View File

@ -106,7 +106,7 @@
<Message Text="============ Building $(RepositoryToBuild) ============" Importance="High" />
<Exec
Command="./$(_BuildScriptToExecute) -RepoRoot $(BuildRepositoryRoot) $(BuildArguments)"
Command="./$(_BuildScriptToExecute) -RepoRoot $(BuildRepositoryRoot.TrimEnd('\').TrimEnd('/')) $(BuildArguments)"
IgnoreStandardErrorWarningFormat="true"
WorkingDirectory="$(RepositoryRoot)"
IgnoreExitCode="true"

2
eng/Versions.props
View File

@ -110,7 +110,7 @@
</PropertyGroup>
<PropertyGroup Label="Build tool dependencies">
<InternalAspNetCoreSdkPackageVersion>$(KoreBuildVersion)</InternalAspNetCoreSdkPackageVersion>
<InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">3.0.0-build-20190118.4</InternalAspNetCoreSdkPackageVersion>
<InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">3.0.0-build-20190122.3</InternalAspNetCoreSdkPackageVersion>
<MicrosoftNETFrameworkReferenceAssembliesPackageVersion>1.0.0-alpha-004</MicrosoftNETFrameworkReferenceAssembliesPackageVersion>
<MicrosoftNETTestSdkPackageVersion>15.9.0</MicrosoftNETTestSdkPackageVersion>
</PropertyGroup>

1
eng/signcheck.exclusions.txt
View File

@ -4,3 +4,4 @@ content/*.js;Microsoft.DotNet.Web.ProjectTemplates.*.nupkg; Exclude JavaScript f
Templates/*.js;Microsoft.VisualStudio.Web.CodeGenerators.Mvc.*.nupkg; Exclude JavaScript files from codesigning in code generators
*.js;signalr-*-javadoc.jar; Exclude JavaScript files in the generated javadocs
*.binlog; Exclude msbuild log files
*.symbols.nupkg; Exclude NuGet symbols packages. These are not shipped to customers and should not be code signed.

2
global.json
View File

@ -3,6 +3,6 @@
"version": "3.0.100-preview-009750"
},
"msbuild-sdks": {
"Internal.AspNetCore.Sdk": "3.0.0-build-20190118.4"
"Internal.AspNetCore.Sdk": "3.0.0-build-20190122.3"
}
}

4
korebuild-lock.txt
View File

@ -1,2 +1,2 @@
version:3.0.0-build-20190118.4
commithash:dc060235e4056a2a5ec0141fa89da9e490544268
version:3.0.0-build-20190122.3
commithash:43e5fa8e3d8b192e573c3c14ae39b43e1d05cd5e