From ad3cba550955446cfa30db484c4160f569d16961 Mon Sep 17 00:00:00 2001 From: "Chris Ross (ASP.NET)" Date: Fri, 19 Oct 2018 18:05:56 -0700 Subject: [PATCH] Disable inheritance test on linux #3034 --- .../HandleInheritanceTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/Kestrel.Transport.FunctionalTests/HandleInheritanceTests.cs b/test/Kestrel.Transport.FunctionalTests/HandleInheritanceTests.cs index cbbcb8b454..cd75141197 100644 --- a/test/Kestrel.Transport.FunctionalTests/HandleInheritanceTests.cs +++ b/test/Kestrel.Transport.FunctionalTests/HandleInheritanceTests.cs @@ -17,7 +17,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests public class HandleInheritanceTests : TestApplicationErrorLoggerLoggedTest { [ConditionalFact] - [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "No fix available for Mac https://github.com/aspnet/KestrelHttpServer/pull/2944#issuecomment-426397600")] + [OSSkipCondition(OperatingSystems.Linux, SkipReason = "Fixed in 3.0 https://github.com/aspnet/KestrelHttpServer/issues/3040")] + [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Fixed in 3.0 https://github.com/aspnet/KestrelHttpServer/issues/3040")] public async Task SpawnChildProcess_DoesNotInheritListenHandle() { var hostBuilder = TransportSelector.GetWebHostBuilder() @@ -38,7 +39,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var processInfo = new ProcessStartInfo { - FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "cmd.exe" : "vi", + FileName = "cmd.exe", CreateNoWindow = true, }; using (var process = Process.Start(processInfo))