From ac9a6f331e3976e6ea170bec5a6964d080400c16 Mon Sep 17 00:00:00 2001 From: Brennan Date: Wed, 4 Sep 2019 19:27:14 -0700 Subject: [PATCH] Fix User-Agent typo Java (#13692) --- .../src/main/java/com/microsoft/signalr/UserAgentHelper.java | 2 +- .../src/test/java/com/microsoft/signalr/HubConnectionTest.java | 2 +- .../src/test/java/com/microsoft/signalr/UserAgentTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/UserAgentHelper.java b/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/UserAgentHelper.java index 988da567f4..e54809c700 100644 --- a/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/UserAgentHelper.java +++ b/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/UserAgentHelper.java @@ -17,7 +17,7 @@ public class UserAgentHelper { // Parsing version numbers String detailedVersion = Version.getDetailedVersion(); agentBuilder.append(getVersion(detailedVersion)); - agentBuilder.append("; ("); + agentBuilder.append(" ("); agentBuilder.append(detailedVersion); agentBuilder.append("; "); diff --git a/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java b/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java index 051b5fed83..af01f5311c 100644 --- a/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java +++ b/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java @@ -1116,7 +1116,7 @@ class HubConnectionTest { hubConnection.start().timeout(1, TimeUnit.SECONDS).blockingAwait(); AtomicBoolean done = new AtomicBoolean(); - Single result = hubConnection.invoke(String.class, "fixedMessage", null); + Single result = hubConnection.invoke(String.class, "fixedMessage", (Object)null); result.doOnSuccess(value -> done.set(true)).subscribe(); assertEquals("{\"type\":1,\"invocationId\":\"1\",\"target\":\"fixedMessage\",\"arguments\":[null]}" + RECORD_SEPARATOR, mockTransport.getSentMessages()[1]); assertFalse(done.get()); diff --git a/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/UserAgentTest.java b/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/UserAgentTest.java index 59715223b9..362b035a27 100644 --- a/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/UserAgentTest.java +++ b/src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/UserAgentTest.java @@ -46,7 +46,7 @@ public class UserAgentTest { String detailedVersion = Version.getDetailedVersion(); String handMadeUserAgent = "Microsoft SignalR/" + UserAgentHelper.getVersion(detailedVersion) + - "; (" + detailedVersion + "; " + UserAgentHelper.getOS() + "; Java; " + + " (" + detailedVersion + "; " + UserAgentHelper.getOS() + "; Java; " + UserAgentHelper.getJavaVersion() + "; " + UserAgentHelper.getJavaVendor() + ")"; assertEquals(handMadeUserAgent, userAgent);