huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix flaky tests.

This commit is contained in:
Cesar Blum Silveira 2017-01-25 11:00:31 -08:00
parent c8da6e0628
commit aacb7d7453
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/Microsoft.AspNetCore.Server.KestrelTests/EngineTests.cs
View File

@ -832,13 +832,15 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
"", "",
""); "");
}
}
Assert.Equal(2, onStartingCallCount1); Assert.Equal(2, onStartingCallCount1);
// The second OnStarting callback should not be called since the first failed. // The second OnStarting callback should not be called since the first failed.
Assert.Equal(0, onStartingCallCount2); Assert.Equal(0, onStartingCallCount2);
Assert.Equal(2, testLogger.ApplicationErrorsLogged); Assert.Equal(2, testLogger.ApplicationErrorsLogged);
} }
}
}
[Theory] [Theory]
[MemberData(nameof(ConnectionFilterData))] [MemberData(nameof(ConnectionFilterData))]
@ -882,13 +884,13 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
"", "",
"Hello World"); "Hello World");
} }
}
// All OnCompleted callbacks should be called even if they throw. // All OnCompleted callbacks should be called even if they throw.
Assert.Equal(2, testLogger.ApplicationErrorsLogged); Assert.Equal(2, testLogger.ApplicationErrorsLogged);
Assert.True(onCompletedCalled1); Assert.True(onCompletedCalled1);
Assert.True(onCompletedCalled2); Assert.True(onCompletedCalled2);
} }
}
[Theory] [Theory]
[MemberData(nameof(ConnectionFilterData))] [MemberData(nameof(ConnectionFilterData))]