From a898f98a7f8b055ef5a1dda32a58b1b9631ca3a9 Mon Sep 17 00:00:00 2001
From: Pranav K <prkrishn@hotmail.com>
Date: Thu, 20 Sep 2018 12:41:06 -0700
Subject: [PATCH] Print an error when using Razor build with an older version
 of the Sdk

---
 ...etCore.Razor.Design.CodeGeneration.targets | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/src/Microsoft.AspNetCore.Razor.Design/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets b/src/Microsoft.AspNetCore.Razor.Design/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets
index 374252655b..c81d741e1f 100644
--- a/src/Microsoft.AspNetCore.Razor.Design/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets
+++ b/src/Microsoft.AspNetCore.Razor.Design/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets
@@ -4,8 +4,15 @@
     This target is explicitly imported by Razor SDK.
   -->
 
-  <UsingTask TaskName="Microsoft.AspNetCore.Razor.Tasks.RazorGenerate" AssemblyFile="$(RazorSdkBuildTasksAssembly)" />
-  <UsingTask TaskName="Microsoft.AspNetCore.Razor.Tasks.RazorTagHelper" AssemblyFile="$(RazorSdkBuildTasksAssembly)" />
+  <UsingTask
+    TaskName="Microsoft.AspNetCore.Razor.Tasks.RazorGenerate"
+    AssemblyFile="$(RazorSdkBuildTasksAssembly)"
+    Condition="'$(RazorSdkBuildTasksAssembly)' != ''" />
+
+  <UsingTask
+    TaskName="Microsoft.AspNetCore.Razor.Tasks.RazorTagHelper"
+    AssemblyFile="$(RazorSdkBuildTasksAssembly)"
+    Condition="'$(RazorSdkBuildTasksAssembly)' != ''" />
 
   <!-- 
     Consider these properties to be private to this targets file. The main Razor SDK should define all of the properties
@@ -51,7 +58,7 @@
 
   <Target
     Name="ResolveTagHelperRazorGenerateInputs"
-    DependsOnTargets="Compile"
+    DependsOnTargets="_EnsureRazorTasksAssemblyDefined;Compile"
     Inputs="$(MSBuildAllProjects);@(RazorReferencePath)"
     Outputs="$(_RazorTagHelperInputCache)"
     Condition="'@(RazorGenerateWithTargetPath)' != ''">
@@ -100,6 +107,7 @@
 
   <PropertyGroup>
     <RazorCoreGenerateDependsOn>
+      _EnsureRazorTasksAssemblyDefined;
       _HashRazorGenerateInputs;
       _ResolveRazorGenerateOutputs;
     </RazorCoreGenerateDependsOn>
@@ -149,4 +157,10 @@
     </ItemGroup>
   </Target>
 
+  <Target Name="_EnsureRazorTasksAssemblyDefined">
+    <Error 
+      Text="Assembly location for Razor SDK Tasks was not specified. The most likely cause is an older incompatible version of Microsoft.NET.Sdk.Razor, or Microsoft.NET.Sdk.Web used by this project. Please target a newer version of the .NET Core SDK." 
+      Condition="'$(RazorSdkBuildTasksAssembly)' == ''" />
+  </Target>
+
 </Project>