huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update calls for string comparison

This commit is contained in:
John Luo 2016-08-30 12:29:27 -07:00
parent 1d6c5af72c
commit a5e9215982
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Microsoft.AspNetCore.ResponseCaching/Internal/DefaultResponseCacheEntrySerializer.cs
View File

@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.ResponseCaching.Internal
// Serialization Format // Serialization Format
// Format version (int) // Format version (int)
// Type (string) // Type (char: 'R' for CachedResponse, 'V' for CachedVaryBy)
// Type-dependent data (see CachedResponse and CachedVaryBy) // Type-dependent data (see CachedResponse and CachedVaryBy)
public static object Read(BinaryReader reader) public static object Read(BinaryReader reader)
{ {
@ -51,14 +51,14 @@ namespace Microsoft.AspNetCore.ResponseCaching.Internal
return null; return null;
} }
var type = reader.ReadString(); var type = reader.ReadChar();
if (string.Equals(nameof(CachedResponse), type)) if (type == 'R')
{ {
var cachedResponse = ReadCachedResponse(reader); var cachedResponse = ReadCachedResponse(reader);
return cachedResponse; return cachedResponse;
} }
else if (string.Equals(nameof(CachedVaryBy), type)) else if (type == 'V')
{ {
var cachedResponse = ReadCachedVaryBy(reader); var cachedResponse = ReadCachedVaryBy(reader);
return cachedResponse; return cachedResponse;
@ -150,7 +150,7 @@ namespace Microsoft.AspNetCore.ResponseCaching.Internal
// See serialization format above // See serialization format above
private static void WriteCachedResponse(BinaryWriter writer, CachedResponse entry) private static void WriteCachedResponse(BinaryWriter writer, CachedResponse entry)
{ {
writer.Write(nameof(CachedResponse)); writer.Write('R');
writer.Write(entry.Created.UtcTicks); writer.Write(entry.Created.UtcTicks);
writer.Write(entry.StatusCode); writer.Write(entry.StatusCode);
writer.Write(entry.Headers.Count); writer.Write(entry.Headers.Count);
@ -167,7 +167,7 @@ namespace Microsoft.AspNetCore.ResponseCaching.Internal
// See serialization format above // See serialization format above
private static void WriteCachedVaryBy(BinaryWriter writer, CachedVaryBy entry) private static void WriteCachedVaryBy(BinaryWriter writer, CachedVaryBy entry)
{ {
writer.Write(nameof(CachedVaryBy)); writer.Write('V');
writer.Write(entry.Headers.Count); writer.Write(entry.Headers.Count);
foreach (var header in entry.Headers) foreach (var header in entry.Headers)

2
src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingContext.cs
View File

@ -192,7 +192,7 @@ namespace Microsoft.AspNetCore.ResponseCaching
builder.Append(KeyDelimiter) builder.Append(KeyDelimiter)
.Append('Q'); .Append('Q');
if (varyBy.Params.Count == 1 && string.Equals(varyBy.Params[0], "*")) if (varyBy.Params.Count == 1 && string.Equals(varyBy.Params[0], "*", StringComparison.Ordinal))
{ {
// Vary by all available query params // Vary by all available query params
foreach (var query in _httpContext.Request.Query.OrderBy(q => q.Key, StringComparer.OrdinalIgnoreCase)) foreach (var query in _httpContext.Request.Query.OrderBy(q => q.Key, StringComparer.OrdinalIgnoreCase))