huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Skip failing tests temporarily (#506)

This commit is contained in:
Jass Bagga 2018-01-03 14:11:41 -08:00 committed by GitHub
parent bf231f0da8
commit a50780f8e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 79 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

118
test/Microsoft.AspNetCore.Dispatcher.Test/RoutePatternBinderTest.cs
View File

@ -5,6 +5,7 @@ using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Text.Encodings.Web; using System.Text.Encodings.Web;
using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.Extensions.ObjectPool; using Microsoft.Extensions.ObjectPool;
using Microsoft.Extensions.WebEncoders.Testing; using Microsoft.Extensions.WebEncoders.Testing;
using Xunit; using Xunit;
@ -109,8 +110,9 @@ namespace Microsoft.AspNetCore.Dispatcher
}, },
}; };
[Theory] [ConditionalTheory]
[MemberData(nameof(EmptyAndNullDefaultValues))] [MemberData(nameof(EmptyAndNullDefaultValues))]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void Binding_WithEmptyAndNull_DefaultValues( public void Binding_WithEmptyAndNull_DefaultValues(
string pattern, string pattern,
DispatcherValueCollection defaults, DispatcherValueCollection defaults,
@ -146,7 +148,8 @@ namespace Microsoft.AspNetCore.Dispatcher
} }
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnBothEndsMatches() public void GetVirtualPathWithMultiSegmentParamsOnBothEndsMatches()
{ {
RunTest( RunTest(
@ -157,7 +160,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]"); "/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnLeftEndMatches() public void GetVirtualPathWithMultiSegmentParamsOnLeftEndMatches()
{ {
RunTest( RunTest(
@ -168,7 +172,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]UrlEncode[[a]]"); "/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]UrlEncode[[a]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnRightEndMatches() public void GetVirtualPathWithMultiSegmentParamsOnRightEndMatches()
{ {
RunTest( RunTest(
@ -253,8 +258,9 @@ namespace Microsoft.AspNetCore.Dispatcher
}, },
}; };
[Theory] [ConditionalTheory]
[MemberData(nameof(OptionalParamValues))] [MemberData(nameof(OptionalParamValues))]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentWithOptionalParam( public void GetVirtualPathWithMultiSegmentWithOptionalParam(
string pattern, string pattern,
DispatcherValueCollection defaults, DispatcherValueCollection defaults,
@ -291,7 +297,8 @@ namespace Microsoft.AspNetCore.Dispatcher
} }
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndMatches() public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndMatches()
{ {
RunTest( RunTest(
@ -302,7 +309,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]UrlEncode[[a]]"); "/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]UrlEncode[[-]]UrlEncode[[yy]]UrlEncode[[a]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndDoesNotMatch() public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndDoesNotMatch()
{ {
RunTest( RunTest(
@ -313,7 +321,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndDoesNotMatch2() public void GetVirtualPathWithMultiSegmentParamsOnNeitherEndDoesNotMatch2()
{ {
RunTest( RunTest(
@ -324,7 +333,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithSimpleMultiSegmentParamsOnBothEndsMatches() public void GetVirtualPathWithSimpleMultiSegmentParamsOnBothEndsMatches()
{ {
RunTest( RunTest(
@ -335,7 +345,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[xx]]"); "/UrlEncode[[language]]/UrlEncode[[xx]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithSimpleMultiSegmentParamsOnLeftEndMatches() public void GetVirtualPathWithSimpleMultiSegmentParamsOnLeftEndMatches()
{ {
RunTest( RunTest(
@ -346,7 +357,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]"); "/UrlEncode[[language]]/UrlEncode[[xx]]UrlEncode[[-]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithSimpleMultiSegmentParamsOnRightEndMatches() public void GetVirtualPathWithSimpleMultiSegmentParamsOnRightEndMatches()
{ {
RunTest( RunTest(
@ -357,7 +369,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]"); "/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithSimpleMultiSegmentParamsOnNeitherEndMatches() public void GetVirtualPathWithSimpleMultiSegmentParamsOnNeitherEndMatches()
{ {
RunTest( RunTest(
@ -368,7 +381,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]UrlEncode[[a]]"); "/UrlEncode[[language]]/UrlEncode[[a]]UrlEncode[[xx]]UrlEncode[[a]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentStandardMvcRouteMatches() public void GetVirtualPathWithMultiSegmentStandardMvcRouteMatches()
{ {
RunTest( RunTest(
@ -379,7 +393,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[products]]UrlEncode[[.mvc]]"); "/UrlEncode[[products]]UrlEncode[[.mvc]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithMultiSegmentParamsOnBothEndsWithDefaultValuesMatches() public void GetVirtualPathWithMultiSegmentParamsOnBothEndsWithDefaultValuesMatches()
{ {
RunTest( RunTest(
@ -390,7 +405,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[language]]/UrlEncode[[zz]]UrlEncode[[-]]UrlEncode[[yy]]"); "/UrlEncode[[language]]/UrlEncode[[zz]]UrlEncode[[-]]UrlEncode[[yy]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithDefaultValue() public void GetUrlWithDefaultValue()
{ {
// URL should be found but excluding the 'id' parameter, which has only a default value. // URL should be found but excluding the 'id' parameter, which has only a default value.
@ -402,7 +418,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[home]]/UrlEncode[[newaction]]"); "/UrlEncode[[home]]/UrlEncode[[newaction]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithEmptyStringRequiredValueReturnsNull() public void GetVirtualPathWithEmptyStringRequiredValueReturnsNull()
{ {
RunTest( RunTest(
@ -413,7 +430,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithNullRequiredValueReturnsNull() public void GetVirtualPathWithNullRequiredValueReturnsNull()
{ {
RunTest( RunTest(
@ -424,7 +442,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithRequiredValueReturnsPath() public void GetVirtualPathWithRequiredValueReturnsPath()
{ {
RunTest( RunTest(
@ -435,7 +454,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[foo]]/UrlEncode[[home]]"); "/UrlEncode[[foo]]/UrlEncode[[home]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithNullDefaultValue() public void GetUrlWithNullDefaultValue()
{ {
// URL should be found but excluding the 'id' parameter, which has only a default value. // URL should be found but excluding the 'id' parameter, which has only a default value.
@ -447,7 +467,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[home]]/UrlEncode[[newaction]]"); "/UrlEncode[[home]]/UrlEncode[[newaction]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathCanFillInSeparatedParametersWithDefaultValues() public void GetVirtualPathCanFillInSeparatedParametersWithDefaultValues()
{ {
RunTest( RunTest(
@ -458,7 +479,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[Orders]]/UrlEncode[[en]]UrlEncode[[-]]UrlEncode[[US]]"); "/UrlEncode[[Orders]]/UrlEncode[[en]]UrlEncode[[-]]UrlEncode[[US]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathWithUnusedNullValueShouldGenerateUrlAndIgnoreNullValue() public void GetVirtualPathWithUnusedNullValueShouldGenerateUrlAndIgnoreNullValue()
{ {
RunTest( RunTest(
@ -469,7 +491,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[Home]]UrlEncode[[.mvc]]/UrlEncode[[TestAction]]/UrlEncode[[1]]"); "/UrlEncode[[Home]]UrlEncode[[.mvc]]/UrlEncode[[TestAction]]/UrlEncode[[1]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithMissingValuesDoesntMatch() public void GetUrlWithMissingValuesDoesntMatch()
{ {
RunTest( RunTest(
@ -480,7 +503,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithEmptyRequiredValuesReturnsNull() public void GetUrlWithEmptyRequiredValuesReturnsNull()
{ {
RunTest( RunTest(
@ -491,7 +515,8 @@ namespace Microsoft.AspNetCore.Dispatcher
null); null);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithEmptyOptionalValuesReturnsShortUrl() public void GetUrlWithEmptyOptionalValuesReturnsShortUrl()
{ {
RunTest( RunTest(
@ -502,7 +527,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[v1]]"); "/UrlEncode[[v1]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlShouldIgnoreValuesAfterChangedParameter() public void GetUrlShouldIgnoreValuesAfterChangedParameter()
{ {
RunTest( RunTest(
@ -513,7 +539,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[orig]]/UrlEncode[[new]]"); "/UrlEncode[[orig]]/UrlEncode[[new]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithNullForMiddleParameterIgnoresRemainingParameters() public void GetUrlWithNullForMiddleParameterIgnoresRemainingParameters()
{ {
RunTest( RunTest(
@ -525,7 +552,8 @@ namespace Microsoft.AspNetCore.Dispatcher
+ "UrlEncode[[Photos]]/UrlEncode[[1995]]/UrlEncode[[Hola]]"); + "UrlEncode[[Photos]]/UrlEncode[[1995]]/UrlEncode[[Hola]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithEmptyStringForMiddleParameterIgnoresRemainingParameters() public void GetUrlWithEmptyStringForMiddleParameterIgnoresRemainingParameters()
{ {
var ambientValues = new DispatcherValueCollection(); var ambientValues = new DispatcherValueCollection();
@ -549,7 +577,8 @@ namespace Microsoft.AspNetCore.Dispatcher
+ "UrlEncode[[Play]]/UrlEncode[[Photos]]/UrlEncode[[1995]]/UrlEncode[[Hola]]"); + "UrlEncode[[Play]]/UrlEncode[[Photos]]/UrlEncode[[1995]]/UrlEncode[[Hola]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithEmptyStringForMiddleParameterShouldUseDefaultValue() public void GetUrlWithEmptyStringForMiddleParameterShouldUseDefaultValue()
{ {
var ambientValues = new DispatcherValueCollection(); var ambientValues = new DispatcherValueCollection();
@ -571,7 +600,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[subtest]]UrlEncode[[.mvc]]/UrlEncode[[Default]]/UrlEncode[[b]]"); "/UrlEncode[[subtest]]UrlEncode[[.mvc]]/UrlEncode[[Default]]/UrlEncode[[b]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlVerifyEncoding() public void GetUrlVerifyEncoding()
{ {
var values = new DispatcherValueCollection(); var values = new DispatcherValueCollection();
@ -590,7 +620,8 @@ namespace Microsoft.AspNetCore.Dispatcher
UrlEncoder.Default); UrlEncoder.Default);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlGeneratesQueryStringForNewValuesAndEscapesQueryString() public void GetUrlGeneratesQueryStringForNewValuesAndEscapesQueryString()
{ {
var values = new DispatcherValueCollection(new { controller = "products", action = "showcategory", id = 123, maxPrice = 100 }); var values = new DispatcherValueCollection(new { controller = "products", action = "showcategory", id = 123, maxPrice = 100 });
@ -605,7 +636,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"?UrlEncode[[so?rt]]=UrlEncode[[de?sc]]&UrlEncode[[maxPrice]]=UrlEncode[[100]]"); "?UrlEncode[[so?rt]]=UrlEncode[[de?sc]]&UrlEncode[[maxPrice]]=UrlEncode[[100]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlGeneratesQueryStringForNewValuesButIgnoresNewValuesThatMatchDefaults() public void GetUrlGeneratesQueryStringForNewValuesButIgnoresNewValuesThatMatchDefaults()
{ {
RunTest( RunTest(
@ -626,7 +658,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"?UrlEncode[[sort]]=UrlEncode[[desc]]&UrlEncode[[maxPrice]]=UrlEncode[[100]]"); "?UrlEncode[[sort]]=UrlEncode[[desc]]&UrlEncode[[maxPrice]]=UrlEncode[[100]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualPathEncodesParametersAndLiterals() public void GetVirtualPathEncodesParametersAndLiterals()
{ {
RunTest( RunTest(
@ -638,7 +671,8 @@ namespace Microsoft.AspNetCore.Dispatcher
UrlEncoder.Default); UrlEncoder.Default);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetVirtualDoesNotEncodeLeadingSlashes() public void GetVirtualDoesNotEncodeLeadingSlashes()
{ {
RunTest( RunTest(
@ -650,7 +684,8 @@ namespace Microsoft.AspNetCore.Dispatcher
UrlEncoder.Default); UrlEncoder.Default);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithLeadingTildeSlash() public void GetUrlWithLeadingTildeSlash()
{ {
RunTest( RunTest(
@ -661,7 +696,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[foo]]"); "/UrlEncode[[foo]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithLeadingSlash() public void GetUrlWithLeadingSlash()
{ {
RunTest( RunTest(
@ -672,7 +708,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[foo]]"); "/UrlEncode[[foo]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithCatchAllWithValue() public void GetUrlWithCatchAllWithValue()
{ {
RunTest( RunTest(
@ -683,7 +720,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[v1]]/UrlEncode[[v2a/v2b]]"); "/UrlEncode[[v1]]/UrlEncode[[v2a/v2b]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithCatchAllWithEmptyValue() public void GetUrlWithCatchAllWithEmptyValue()
{ {
RunTest( RunTest(
@ -694,7 +732,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[v1]]"); "/UrlEncode[[v1]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetUrlWithCatchAllWithNullValue() public void GetUrlWithCatchAllWithNullValue()
{ {
RunTest( RunTest(
@ -705,7 +744,8 @@ namespace Microsoft.AspNetCore.Dispatcher
"/UrlEncode[[v1]]"); "/UrlEncode[[v1]]");
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void RoutePatternBinder_KeepsExplicitlySuppliedRouteValues_OnFailedRouetMatch() public void RoutePatternBinder_KeepsExplicitlySuppliedRouteValues_OnFailedRouetMatch()
{ {
// Arrange // Arrange