From a13aa4de10d49775ef024f49205b4f1250e7108f Mon Sep 17 00:00:00 2001 From: moozzyk Date: Thu, 16 Feb 2017 10:03:29 -0800 Subject: [PATCH] Using webSockets transport as the default transport Fixes: #213 --- src/Microsoft.AspNetCore.Sockets.Client/Connection.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.AspNetCore.Sockets.Client/Connection.cs b/src/Microsoft.AspNetCore.Sockets.Client/Connection.cs index 0a8ee2c873..c0c355044f 100644 --- a/src/Microsoft.AspNetCore.Sockets.Client/Connection.cs +++ b/src/Microsoft.AspNetCore.Sockets.Client/Connection.cs @@ -44,13 +44,12 @@ namespace Microsoft.AspNetCore.Sockets.Client public Task StartAsync() => StartAsync(transport: null, httpClient: null); public Task StartAsync(HttpClient httpClient) => StartAsync(transport: null, httpClient: httpClient); - public Task StartAsync(ITransport transport) => StartAsync(transport, null); + public Task StartAsync(ITransport transport) => StartAsync(transport: transport, httpClient: null); // TODO HIGH: Fix a race when the connection is being stopped/disposed when start has not finished running public async Task StartAsync(ITransport transport, HttpClient httpClient) { - // TODO: make transport optional - _transport = transport ?? throw new ArgumentNullException(nameof(transport)); + _transport = transport ?? new WebSocketsTransport(_loggerFactory); if (Interlocked.CompareExchange(ref _connectionState, ConnectionState.Connecting, ConnectionState.Initial) != ConnectionState.Initial)