huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed the wrote after disconnect log (#1747) 

- It's not very useful
This commit is contained in:
David Fowler 2017-04-24 17:34:56 -07:00 committed by GitHub
parent f26c31c116
commit 9e80fb65bd
4 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Microsoft.AspNetCore.Server.Kestrel.Core/Internal/Http/OutputProducer.cs
View File

@ -51,9 +51,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
{ {
if (_completed) if (_completed)
{ {
// TODO: Get actual notification when the consumer stopped from Pipes,
// so we know if the socket is fully closed and why (for logging exceptions);
_log.ConnectionDisconnectedWrite(_connectionId, buffer.Count, ex: null);
return TaskCache.CompletedTask; return TaskCache.CompletedTask;
} }

2
src/Microsoft.AspNetCore.Server.Kestrel.Core/Internal/Infrastructure/IKestrelTrace.cs
View File

@ -22,8 +22,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure
void RequestProcessingError(string connectionId, Exception ex); void RequestProcessingError(string connectionId, Exception ex);
void ConnectionDisconnectedWrite(string connectionId, int count, Exception ex);
void ConnectionHeadResponseBodyWrite(string connectionId, long count); void ConnectionHeadResponseBodyWrite(string connectionId, long count);
void NotAllConnectionsClosedGracefully(); void NotAllConnectionsClosedGracefully();

8
src/Microsoft.AspNetCore.Server.Kestrel.Core/Internal/Infrastructure/KestrelTrace.cs
View File

@ -33,9 +33,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
private static readonly Action<ILogger, string, string, Exception> _applicationError = private static readonly Action<ILogger, string, string, Exception> _applicationError =
LoggerMessage.Define<string, string>(LogLevel.Error, 13, @"Connection id ""{ConnectionId}"", Request id ""{TraceIdentifier}"": An unhandled exception was thrown by the application."); LoggerMessage.Define<string, string>(LogLevel.Error, 13, @"Connection id ""{ConnectionId}"", Request id ""{TraceIdentifier}"": An unhandled exception was thrown by the application.");
private static readonly Action<ILogger, string, int, Exception> _connectionDisconnectedWrite =
LoggerMessage.Define<string, int>(LogLevel.Debug, 15, @"Connection id ""{ConnectionId}"" write of ""{count}"" bytes to disconnected client.");
private static readonly Action<ILogger, Exception> _notAllConnectionsClosedGracefully = private static readonly Action<ILogger, Exception> _notAllConnectionsClosedGracefully =
LoggerMessage.Define(LogLevel.Debug, 16, "Some connections failed to close gracefully during server shutdown."); LoggerMessage.Define(LogLevel.Debug, 16, "Some connections failed to close gracefully during server shutdown.");
@ -99,11 +96,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
_applicationError(_logger, connectionId, traceIdentifier, ex); _applicationError(_logger, connectionId, traceIdentifier, ex);
} }
public virtual void ConnectionDisconnectedWrite(string connectionId, int count, Exception ex)
{
_connectionDisconnectedWrite(_logger, connectionId, count, ex);
}
public virtual void ConnectionHeadResponseBodyWrite(string connectionId, long count) public virtual void ConnectionHeadResponseBodyWrite(string connectionId, long count)
{ {
_connectionHeadResponseBodyWrite(_logger, connectionId, count, null); _connectionHeadResponseBodyWrite(_logger, connectionId, count, null);

1
test/Microsoft.AspNetCore.Server.Kestrel.Performance/Mocks/MockTrace.cs
View File

@ -14,7 +14,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
public IDisposable BeginScope<TState>(TState state) => null; public IDisposable BeginScope<TState>(TState state) => null;
public void ConnectionBadRequest(string connectionId, BadHttpRequestException ex) { } public void ConnectionBadRequest(string connectionId, BadHttpRequestException ex) { }
public void ConnectionDisconnect(string connectionId) { } public void ConnectionDisconnect(string connectionId) { }
public void ConnectionDisconnectedWrite(string connectionId, int count, Exception ex) { }
public void ConnectionError(string connectionId, Exception ex) { } public void ConnectionError(string connectionId, Exception ex) { }
public void ConnectionHeadResponseBodyWrite(string connectionId, long count) { } public void ConnectionHeadResponseBodyWrite(string connectionId, long count) { }
public void ConnectionKeepAlive(string connectionId) { } public void ConnectionKeepAlive(string connectionId) { }