huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ignitor fixups (#21198) 

* Ignitor fixups

* Do not throw if an ElementReferenceCapture node is encountered.
* Allow configuring the HubConnectionBuilder
* Make useful API public
This commit is contained in:
Pranav K 2020-04-27 13:27:11 -07:00 committed by GitHub
parent b73b2027cc
commit 9cecd089e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Components/Ignitor/src/BlazorClient.cs
View File

@ -333,11 +333,12 @@ namespace Ignitor
return null;
}
public async Task<bool> ConnectAsync(Uri uri, bool connectAutomatically = true)
public async Task<bool> ConnectAsync(Uri uri, bool connectAutomatically = true, Action<HubConnectionBuilder, Uri>? configure = null)
{
var builder = new HubConnectionBuilder();
builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<IHubProtocol, IgnitorMessagePackHubProtocol>());
builder.WithUrl(GetHubUrl(uri));
var hubUrl = GetHubUrl(uri);
builder.WithUrl(hubUrl);
builder.ConfigureLogging(l =>
{
l.SetMinimumLevel(LogLevel.Trace);
@ -347,6 +348,8 @@ namespace Ignitor
}
});
configure?.Invoke(builder, hubUrl);
_hubConnection = builder.Build();
HubConnection.On<int, string>("JS.AttachComponent", OnAttachComponent);

10
src/Components/Ignitor/src/ElementHive.cs
View File

@ -264,8 +264,14 @@ namespace Ignitor
case RenderTreeFrameType.ElementReferenceCapture:
{
// No action for reference captures.
break;
if (parent is ElementNode)
{
return 0; // A "capture" is a child in the diff, but has no node in the DOM
}
else
{
throw new Exception("Reference capture frames can only be children of element frames.");
}
}
case RenderTreeFrameType.Markup:

2
src/Components/Ignitor/src/ElementNode.cs
View File

@ -88,7 +88,7 @@ namespace Ignitor
return DispatchEventCore(connection, Serialize(webEventDescriptor), Serialize(args));
}
internal Task ClickAsync(HubConnection connection)
public Task ClickAsync(HubConnection connection)
{
if (!Events.TryGetValue("click", out var clickEventDescriptor))
{