huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make ResourceManagerStringLocalizer thread safe now instances are cached & shared

This commit is contained in:
damianedwards 2015-12-10 17:49:44 -08:00
parent 8a03857330
commit 9afd2c256b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.cs
View File

@ -3,6 +3,7 @@
using System; using System;
using System.Collections; using System.Collections;
using System.Collections.Concurrent;
using System.Collections.Generic; using System.Collections.Generic;
using System.Globalization; using System.Globalization;
using System.Reflection; using System.Reflection;
@ -15,9 +16,10 @@ namespace Microsoft.Extensions.Localization
/// An <see cref="IStringLocalizer"/> that uses the <see cref="System.Resources.ResourceManager"/> and /// An <see cref="IStringLocalizer"/> that uses the <see cref="System.Resources.ResourceManager"/> and
/// <see cref="System.Resources.ResourceReader"/> to provide localized strings. /// <see cref="System.Resources.ResourceReader"/> to provide localized strings.
/// </summary> /// </summary>
/// <remarks>This type is thread-safe.</remarks>
public class ResourceManagerStringLocalizer : IStringLocalizer public class ResourceManagerStringLocalizer : IStringLocalizer
{ {
private readonly Dictionary<string, object> _missingManifestCache = new Dictionary<string, object>(); private readonly ConcurrentDictionary<string, object> _missingManifestCache = new ConcurrentDictionary<string, object>();
private readonly IResourceNamesCache _resourceNamesCache; private readonly IResourceNamesCache _resourceNamesCache;
private readonly ResourceManager _resourceManager; private readonly ResourceManager _resourceManager;
private readonly AssemblyWrapper _resourceAssemblyWrapper; private readonly AssemblyWrapper _resourceAssemblyWrapper;
@ -185,7 +187,7 @@ namespace Microsoft.Extensions.Localization
} }
catch (MissingManifestResourceException) catch (MissingManifestResourceException)
{ {
_missingManifestCache.Add(cacheKey, null); _missingManifestCache.TryAdd(cacheKey, null);
return null; return null;
} }
} }