From 97e66878a7d3f8566603baf4c9b27e49a83b44da Mon Sep 17 00:00:00 2001 From: Kiran Challa Date: Tue, 11 Aug 2015 14:18:08 -0700 Subject: [PATCH] Reacting to disposable logger provider --- src/Microsoft.AspNet.Diagnostics.Elm/ElmLoggerProvider.cs | 5 +++++ .../DataStoreErrorLoggerProvider.cs | 5 +++++ .../Helpers/TestLoggerProvider.cs | 6 +++++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.AspNet.Diagnostics.Elm/ElmLoggerProvider.cs b/src/Microsoft.AspNet.Diagnostics.Elm/ElmLoggerProvider.cs index 00d7549a14..0b34122a55 100644 --- a/src/Microsoft.AspNet.Diagnostics.Elm/ElmLoggerProvider.cs +++ b/src/Microsoft.AspNet.Diagnostics.Elm/ElmLoggerProvider.cs @@ -1,6 +1,7 @@ // Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. +using System; using Microsoft.Framework.Internal; using Microsoft.Framework.Logging; @@ -21,5 +22,9 @@ namespace Microsoft.AspNet.Diagnostics.Elm { return new ElmLogger(name, _options, _store); } + + public void Dispose() + { + } } } diff --git a/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLoggerProvider.cs b/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLoggerProvider.cs index 78d0e26861..1a432fcc4f 100644 --- a/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLoggerProvider.cs +++ b/src/Microsoft.AspNet.Diagnostics.Entity/DataStoreErrorLoggerProvider.cs @@ -1,6 +1,7 @@ // Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. +using System; using Microsoft.Framework.Logging; namespace Microsoft.AspNet.Diagnostics.Entity @@ -18,5 +19,9 @@ namespace Microsoft.AspNet.Diagnostics.Entity { get { return _logger; } } + + public virtual void Dispose() + { + } } } \ No newline at end of file diff --git a/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs b/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs index 159e075b76..9dad171470 100644 --- a/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs +++ b/test/Microsoft.AspNet.Diagnostics.Entity.FunctionalTests/Helpers/TestLoggerProvider.cs @@ -21,6 +21,10 @@ namespace Microsoft.AspNet.Diagnostics.Entity.FunctionalTests.Helpers return _logger; } + public void Dispose() + { + } + public class TestLogger : ILogger { private List _messages = new List(); @@ -34,7 +38,7 @@ namespace Microsoft.AspNet.Diagnostics.Entity.FunctionalTests.Helpers { _messages.Add(formatter(state, exception)); } - + public bool IsEnabled(LogLevel logLevel) { return true;