From 118fc0a27ff5ea332ae5f765981b0a55bd5820d5 Mon Sep 17 00:00:00 2001
From: Nate McMaster <natemcmaster@users.noreply.github.com>
Date: Fri, 24 Aug 2018 10:02:53 -0700
Subject: [PATCH] Fail CI builds if the JDK cannot be found, warn for local
 builds, and add a flag to completely skip building the Java client

---
 build/buildpipeline/windows-es.groovy |  2 +-
 build/buildpipeline/windows.groovy    |  2 +-
 build/repo.targets                    | 22 +++++++++++++++-------
 3 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/build/buildpipeline/windows-es.groovy b/build/buildpipeline/windows-es.groovy
index 9fccc2fc0f..f1f0c1043d 100644
--- a/build/buildpipeline/windows-es.groovy
+++ b/build/buildpipeline/windows-es.groovy
@@ -9,6 +9,6 @@ simpleNode('Windows.10.Amd64.ClientRS4.ES.Open') {
     stage ('Build') {
         def logFolder = getLogFolder()
         def environment = "set ASPNETCORE_TEST_LOG_DIR=${WORKSPACE}\\${logFolder}"
-        bat "${environment}&.\\run.cmd -CI default-build"
+        bat "${environment}&.\\build.cmd -ci /p:SkipJavaClient=true"
     }
 }
diff --git a/build/buildpipeline/windows.groovy b/build/buildpipeline/windows.groovy
index c1fcbd36e0..3235d6530f 100644
--- a/build/buildpipeline/windows.groovy
+++ b/build/buildpipeline/windows.groovy
@@ -9,6 +9,6 @@ simpleNode('Windows.10.Amd64.EnterpriseRS3.ASPNET.Open') {
     stage ('Build') {
         def logFolder = getLogFolder()
         def environment = "set ASPNETCORE_TEST_LOG_DIR=${WORKSPACE}\\${logFolder}"
-        bat "${environment}&.\\run.cmd -CI default-build"
+        bat "${environment}&.\\build.cmd -ci /p:SkipJavaClient=true"
     }
 }
diff --git a/build/repo.targets b/build/repo.targets
index 075b60d384..85e3b13e5a 100644
--- a/build/repo.targets
+++ b/build/repo.targets
@@ -23,6 +23,16 @@
     <GradleOptions Condition="'$(CI)' == 'true'">$(GradleOptions) -Dorg.gradle.daemon=false</GradleOptions>
   </PropertyGroup>
 
+  <Target Name="EnsureJdkInstalled" BeforeTargets="GetToolsets" Condition=" '$(SkipJavaClient)' != 'true' ">
+    <Error Text="The JDK is required to build the SignalR repo on CI. Set the JAVA_HOME environment variable to the installation of the JDK"
+            Condition="'$(HasJdk)' != 'true' AND '$(CI)' == 'true' " />
+    
+    <Warning Text="The JDK is required to build the SignalR Java client. No JDK could be found so this will be skipped. Set the JAVA_HOME environment variable to the installation of the JDK"
+        Condition="'$(HasJdk)' != 'true' AND '$(CI)' != 'true' " />
+
+    <Message Text="Using Java from $(JavacPath)" Importance="high" />
+  </Target>
+
   <PropertyGroup>
     <RestoreDependsOn>$(RestoreDependsOn);RestoreNpm</RestoreDependsOn>
   </PropertyGroup>
@@ -48,7 +58,7 @@
     <Exec Command="npm run test:inner -- --no-color --configuration $(Configuration)" WorkingDirectory="$(RepositoryRoot)clients/ts/FunctionalTests" IgnoreStandardErrorWarningFormat="true" />
   </Target>
 
-  <Target Name="RunJavaTests" Condition="'$(HasJdk)' == 'true'">
+  <Target Name="RunJavaTests" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
     <Message Text="Running Java client tests" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) test" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) test" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" IgnoreStandardErrorWarningFormat="true" />
@@ -80,8 +90,8 @@
     </ItemGroup>
   </Target>
 
-  <Target Name="GetJavaArtifactInfo" Condition="'$(HasJdk)' == 'true'">
-    <ItemGroup>
+  <Target Name="GetJavaArtifactInfo">
+    <ItemGroup Condition=" '$(SkipJavaClient)' != 'true' ">
       <ArtifactInfo Include="$(BuildDir)\%(Jars.Identity)">
         <ArtifactType>JavaJar</ArtifactType>
         <Version>$(JavaClientVersion)</Version>
@@ -92,9 +102,7 @@
         <Version>$(JavaClientVersion)</Version>
         <Category>ship</Category>
       </ArtifactInfo>
-    </ItemGroup>
 
-    <ItemGroup>
       <FilesToExcludeFromSigning Include="$(BuildDir)\%(Jars.Identity)" />
       <FilesToExcludeFromSigning Include="$(BuildDir)\%(PomFile.Identity)" />
     </ItemGroup>
@@ -110,7 +118,7 @@
     <Exec Command="npm run build" WorkingDirectory="$(RepositoryRoot)clients/ts/FunctionalTests" IgnoreStandardErrorWarningFormat="true" />
   </Target>
 
-  <Target Name="BuildJavaClient" Condition="'$(HasJdk)' == 'true'" DependsOnTargets="GetJavaArtifactInfo">
+  <Target Name="BuildJavaClient" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' " DependsOnTargets="GetJavaArtifactInfo">
     <Message Text="Building Java client" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) compileJava" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) compileJava" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" />
@@ -135,7 +143,7 @@
     <JavaBuildFiles Include="@(Jars);@(PomFile)"/>
   </ItemGroup>
 
-  <Target Name="PackJavaClient" Condition="'$(HasJdk)' == 'true'">
+  <Target Name="PackJavaClient" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
     <Message Text="Packing Java client" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) createPackage" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) createPackage" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" />