From 979107493e60da2796df454cba287bc8308184f3 Mon Sep 17 00:00:00 2001 From: AndriySvyryd Date: Wed, 26 Apr 2017 16:08:32 -0700 Subject: [PATCH] Treat all SQL exceptions the same in DatabaseErrorPageMiddlewareTest Fixes #366 --- .../DatabaseErrorPageMiddlewareTest.cs | 24 ++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/test/Diagnostics.EFCore.FunctionalTests/DatabaseErrorPageMiddlewareTest.cs b/test/Diagnostics.EFCore.FunctionalTests/DatabaseErrorPageMiddlewareTest.cs index 69e4f7463d..a68091686d 100644 --- a/test/Diagnostics.EFCore.FunctionalTests/DatabaseErrorPageMiddlewareTest.cs +++ b/test/Diagnostics.EFCore.FunctionalTests/DatabaseErrorPageMiddlewareTest.cs @@ -322,7 +322,16 @@ namespace Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests var server = new TestServer(builder); var ex = await Assert.ThrowsAsync(async () => - await server.CreateClient().GetAsync("http://localhost/")); + { + try + { + await server.CreateClient().GetAsync("http://localhost/"); + } + catch (InvalidOperationException exception) when (exception.InnerException != null) + { + throw exception.InnerException; + } + }); Assert.True(logProvider.Logger.Messages.Any(m => m.StartsWith(StringsHelpers.GetResourceString("FormatDatabaseErrorPageMiddleware_ContextNotRegistered", typeof(BloggingContext))))); @@ -368,7 +377,16 @@ namespace Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests var server = SetupTestServer(database, logProvider); var ex = await Assert.ThrowsAsync(async () => - await server.CreateClient().GetAsync("http://localhost/")); + { + try + { + await server.CreateClient().GetAsync("http://localhost/"); + } + catch (InvalidOperationException exception) when (exception.InnerException != null) + { + throw exception.InnerException; + } + }); Assert.True(logProvider.Logger.Messages.ToList().Any(m => m.StartsWith(StringsHelpers.GetResourceString("FormatDatabaseErrorPageMiddleware_Exception")))); @@ -448,7 +466,7 @@ namespace Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests { if (!PlatformHelper.IsMono) { - optionsBuilder.UseSqlServer(database.ConnectionString); + optionsBuilder.UseSqlServer(database.ConnectionString, b => b.CommandTimeout(600)); } else {