Addressed code review comments.
This commit is contained in:
parent
94553703a2
commit
951a1d0879
|
|
@ -41,7 +41,7 @@ namespace Microsoft.AspNet.Mvc.Razor
|
||||||
// CodeGenerationContext.DefaultBaseClass is set to MyBaseType<dynamic>.
|
// CodeGenerationContext.DefaultBaseClass is set to MyBaseType<dynamic>.
|
||||||
// This field holds the type name without the generic decoration (MyBaseType)
|
// This field holds the type name without the generic decoration (MyBaseType)
|
||||||
private readonly string _baseType;
|
private readonly string _baseType;
|
||||||
private readonly IChunkTreeCache _ChunkTreeCache;
|
private readonly IChunkTreeCache _chunkTreeCache;
|
||||||
private readonly RazorPathNormalizer _pathNormalizer;
|
private readonly RazorPathNormalizer _pathNormalizer;
|
||||||
private ChunkInheritanceUtility _chunkInheritanceUtility;
|
private ChunkInheritanceUtility _chunkInheritanceUtility;
|
||||||
|
|
||||||
|
|
@ -50,7 +50,7 @@ namespace Microsoft.AspNet.Mvc.Razor
|
||||||
{
|
{
|
||||||
_pathNormalizer = pathNormalizer;
|
_pathNormalizer = pathNormalizer;
|
||||||
_baseType = BaseType;
|
_baseType = BaseType;
|
||||||
_ChunkTreeCache = ChunkTreeCache;
|
_chunkTreeCache = ChunkTreeCache;
|
||||||
|
|
||||||
TagHelperDescriptorResolver = new TagHelperDescriptorResolver();
|
TagHelperDescriptorResolver = new TagHelperDescriptorResolver();
|
||||||
DefaultBaseClass = BaseType + "<" + DefaultModel + ">";
|
DefaultBaseClass = BaseType + "<" + DefaultModel + ">";
|
||||||
|
|
@ -188,7 +188,7 @@ namespace Microsoft.AspNet.Mvc.Razor
|
||||||
if (_chunkInheritanceUtility == null)
|
if (_chunkInheritanceUtility == null)
|
||||||
{
|
{
|
||||||
// This needs to be lazily evaluated to support DefaultInheritedChunks being virtual.
|
// This needs to be lazily evaluated to support DefaultInheritedChunks being virtual.
|
||||||
_chunkInheritanceUtility = new ChunkInheritanceUtility(this, _ChunkTreeCache, DefaultInheritedChunks);
|
_chunkInheritanceUtility = new ChunkInheritanceUtility(this, _chunkTreeCache, DefaultInheritedChunks);
|
||||||
}
|
}
|
||||||
|
|
||||||
return _chunkInheritanceUtility;
|
return _chunkInheritanceUtility;
|
||||||
|
|
|
||||||
|
|
@ -32,7 +32,7 @@ namespace Microsoft.AspNet.Mvc.Razor
|
||||||
public override void RenderAttributeValue(
|
public override void RenderAttributeValue(
|
||||||
[NotNull] TagHelperAttributeDescriptor attributeDescriptor,
|
[NotNull] TagHelperAttributeDescriptor attributeDescriptor,
|
||||||
[NotNull] CSharpCodeWriter writer,
|
[NotNull] CSharpCodeWriter writer,
|
||||||
[NotNull] CodeGeneratorContext CodeGeneratorContext,
|
[NotNull] CodeGeneratorContext codeGeneratorContext,
|
||||||
[NotNull] Action<CSharpCodeWriter> renderAttributeValue,
|
[NotNull] Action<CSharpCodeWriter> renderAttributeValue,
|
||||||
bool complexValue)
|
bool complexValue)
|
||||||
{
|
{
|
||||||
|
|
@ -59,7 +59,7 @@ namespace Microsoft.AspNet.Mvc.Razor
|
||||||
base.RenderAttributeValue(
|
base.RenderAttributeValue(
|
||||||
attributeDescriptor,
|
attributeDescriptor,
|
||||||
writer,
|
writer,
|
||||||
CodeGeneratorContext,
|
codeGeneratorContext,
|
||||||
renderAttributeValue,
|
renderAttributeValue,
|
||||||
complexValue);
|
complexValue);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue