huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add OSX Jenkins 

Fix couple node warnings
This commit is contained in:
BrennanConroy 2018-06-18 09:17:15 -07:00 committed by GitHub
parent 5b22616a63
commit 94d4f9d2fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
build/buildpipeline/osx.groovy
View File

@ -1,2 +1,14 @@
@Library('dotnet-ci') _ @Library('dotnet-ci') _
// 'node' indicates to Jenkins that the enclosed block runs on a node that matches
// the label 'windows-with-vs'
simpleNode('OSX.1012.Amd64.Open') {
stage ('Checking out source') {
checkout scm
}
stage ('Build') {
def logFolder = getLogFolder()
def environment = "export ASPNETCORE_TEST_LOG_DIR=${WORKSPACE}/${logFolder}"
sh "${environment}&./build.sh -ci"
}
}

2
clients/ts/signalr-protocol-msgpack/src/MessagePackHubProtocol.ts
View File

@ -79,7 +79,7 @@ export class MessagePackHubProtocol implements IHubProtocol {
} }
const msgpack = msgpack5(); const msgpack = msgpack5();
const properties = msgpack.decode(new Buffer(input)); const properties = msgpack.decode(Buffer.from(input));
if (properties.length === 0 || !(properties instanceof Array)) { if (properties.length === 0 || !(properties instanceof Array)) {
throw new Error("Invalid payload."); throw new Error("Invalid payload.");
} }

7
clients/ts/signalr/tests/WebSocketTransport.test.ts
View File

@ -6,7 +6,7 @@ import { TransferFormat } from "../src/ITransport";
import { WebSocketTransport } from "../src/WebSocketTransport"; import { WebSocketTransport } from "../src/WebSocketTransport";
import { VerifyLogger } from "./Common"; import { VerifyLogger } from "./Common";
import { TestMessageEvent } from "./TestEventSource"; import { TestMessageEvent } from "./TestEventSource";
import { TestCloseEvent, TestEvent, TestWebSocket } from "./TestWebSocket"; import { TestCloseEvent, TestErrorEvent, TestEvent, TestWebSocket } from "./TestWebSocket";
describe("WebSocketTransport", () => { describe("WebSocketTransport", () => {
it("sets websocket binarytype to arraybuffer on Binary transferformat", async () => { it("sets websocket binarytype to arraybuffer on Binary transferformat", async () => {
@ -40,7 +40,7 @@ describe("WebSocketTransport", () => {
it("connect fails if there is error during connect", async () => { it("connect fails if there is error during connect", async () => {
await VerifyLogger.run(async (logger) => { await VerifyLogger.run(async (logger) => {
(global as any).ErrorEvent = TestEvent; (global as any).ErrorEvent = TestErrorEvent;
const webSocket = new WebSocketTransport(undefined, logger, true, TestWebSocket); const webSocket = new WebSocketTransport(undefined, logger, true, TestWebSocket);
let connectComplete: boolean = false; let connectComplete: boolean = false;
@ -56,7 +56,8 @@ describe("WebSocketTransport", () => {
TestWebSocket.webSocket.onerror(new TestEvent()); TestWebSocket.webSocket.onerror(new TestEvent());
await expect(connectPromise) await expect(connectPromise)
.rejects; .rejects
.toBeNull();
expect(connectComplete).toBe(false); expect(connectComplete).toBe(false);
}); });
}); });