From 4841d5f019315667730bfb5f489e78cded47fb7c Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Wed, 31 Jul 2019 13:50:06 +1200 Subject: [PATCH 1/3] Update gRPC template dependency for preview 8 and link to macOS docs --- eng/Versions.props | 2 +- .../Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index 97a08b7c56..8d3d966843 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -221,7 +221,7 @@ 4.2.1 4.2.1 3.8.0 - 0.1.22-pre2 + 0.1.22-pre3 3.0.0-preview3.4 3.0.0-preview3.4 3.0.0-preview3.4 diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs index 94905231a0..a80016b101 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs @@ -15,6 +15,8 @@ namespace GrpcService_CSharp CreateHostBuilder(args).Build().Run(); } + // Additional configuration is required to successfully run gRPC on macOS. + // For instructions on how to configure Kestrel and gRPC clients to run on macOS, visit https://go.microsoft.com/fwlink/?linkid=2099682 public static IHostBuilder CreateHostBuilder(string[] args) => Host.CreateDefaultBuilder(args) .ConfigureWebHostDefaults(webBuilder => From 10b9c338f251cbf8937dca36c8d57adef00b391d Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Wed, 31 Jul 2019 13:57:16 +1200 Subject: [PATCH 2/3] Clean up --- .../Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs index a80016b101..7ffd7a12f5 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs @@ -16,7 +16,7 @@ namespace GrpcService_CSharp } // Additional configuration is required to successfully run gRPC on macOS. - // For instructions on how to configure Kestrel and gRPC clients to run on macOS, visit https://go.microsoft.com/fwlink/?linkid=2099682 + // For instructions on how to configure Kestrel and gRPC clients for macOS, visit https://go.microsoft.com/fwlink/?linkid=2099682 public static IHostBuilder CreateHostBuilder(string[] args) => Host.CreateDefaultBuilder(args) .ConfigureWebHostDefaults(webBuilder => From ccfa7f13eaab15e8ae98dc816f4a2f1280c43364 Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Wed, 31 Jul 2019 13:58:18 +1200 Subject: [PATCH 3/3] Clean up --- .../Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs index 7ffd7a12f5..d1f9df7226 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Program.cs @@ -16,7 +16,7 @@ namespace GrpcService_CSharp } // Additional configuration is required to successfully run gRPC on macOS. - // For instructions on how to configure Kestrel and gRPC clients for macOS, visit https://go.microsoft.com/fwlink/?linkid=2099682 + // For instructions on how to configure Kestrel and gRPC clients on macOS, visit https://go.microsoft.com/fwlink/?linkid=2099682 public static IHostBuilder CreateHostBuilder(string[] args) => Host.CreateDefaultBuilder(args) .ConfigureWebHostDefaults(webBuilder =>