diff --git a/src/Microsoft.AspNetCore.Blazor.Build/Core/RazorCompilation/Engine/BlazorIntermediateNodeWriter.cs b/src/Microsoft.AspNetCore.Blazor.Build/Core/RazorCompilation/Engine/BlazorIntermediateNodeWriter.cs index cc62d7e05f..6db55d6e3b 100644 --- a/src/Microsoft.AspNetCore.Blazor.Build/Core/RazorCompilation/Engine/BlazorIntermediateNodeWriter.cs +++ b/src/Microsoft.AspNetCore.Blazor.Build/Core/RazorCompilation/Engine/BlazorIntermediateNodeWriter.cs @@ -228,7 +228,7 @@ namespace Microsoft.AspNetCore.Blazor.Build.Core.RazorCompilation.Engine if (TryGetComponentTypeNameFromTagName(tagNameOriginalCase, out var componentTypeName)) { codeWriter - .WriteStartMethodInvocation($"{builderVarName}.{nameof(RenderTreeBuilder.OpenComponentElement)}<{componentTypeName}>") + .WriteStartMethodInvocation($"{builderVarName}.{nameof(RenderTreeBuilder.OpenComponent)}<{componentTypeName}>") .Write((_sourceSequence++).ToString()) .WriteEndMethodInvocation(); isComponent = true; diff --git a/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs b/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs index e2200d23ad..2b428de6a7 100644 --- a/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs +++ b/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs @@ -54,7 +54,7 @@ namespace Microsoft.AspNetCore.Blazor.RenderTree /// /// Marks a previously appended component frame as closed. Calls to this method - /// must be balanced with calls to . + /// must be balanced with calls to . /// public void CloseComponent() { @@ -153,7 +153,7 @@ namespace Microsoft.AspNetCore.Blazor.RenderTree /// /// The type of the child component. /// An integer that represents the position of the instruction in the source code. - public void OpenComponentElement(int sequence) where TComponent : IComponent + public void OpenComponent(int sequence) where TComponent : IComponent { // Currently, child components can't have further grandchildren of their own, so it would // technically be possible to skip their CloseElement calls and not track them in _openElementIndices. diff --git a/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeBuilderTest.cs b/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeBuilderTest.cs index 38fb9192fa..8cf97b9389 100644 --- a/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeBuilderTest.cs +++ b/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeBuilderTest.cs @@ -253,11 +253,11 @@ namespace Microsoft.AspNetCore.Blazor.Test // Act builder.OpenElement(10, "parent"); // 0: - builder.OpenComponentElement(11); // 1: (11); // 1: builder.CloseComponent(); // - builder.OpenComponentElement(14); // 4: (14); // 4: builder.CloseComponent(); // builder.CloseElement(); // diff --git a/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeDiffComputerTest.cs b/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeDiffComputerTest.cs index dc4b6c3152..033f6c4513 100644 --- a/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeDiffComputerTest.cs +++ b/test/Microsoft.AspNetCore.Blazor.Test/RenderTreeDiffComputerTest.cs @@ -53,7 +53,7 @@ namespace Microsoft.AspNetCore.Blazor.Test builder.AddAttribute(1, "My attribute", "My value"); builder.CloseElement(); }, - builder => builder.OpenComponentElement(0) + builder => builder.OpenComponent(0) }.Select(x => new object[] { x }); [Fact] @@ -312,8 +312,8 @@ namespace Microsoft.AspNetCore.Blazor.Test public void RecognizesComponentTypeChangesAtSameSequenceNumber() { // Arrange - oldTree.OpenComponentElement(123); - newTree.OpenComponentElement(123); + oldTree.OpenComponent(123); + newTree.OpenComponent(123); // Act var renderBatch = GetRenderedBatch(); @@ -585,9 +585,9 @@ namespace Microsoft.AspNetCore.Blazor.Test oldTree.CloseElement(); // newTree.AddText(10, "text1"); // 0: text1 newTree.OpenElement(11, "container"); // 1: - newTree.OpenComponentElement(12); // 2: + newTree.OpenComponent(12); // 2: newTree.CloseComponent(); // - newTree.OpenComponentElement(13); // 3: + newTree.OpenComponent(13); // 3: newTree.CloseComponent(); // newTree.CloseElement(); // @@ -641,7 +641,7 @@ namespace Microsoft.AspNetCore.Blazor.Test { // Arrange var testObject = new object(); - newTree.OpenComponentElement(0); + newTree.OpenComponent(0); newTree.AddAttribute(1, nameof(FakeComponent.IntProperty), 123); newTree.AddAttribute(2, nameof(FakeComponent.StringProperty), "some string"); newTree.AddAttribute(3, nameof(FakeComponent.ObjectProperty), testObject); @@ -667,7 +667,7 @@ namespace Microsoft.AspNetCore.Blazor.Test { // Arrange var testObject = new object(); - newTree.OpenComponentElement(0); + newTree.OpenComponent(0); newTree.AddAttribute(1, "SomeUnknownProperty", 123); newTree.CloseComponent(); @@ -684,7 +684,7 @@ namespace Microsoft.AspNetCore.Blazor.Test { // Arrange var testObject = new object(); - newTree.OpenComponentElement(0); + newTree.OpenComponent(0); newTree.AddAttribute(1, nameof(FakeComponent.ReadonlyProperty), 123); newTree.CloseComponent(); @@ -703,16 +703,16 @@ namespace Microsoft.AspNetCore.Blazor.Test // Arrange oldTree.AddText(10, "text1"); // 0: text1 oldTree.OpenElement(11, "container"); // 1: - oldTree.OpenComponentElement(12); // 2: + oldTree.OpenComponent(12); // 2: oldTree.CloseComponent(); // - oldTree.OpenComponentElement(13); // 3: + oldTree.OpenComponent(13); // 3: oldTree.CloseComponent(); // oldTree.CloseElement(); // newTree.AddText(10, "text1"); // 0: text1 newTree.OpenElement(11, "container"); // 1: - newTree.OpenComponentElement(12); // 2: + newTree.OpenComponent(12); // 2: newTree.CloseComponent(); // - newTree.OpenComponentElement(13); // 3: + newTree.OpenComponent(13); // 3: newTree.CloseComponent(); // newTree.CloseElement(); // (12); + oldTree.OpenComponent(12); oldTree.AddAttribute(13, nameof(FakeComponent.StringProperty), "String will change"); oldTree.AddAttribute(14, nameof(FakeComponent.ObjectProperty), objectWillNotChange); oldTree.CloseComponent(); - newTree.OpenComponentElement(12); + newTree.OpenComponent(12); newTree.AddAttribute(13, nameof(FakeComponent.StringProperty), "String did change"); newTree.AddAttribute(14, nameof(FakeComponent.ObjectProperty), objectWillNotChange); newTree.CloseComponent(); @@ -766,7 +766,7 @@ namespace Microsoft.AspNetCore.Blazor.Test public void NotifiesIHandlePropertiesChangedBeforeFirstRender() { // Arrange - newTree.OpenComponentElement(0); + newTree.OpenComponent(0); newTree.CloseComponent(); // Act @@ -784,13 +784,13 @@ namespace Microsoft.AspNetCore.Blazor.Test // Arrange var newTree1 = new RenderTreeBuilder(renderer); var newTree2 = new RenderTreeBuilder(renderer); - oldTree.OpenComponentElement(0); + oldTree.OpenComponent(0); oldTree.AddAttribute(1, nameof(HandlePropertiesChangedComponent.IntProperty), 123); oldTree.CloseComponent(); - newTree1.OpenComponentElement(0); + newTree1.OpenComponent(0); newTree1.AddAttribute(1, nameof(HandlePropertiesChangedComponent.IntProperty), 123); newTree1.CloseComponent(); - newTree2.OpenComponentElement(0); + newTree2.OpenComponent(0); newTree2.AddAttribute(1, nameof(HandlePropertiesChangedComponent.IntProperty), 456); newTree2.CloseComponent(); @@ -819,14 +819,14 @@ namespace Microsoft.AspNetCore.Blazor.Test public void CallsDisposeOnlyOnRemovedChildComponents() { // Arrange - oldTree.OpenComponentElement(10); // - oldTree.CloseComponent(); // - oldTree.OpenComponentElement(20); // - oldTree.CloseComponent(); // - oldTree.OpenComponentElement(30); // - oldTree.CloseComponent(); // - newTree.OpenComponentElement(30); // - newTree.CloseComponent(); // + oldTree.OpenComponent(10); // + oldTree.CloseComponent(); // + oldTree.OpenComponent(20); // + oldTree.CloseComponent(); // + oldTree.OpenComponent(30); // + oldTree.CloseComponent(); // + newTree.OpenComponent(30); // + newTree.CloseComponent(); // diff.ApplyNewRenderTreeVersion(new RenderBatchBuilder(), 0, new RenderTreeBuilder(renderer).GetFrames(), oldTree.GetFrames()); var disposableComponent1 = (DisposableComponent)oldTree.GetFrames().Array[0].Component; diff --git a/test/Microsoft.AspNetCore.Blazor.Test/RendererTest.cs b/test/Microsoft.AspNetCore.Blazor.Test/RendererTest.cs index 4f97cf9306..7b27b7b289 100644 --- a/test/Microsoft.AspNetCore.Blazor.Test/RendererTest.cs +++ b/test/Microsoft.AspNetCore.Blazor.Test/RendererTest.cs @@ -44,7 +44,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var component = new TestComponent(builder => { builder.AddText(0, "Hello"); - builder.OpenComponentElement(1); + builder.OpenComponent(1); builder.AddAttribute(2, nameof(MessageComponent.Message), "Nested component output"); builder.CloseComponent(); }); @@ -91,7 +91,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var renderer = new TestRenderer(); var parentComponent = new TestComponent(builder => { - builder.OpenComponentElement(0); + builder.OpenComponent(0); builder.CloseComponent(); }); var parentComponentId = renderer.AssignComponentId(parentComponent); @@ -150,7 +150,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var renderer = new TestRenderer(); var parentComponent = new TestComponent(builder => { - builder.OpenComponentElement(0); + builder.OpenComponent(0); builder.CloseComponent(); }); var parentComponentId = renderer.AssignComponentId(parentComponent); @@ -306,7 +306,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var component = new TestComponent(builder => { builder.AddText(0, message); - builder.OpenComponentElement(1); + builder.OpenComponent(1); builder.CloseComponent(); }); @@ -336,7 +336,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var firstRender = true; var component = new TestComponent(builder => { - builder.OpenComponentElement(1); + builder.OpenComponent(1); builder.AddAttribute(2, nameof(FakeComponent.IntProperty), firstRender ? 123 : 256); builder.AddAttribute(3, nameof(FakeComponent.ObjectProperty), objectThatWillNotChange); builder.AddAttribute(4, nameof(FakeComponent.StringProperty), firstRender ? "String that will change" : "String that did change"); @@ -378,7 +378,7 @@ namespace Microsoft.AspNetCore.Blazor.Test var firstRender = true; var component = new TestComponent(builder => { - builder.OpenComponentElement(1); + builder.OpenComponent(1); builder.AddAttribute(2, nameof(MessageComponent.Message), firstRender ? "first" : "second"); builder.CloseComponent(); }); @@ -413,12 +413,12 @@ namespace Microsoft.AspNetCore.Blazor.Test builder.OpenElement(7, "some element"); if (firstRender) { - builder.OpenComponentElement(100); + builder.OpenComponent(100); builder.CloseComponent(); - builder.OpenComponentElement(150); + builder.OpenComponent(150); builder.CloseComponent(); } - builder.OpenComponentElement(200); + builder.OpenComponent(200); builder.CloseComponent(); builder.CloseElement(); });