huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add safe copy for enumeration (#1052)

This commit is contained in:
Hao Kung 2018-10-24 15:10:19 -07:00 committed by GitHub
parent 19908d91c7
commit 91db78cf92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Microsoft.AspNetCore.Authentication.Core/AuthenticationSchemeProvider.cs
View File

@ -3,6 +3,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Options; using Microsoft.Extensions.Options;
@ -49,6 +50,9 @@ namespace Microsoft.AspNetCore.Authentication
private readonly IDictionary<string, AuthenticationScheme> _schemes; private readonly IDictionary<string, AuthenticationScheme> _schemes;
private readonly List<AuthenticationScheme> _requestHandlers; private readonly List<AuthenticationScheme> _requestHandlers;
// Used as a safe return value for enumeration apis
private IEnumerable<AuthenticationScheme> _schemesCopy = Array.Empty<AuthenticationScheme>();
private IEnumerable<AuthenticationScheme> _requestHandlersCopy = Array.Empty<AuthenticationScheme>();
private Task<AuthenticationScheme> GetDefaultSchemeAsync() private Task<AuthenticationScheme> GetDefaultSchemeAsync()
=> _options.DefaultScheme != null => _options.DefaultScheme != null
@ -123,7 +127,7 @@ namespace Microsoft.AspNetCore.Authentication
/// </summary> /// </summary>
/// <returns>The schemes in priority order for request handling</returns> /// <returns>The schemes in priority order for request handling</returns>
public virtual Task<IEnumerable<AuthenticationScheme>> GetRequestHandlerSchemesAsync() public virtual Task<IEnumerable<AuthenticationScheme>> GetRequestHandlerSchemesAsync()
=> Task.FromResult<IEnumerable<AuthenticationScheme>>(_requestHandlers); => Task.FromResult(_requestHandlersCopy);
/// <summary> /// <summary>
/// Registers a scheme for use by <see cref="IAuthenticationService"/>. /// Registers a scheme for use by <see cref="IAuthenticationService"/>.
@ -144,8 +148,10 @@ namespace Microsoft.AspNetCore.Authentication
if (typeof(IAuthenticationRequestHandler).IsAssignableFrom(scheme.HandlerType)) if (typeof(IAuthenticationRequestHandler).IsAssignableFrom(scheme.HandlerType))
{ {
_requestHandlers.Add(scheme); _requestHandlers.Add(scheme);
_requestHandlersCopy = _requestHandlers.ToArray();
} }
_schemes[scheme.Name] = scheme; _schemes[scheme.Name] = scheme;
_schemesCopy = _schemes.Values.ToArray();
} }
} }
@ -164,13 +170,17 @@ namespace Microsoft.AspNetCore.Authentication
if (_schemes.ContainsKey(name)) if (_schemes.ContainsKey(name))
{ {
var scheme = _schemes[name]; var scheme = _schemes[name];
_requestHandlers.Remove(scheme); if (_requestHandlers.Remove(scheme))
{
_requestHandlersCopy = _requestHandlers.ToArray();
}
_schemes.Remove(name); _schemes.Remove(name);
_schemesCopy = _schemes.Values.ToArray();
} }
} }
} }
public virtual Task<IEnumerable<AuthenticationScheme>> GetAllSchemesAsync() public virtual Task<IEnumerable<AuthenticationScheme>> GetAllSchemesAsync()
=> Task.FromResult<IEnumerable<AuthenticationScheme>>(_schemes.Values); => Task.FromResult(_schemesCopy);
} }
} }