diff --git a/eng/Workarounds.props b/eng/Workarounds.props index 882180e93f..3bcf633f86 100644 --- a/eng/Workarounds.props +++ b/eng/Workarounds.props @@ -12,9 +12,4 @@ <_ProjectExtensionsWereImported>true $(WixInstallPath)\wix2010.targets - - - - 14.16.27023 - diff --git a/eng/scripts/vs.buildtools.json b/eng/scripts/vs.buildtools.json index c487303d41..173ce44d40 100644 --- a/eng/scripts/vs.buildtools.json +++ b/eng/scripts/vs.buildtools.json @@ -17,8 +17,6 @@ "Microsoft.VisualStudio.Component.NuGet.BuildTools", "Microsoft.VisualStudio.Component.VC.ATL", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", - "Microsoft.VisualStudio.Component.VC.v141.ATL", - "Microsoft.VisualStudio.Component.VC.v141.x86.x64", "Microsoft.VisualStudio.Component.Windows10SDK.17134", "Microsoft.VisualStudio.Workload.ManagedDesktopBuildTools", "Microsoft.VisualStudio.Workload.MSBuildTools", diff --git a/eng/scripts/vs.json b/eng/scripts/vs.json index c0596cbf3c..d5aff9345a 100644 --- a/eng/scripts/vs.json +++ b/eng/scripts/vs.json @@ -15,8 +15,6 @@ "Microsoft.VisualStudio.Component.Azure.Storage.Emulator", "Microsoft.VisualStudio.Component.VC.ATL", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", - "Microsoft.VisualStudio.Component.VC.v141.ATL", - "Microsoft.VisualStudio.Component.VC.v141.x86.x64", "Microsoft.VisualStudio.Component.Windows10SDK.17134", "Microsoft.VisualStudio.Workload.ManagedDesktop", "Microsoft.VisualStudio.Workload.NativeDesktop", diff --git a/korebuild.json b/korebuild.json index 1618e0e746..e189d4b1de 100644 --- a/korebuild.json +++ b/korebuild.json @@ -16,8 +16,6 @@ "requiredWorkloads": [ "Microsoft.VisualStudio.Component.VC.ATL", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", - "Microsoft.VisualStudio.Component.VC.v141.ATL", - "Microsoft.VisualStudio.Component.VC.v141.x86.x64", "Microsoft.VisualStudio.Component.Windows10SDK.17134" ] } diff --git a/src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj b/src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj index a900f6d5e0..fc7b1609b7 100644 --- a/src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj +++ b/src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj @@ -42,7 +42,7 @@ DynamicLibrary - v141 + v142 Unicode diff --git a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/lib/IISSetup.CommonLib.vcxproj b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/lib/IISSetup.CommonLib.vcxproj index 92295eb9db..bc5eb5365c 100644 --- a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/lib/IISSetup.CommonLib.vcxproj +++ b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/lib/IISSetup.CommonLib.vcxproj @@ -31,7 +31,7 @@ StaticLibrary - v141 + v142 false diff --git a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/reftrace/reftrace.vcxproj b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/reftrace/reftrace.vcxproj index 257df53c47..8d1093181d 100644 --- a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/reftrace/reftrace.vcxproj +++ b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/IIS-Common/reftrace/reftrace.vcxproj @@ -47,7 +47,7 @@ StaticLibrary - v141 + v142 true diff --git a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/iisca.vcxproj b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/iisca.vcxproj index f823e017c8..1f694316af 100644 --- a/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/iisca.vcxproj +++ b/src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/iisca.vcxproj @@ -74,7 +74,7 @@ StaticLibrary Unicode - v141 + v142 diff --git a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/CommonLib.vcxproj b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/CommonLib.vcxproj index 5d9726d821..626abc70e4 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/CommonLib.vcxproj +++ b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/CommonLib.vcxproj @@ -246,7 +246,6 @@ - @@ -280,4 +279,4 @@ - \ No newline at end of file + diff --git a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.cpp b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.cpp deleted file mode 100644 index 4960b06f4e..0000000000 --- a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.cpp +++ /dev/null @@ -1,8 +0,0 @@ -// Copyright (c) .NET Foundation. All rights reserved. -// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. - -#include "HandleWrapper.h" - -// Workaround for VC++ bug https://developercommunity.visualstudio.com/content/problem/33928/constexpr-failing-on-nullptr-v141-compiler-regress.html -const HANDLE InvalidHandleTraits::DefaultHandle = INVALID_HANDLE_VALUE; -const HANDLE FindFileHandleTraits::DefaultHandle = INVALID_HANDLE_VALUE; diff --git a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.h b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.h index 56da4ae035..9e93d1e42b 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.h +++ b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HandleWrapper.h @@ -9,7 +9,7 @@ struct InvalidHandleTraits { using HandleType = HANDLE; - static const HANDLE DefaultHandle; + static constexpr HANDLE DefaultHandle = nullptr; static void Close(HANDLE handle) noexcept { CloseHandle(handle); } }; @@ -23,7 +23,7 @@ struct NullHandleTraits struct FindFileHandleTraits { using HandleType = HANDLE; - static const HANDLE DefaultHandle; + static constexpr HANDLE DefaultHandle = nullptr; static void Close(HANDLE handle) noexcept { FindClose(handle); } }; @@ -35,16 +35,16 @@ struct ModuleHandleTraits }; // Code analysis doesn't like nullptr usages via traits -#pragma warning( push ) -#pragma warning ( disable : 26477 ) // disable Use 'nullptr' rather than 0 or NULL (es.47). +#pragma warning(push) +#pragma warning(disable : 26477) // disable Use 'nullptr' rather than 0 or NULL (es.47). -template +template class HandleWrapper { public: using HandleType = typename traits::HandleType; - HandleWrapper(HandleType handle = traits::DefaultHandle) noexcept : m_handle(handle) { } + HandleWrapper(HandleType handle = traits::DefaultHandle) noexcept : m_handle(handle) {} ~HandleWrapper() { if (m_handle != traits::DefaultHandle) @@ -54,14 +54,14 @@ public: } operator HandleType() noexcept { return m_handle; } - HandleWrapper& operator =(HandleType value) noexcept + HandleWrapper &operator=(HandleType value) noexcept { DBG_ASSERT(m_handle == traits::DefaultHandle); m_handle = value; return *this; } - HandleType* operator&() noexcept { return &m_handle; } + HandleType *operator&() noexcept { return &m_handle; } HandleType release() noexcept { @@ -74,4 +74,4 @@ private: HandleType m_handle; }; -#pragma warning( pop ) +#pragma warning(pop)