From db909922e46b4ad73d96c793d6651864d04fb3de Mon Sep 17 00:00:00 2001 From: "N. Taylor Mullen" Date: Fri, 2 Jun 2017 16:45:13 -0700 Subject: [PATCH 1/2] Revert "Skip desktop testing to work around corefx issue." This reverts commit 27c6ad410e2d7b7cfd3da0e654583a308ae0c59e. --- .../RuntimeFlavors.cs | 9 ++++----- .../SimpleAppX86DesktopOnlyTest.cs | 2 +- .../ClassLibraryWithPrecompiledViews.csproj | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/RuntimeFlavors.cs b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/RuntimeFlavors.cs index b40a7e54eb..c1bd137100 100644 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/RuntimeFlavors.cs +++ b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/RuntimeFlavors.cs @@ -15,11 +15,10 @@ namespace Microsoft.AspNetCore.Mvc.Razor.ViewCompilation get { yield return RuntimeFlavor.CoreClr; - // Can't run on CLR until https://github.com/dotnet/corefx/issues/20364 is resolved. - //if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) - //{ - // yield return RuntimeFlavor.Clr; - //} + if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) + { + yield return RuntimeFlavor.Clr; + } } } diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/SimpleAppX86DesktopOnlyTest.cs b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/SimpleAppX86DesktopOnlyTest.cs index 12d32351ad..e9cbdfead2 100644 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/SimpleAppX86DesktopOnlyTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/SimpleAppX86DesktopOnlyTest.cs @@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.ViewCompilation public ApplicationTestFixture Fixture { get; } - [Fact(Skip = "https://github.com/dotnet/corefx/issues/20364")] + [Fact(Skip = "https://github.com/aspnet/MvcPrecompilation/issues/134")] public async Task Precompilation_WorksForSimpleApps() { // Arrange diff --git a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj index f6aaa943f8..5d65410110 100644 --- a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj +++ b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj @@ -12,6 +12,6 @@ - + From 265c980c2bce0eb7d92ed989ae9d5b81c697a0d4 Mon Sep 17 00:00:00 2001 From: "N. Taylor Mullen" Date: Mon, 5 Jun 2017 16:42:04 -0700 Subject: [PATCH 2/2] Manually construct the precompilation nupkg. - We needed to manually construct the precompilation nupkg in order for the tool to work in 32 and 64 bitness OS'. --- ...spNetCore.Mvc.Razor.ViewCompilation.csproj | 22 +++++++++++++++++-- .../lib/net461/_._ | 0 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/lib/net461/_._ diff --git a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj index 3b984b59f5..c0b303a5f1 100644 --- a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj +++ b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj @@ -11,11 +11,29 @@ true exe ..\..\tools\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86\ + + + false - - + + + + + + + + + + + diff --git a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/lib/net461/_._ b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/lib/net461/_._ new file mode 100644 index 0000000000..e69de29bb2