From 90b42ba0992b7d194c3ae42d1756d594500073b5 Mon Sep 17 00:00:00 2001 From: Chris Ross Date: Thu, 17 Oct 2019 10:33:09 -0700 Subject: [PATCH] Update Facebook API to 4.0 #4684 (#14798) --- .../Authentication/Facebook/src/FacebookDefaults.cs | 6 +++--- src/Security/Authentication/test/FacebookTests.cs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Security/Authentication/Facebook/src/FacebookDefaults.cs b/src/Security/Authentication/Facebook/src/FacebookDefaults.cs index d85b99353a..0e155bf3b6 100644 --- a/src/Security/Authentication/Facebook/src/FacebookDefaults.cs +++ b/src/Security/Authentication/Facebook/src/FacebookDefaults.cs @@ -10,10 +10,10 @@ namespace Microsoft.AspNetCore.Authentication.Facebook public static readonly string DisplayName = "Facebook"; // https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow#login - public static readonly string AuthorizationEndpoint = "https://www.facebook.com/v3.3/dialog/oauth"; + public static readonly string AuthorizationEndpoint = "https://www.facebook.com/v4.0/dialog/oauth"; - public static readonly string TokenEndpoint = "https://graph.facebook.com/v3.3/oauth/access_token"; + public static readonly string TokenEndpoint = "https://graph.facebook.com/v4.0/oauth/access_token"; - public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v3.3/me"; + public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v4.0/me"; } } diff --git a/src/Security/Authentication/test/FacebookTests.cs b/src/Security/Authentication/test/FacebookTests.cs index c0fc415c9c..66a3605757 100644 --- a/src/Security/Authentication/test/FacebookTests.cs +++ b/src/Security/Authentication/test/FacebookTests.cs @@ -225,7 +225,7 @@ namespace Microsoft.AspNetCore.Authentication.Facebook var transaction = await server.SendAsync("http://example.com/base/login"); Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode); var location = transaction.Response.Headers.Location.AbsoluteUri; - Assert.Contains("https://www.facebook.com/v3.3/dialog/oauth", location); + Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location); Assert.Contains("response_type=code", location); Assert.Contains("client_id=", location); Assert.Contains("redirect_uri=" + UrlEncoder.Default.Encode("http://example.com/base/signin-facebook"), location); @@ -257,7 +257,7 @@ namespace Microsoft.AspNetCore.Authentication.Facebook var transaction = await server.SendAsync("http://example.com/login"); Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode); var location = transaction.Response.Headers.Location.AbsoluteUri; - Assert.Contains("https://www.facebook.com/v3.3/dialog/oauth", location); + Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location); Assert.Contains("response_type=code", location); Assert.Contains("client_id=", location); Assert.Contains("redirect_uri=" + UrlEncoder.Default.Encode("http://example.com/signin-facebook"), location); @@ -291,7 +291,7 @@ namespace Microsoft.AspNetCore.Authentication.Facebook var transaction = await server.SendAsync("http://example.com/challenge"); Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode); var location = transaction.Response.Headers.Location.AbsoluteUri; - Assert.Contains("https://www.facebook.com/v3.3/dialog/oauth", location); + Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location); Assert.Contains("response_type=code", location); Assert.Contains("client_id=", location); Assert.Contains("redirect_uri=", location);