huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Re-enable skipped runtime compilation tests

This commit is contained in:
Pranav K 2019-02-13 11:47:39 -08:00
parent 9de42d516e
commit 9053bc6e29
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mvc/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ErrorPageTests.cs
View File

@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
public HttpClient Client { get; } public HttpClient Client { get; }
[Fact(Skip = "https://github.com/aspnet/Mvc/issues/8753")] [Fact]
public async Task CompilationFailuresAreListedByErrorPageMiddleware() public async Task CompilationFailuresAreListedByErrorPageMiddleware()
{ {
// Arrange // Arrange
@ -45,7 +45,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.DoesNotContain(PreserveCompilationContextMessage, content); Assert.DoesNotContain(PreserveCompilationContextMessage, content);
} }
[Fact(Skip = "https://github.com/aspnet/Mvc/issues/8753")] [Fact]
public async Task ParseFailuresAreListedByErrorPageMiddleware() public async Task ParseFailuresAreListedByErrorPageMiddleware()
{ {
// Arrange // Arrange
@ -67,7 +67,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Contains(expected, content); Assert.Contains(expected, content);
} }
[Fact(Skip = "https://github.com/aspnet/Mvc/issues/8753")] [Fact]
public async Task CompilationFailuresFromViewImportsAreListed() public async Task CompilationFailuresFromViewImportsAreListed()
{ {
// Arrange // Arrange
@ -90,7 +90,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Contains(expectedCompilationContent, content); Assert.Contains(expectedCompilationContent, content);
} }
[Fact(Skip = "https://github.com/aspnet/Mvc/issues/8753")] [Fact]
public async Task RuntimeErrorAreListedByErrorPageMiddleware() public async Task RuntimeErrorAreListedByErrorPageMiddleware()
{ {
// Arrange // Arrange

2
src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/ErrorPageMiddlewareWebSite.csproj
View File

@ -2,7 +2,6 @@
<PropertyGroup> <PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework> <TargetFramework>netcoreapp3.0</TargetFramework>
<DebugType Condition="'$(TargetFramework)' == 'net461'">full</DebugType>
<!-- We want to validate runtime parser \ compilation exceptions --> <!-- We want to validate runtime parser \ compilation exceptions -->
<RazorCompileOnBuild>false</RazorCompileOnBuild> <RazorCompileOnBuild>false</RazorCompileOnBuild>
<IsTestAssetProject>true</IsTestAssetProject> <IsTestAssetProject>true</IsTestAssetProject>
@ -10,6 +9,7 @@
<ItemGroup> <ItemGroup>
<Reference Include="Microsoft.AspNetCore.Mvc" /> <Reference Include="Microsoft.AspNetCore.Mvc" />
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" />
<Reference Include="Microsoft.AspNetCore.Diagnostics" /> <Reference Include="Microsoft.AspNetCore.Diagnostics" />
<Reference Include="Microsoft.AspNetCore.Server.IISIntegration" /> <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" />

1
src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/Startup.cs
View File

@ -15,6 +15,7 @@ namespace ErrorPageMiddlewareWebSite
public void ConfigureServices(IServiceCollection services) public void ConfigureServices(IServiceCollection services)
{ {
services.AddMvc() services.AddMvc()
.AddRazorRuntimeCompilation()
.SetCompatibilityVersion(CompatibilityVersion.Latest); .SetCompatibilityVersion(CompatibilityVersion.Latest);
} }