huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Quarantine a bunch of flaky tests (#9751)

This commit is contained in:
Andrew Stanton-Nurse 2019-04-29 11:26:02 -07:00 committed by GitHub
parent fe3dfe627b
commit 8c41472336
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 36 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs
View File

@ -5,6 +5,7 @@ using System;
using System.Diagnostics.Tracing; using System.Diagnostics.Tracing;
using System.Reflection; using System.Reflection;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
@ -108,7 +109,7 @@ namespace Microsoft.AspNetCore.Hosting.Internal
[Theory] [Theory]
[MemberData(nameof(RequestStartData))] [MemberData(nameof(RequestStartData))]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2040", "All")] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2230", FlakyOn.All)]
public void RequestStart(DefaultHttpContext httpContext, string[] expected) public void RequestStart(DefaultHttpContext httpContext, string[] expected)
{ {
// Arrange // Arrange

3
src/Hosting/Hosting/test/WebHostTests.cs
View File

@ -14,6 +14,7 @@ using Microsoft.AspNetCore.Hosting.Server;
using Microsoft.AspNetCore.Hosting.Server.Features; using Microsoft.AspNetCore.Hosting.Server.Features;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http.Features; using Microsoft.AspNetCore.Http.Features;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.Extensions.Configuration; using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
@ -238,7 +239,7 @@ namespace Microsoft.AspNetCore.Hosting
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7291 [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2244", FlakyOn.Helix.All)]
public async Task WebHostStopAsyncUsesDefaultTimeoutIfNoTokenProvided() public async Task WebHostStopAsyncUsesDefaultTimeoutIfNoTokenProvided()
{ {
var data = new Dictionary<string, string> var data = new Dictionary<string, string>

10
src/Servers/HttpSys/test/FunctionalTests/HttpsTests.cs
View File

@ -12,15 +12,18 @@ using System.Threading.Tasks;
using Microsoft.AspNetCore.Connections.Features; using Microsoft.AspNetCore.Connections.Features;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http.Features; using Microsoft.AspNetCore.Http.Features;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
namespace Microsoft.AspNetCore.Server.HttpSys namespace Microsoft.AspNetCore.Server.HttpSys
{ {
[SkipOnHelix] // https://github.com/aspnet/AspNetCore-Internal/issues/1816 // Flaky doesn't support classes :(
// https://github.com/aspnet/Extensions/issues/1568
public class HttpsTests public class HttpsTests
{ {
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
public async Task Https_200OK_Success() public async Task Https_200OK_Success()
{ {
using (Utilities.CreateDynamicHttpsServer(out var address, httpContext => using (Utilities.CreateDynamicHttpsServer(out var address, httpContext =>
@ -34,6 +37,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
public async Task Https_SendHelloWorld_Success() public async Task Https_SendHelloWorld_Success()
{ {
using (Utilities.CreateDynamicHttpsServer(out var address, httpContext => using (Utilities.CreateDynamicHttpsServer(out var address, httpContext =>
@ -49,6 +53,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
public async Task Https_EchoHelloWorld_Success() public async Task Https_EchoHelloWorld_Success()
{ {
using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext => using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
@ -66,6 +71,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
public async Task Https_ClientCertNotSent_ClientCertNotPresent() public async Task Https_ClientCertNotSent_ClientCertNotPresent()
{ {
using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext => using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
@ -102,6 +108,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
[OSDontSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)] [OSDontSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)]
public async Task Https_SkipsITlsHandshakeFeatureOnWin7() public async Task Https_SkipsITlsHandshakeFeatureOnWin7()
{ {
@ -124,6 +131,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
[OSSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)] [OSSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)]
public async Task Https_SetsITlsHandshakeFeature() public async Task Https_SetsITlsHandshakeFeature()
{ {

1
src/Servers/HttpSys/test/FunctionalTests/Listener/RequestBodyTests.cs
View File

@ -143,6 +143,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2206", FlakyOn.All)]
public async Task RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled() public async Task RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled()
{ {
StaggardContent content = new StaggardContent(); StaggardContent content = new StaggardContent();

7
src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs
View File

@ -46,6 +46,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2135", FlakyOn.All)]
public async Task Caching_JustPublic_NotCached() public async Task Caching_JustPublic_NotCached()
{ {
var requestCount = 1; var requestCount = 1;
@ -86,7 +87,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2207", FlakyOn.All)]
public async Task Caching_WithoutContentType_Cached_OnWin7AndWin2008R2() public async Task Caching_WithoutContentType_Cached_OnWin7AndWin2008R2()
{ {
if (Utilities.IsWin8orLater) if (Utilities.IsWin8orLater)
@ -237,7 +238,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
[ConditionalTheory] [ConditionalTheory]
[InlineData("0")] [InlineData("0")]
[InlineData("-1")] [InlineData("-1")]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2208", FlakyOn.All)]
public async Task Caching_InvalidExpires_NotCached(string expiresValue) public async Task Caching_InvalidExpires_NotCached(string expiresValue)
{ {
var requestCount = 1; var requestCount = 1;
@ -378,7 +379,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.All)]
public async Task Caching_VariousStatusCodes_Cached() public async Task Caching_VariousStatusCodes_Cached()
{ {
var requestCount = 1; var requestCount = 1;

2
src/Servers/IIS/IIS/test/Common.FunctionalTests/AppOfflineTests.cs
View File

@ -78,7 +78,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
DeletePublishOutput(deploymentResult); DeletePublishOutput(deploymentResult);
} }
[ConditionalFact(Skip = "https://github.com/aspnet/IISIntegration/issues/933")] [ConditionalFact(Skip = "https://github.com/aspnet/AspNetCore/issues/3835")]
public async Task AppOfflineDroppedWhileSiteFailedToStartInRequestHandler_SiteStops_InProcess() public async Task AppOfflineDroppedWhileSiteFailedToStartInRequestHandler_SiteStops_InProcess()
{ {
var deploymentResult = await DeployApp(HostingModel.InProcess); var deploymentResult = await DeployApp(HostingModel.InProcess);

4
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs
View File

@ -107,13 +107,13 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
Assert.Equal(1, TestSink.Writes.Count(w => w.Message.Contains("Invoking where.exe to find dotnet.exe"))); Assert.Equal(1, TestSink.Writes.Count(w => w.Message.Contains("Invoking where.exe to find dotnet.exe")));
} }
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972
[ConditionalTheory] [ConditionalTheory]
[InlineData(RuntimeArchitecture.x64)] [InlineData(RuntimeArchitecture.x64)]
[InlineData(RuntimeArchitecture.x86)] [InlineData(RuntimeArchitecture.x86)]
[SkipIfNotAdmin] [SkipIfNotAdmin]
[RequiresNewShim] [RequiresNewShim]
[RequiresIIS(IISCapability.PoolEnvironmentVariables)] [RequiresIIS(IISCapability.PoolEnvironmentVariables)]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2221", FlakyOn.Helix.All)]
public async Task StartsWithDotnetInstallLocation(RuntimeArchitecture runtimeArchitecture) public async Task StartsWithDotnetInstallLocation(RuntimeArchitecture runtimeArchitecture)
{ {
var deploymentParameters = Fixture.GetBaseDeploymentParameters(); var deploymentParameters = Fixture.GetBaseDeploymentParameters();
@ -651,7 +651,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
private static void VerifyDotnetRuntimeEventLog(IISDeploymentResult deploymentResult) private static void VerifyDotnetRuntimeEventLog(IISDeploymentResult deploymentResult)
{ {
var entries = GetEventLogsFromDotnetRuntime(deploymentResult); var entries = GetEventLogsFromDotnetRuntime(deploymentResult);
var expectedRegex = new Regex("Exception Info: System\\.InvalidOperationException:", RegexOptions.Singleline); var expectedRegex = new Regex("Exception Info: System\\.InvalidOperationException:", RegexOptions.Singleline);
var matchedEntries = entries.Where(entry => expectedRegex.IsMatch(entry.Message)).ToArray(); var matchedEntries = entries.Where(entry => expectedRegex.IsMatch(entry.Message)).ToArray();

2
src/Servers/IIS/IIS/test/Common.FunctionalTests/LogFileTests.cs
View File

@ -171,8 +171,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2200", FlakyOn.All)]
[MemberData(nameof(TestVariants))] [MemberData(nameof(TestVariants))]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2200", FlakyOn.All)]
public async Task CheckUTF8File(TestVariant variant) public async Task CheckUTF8File(TestVariant variant)
{ {
var path = "CheckConsoleFunctions"; var path = "CheckConsoleFunctions";

2
src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs
View File

@ -15,7 +15,7 @@ namespace IIS.FunctionalTests
[ConditionalFact] [ConditionalFact]
[OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)] [OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
[RequiresIIS(IISCapability.TracingModule)] [RequiresIIS(IISCapability.TracingModule)]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972 [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2222", FlakyOn.Helix.All)]
public void CheckMofFile() public void CheckMofFile()
{ {
var path = Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"), "aspnetcoremodulev2", "aspnetcore", "ancm.mof"); var path = Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"), "aspnetcoremodulev2", "aspnetcore", "ancm.mof");

3
src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
View File

@ -20,6 +20,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
public class ClientDisconnectTests : StrictTestServerTests public class ClientDisconnectTests : StrictTestServerTests
{ {
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2358", FlakyOn.All)]
public async Task WritesSucceedAfterClientDisconnect() public async Task WritesSucceedAfterClientDisconnect()
{ {
var requestStartedCompletionSource = CreateTaskCompletionSource(); var requestStartedCompletionSource = CreateTaskCompletionSource();
@ -178,7 +179,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
[Repeat(100)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1798", FlakyOn.All)]
public async Task ReaderThrowsCancelledException() public async Task ReaderThrowsCancelledException()
{ {
var requestStartedCompletionSource = CreateTaskCompletionSource(); var requestStartedCompletionSource = CreateTaskCompletionSource();

5
src/Servers/Kestrel/Kestrel/test/GeneratedCodeTests.cs
View File

@ -5,6 +5,7 @@ using System;
using System.IO; using System.IO;
using System.Linq; using System.Linq;
using System.Reflection; using System.Reflection;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
@ -12,8 +13,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
{ {
public class GeneratedCodeTests public class GeneratedCodeTests
{ {
[ConditionalFact] [ConditionalFact]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6720 [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2223", FlakyOn.Helix.All)]
public void GeneratedCodeIsUpToDate() public void GeneratedCodeIsUpToDate()
{ {
var repositoryRoot = typeof(GeneratedCodeTests).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>().First(f => string.Equals(f.Key, "RepositoryRoot", StringComparison.OrdinalIgnoreCase)).Value; var repositoryRoot = typeof(GeneratedCodeTests).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>().First(f => string.Equals(f.Key, "RepositoryRoot", StringComparison.OrdinalIgnoreCase)).Value;

4
src/Servers/Kestrel/test/FunctionalTests/RequestTests.cs
View File

@ -137,7 +137,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[ConditionalFact] [ConditionalFact]
[IPv6SupportedCondition] [IPv6SupportedCondition]
#if LIBUV #if LIBUV
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8109 [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1977", FlakyOn.Helix.All)] // https://github.com/aspnet/AspNetCore/issues/8109
#endif #endif
public Task RemoteIPv6Address() public Task RemoteIPv6Address()
{ {
@ -796,7 +796,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[Theory] [Theory]
#if LIBUV #if LIBUV
[SkipOnHelix] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1971", FlakyOn.Helix.All)]
#endif #endif
[MemberData(nameof(ConnectionAdapterData))] [MemberData(nameof(ConnectionAdapterData))]
public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions) public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions)

2
src/Servers/Kestrel/test/FunctionalTests/ResponseTests.cs
View File

@ -342,7 +342,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
} }
[Theory] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore/issues/7342", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1972", FlakyOn.All)]
[MemberData(nameof(ConnectionAdapterData))] [MemberData(nameof(ConnectionAdapterData))]
public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions) public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)
{ {

4
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionAdapterTests.cs
View File

@ -447,7 +447,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
} }
[Theory] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore/issues/7265", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1976", FlakyOn.All)]
[InlineData(ClientCertificateMode.AllowCertificate)] [InlineData(ClientCertificateMode.AllowCertificate)]
[InlineData(ClientCertificateMode.RequireCertificate)] [InlineData(ClientCertificateMode.RequireCertificate)]
public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode) public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode)
@ -485,7 +485,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
[SkipOnHelix] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1950", FlakyOn.Helix.All)]
[InlineData(ClientCertificateMode.AllowCertificate)] [InlineData(ClientCertificateMode.AllowCertificate)]
[InlineData(ClientCertificateMode.RequireCertificate)] [InlineData(ClientCertificateMode.RequireCertificate)]
public async Task ValidationFailureRejectsConnection(ClientCertificateMode mode) public async Task ValidationFailureRejectsConnection(ClientCertificateMode mode)

2
src/Servers/Kestrel/test/InMemory.FunctionalTests/LoggingConnectionAdapterTests.cs
View File

@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
public class LoggingConnectionAdapterTests : LoggedTest public class LoggingConnectionAdapterTests : LoggedTest
{ {
[Fact] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1753", FlakyOn.Helix.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2276", FlakyOn.Helix.All)]
public async Task LoggingConnectionAdapterCanBeAddedBeforeAndAfterHttpsAdapter() public async Task LoggingConnectionAdapterCanBeAddedBeforeAndAfterHttpsAdapter()
{ {
await using (var server = new TestServer(context => await using (var server = new TestServer(context =>

2
src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs
View File

@ -25,7 +25,7 @@ namespace Interop.FunctionalTests
{ {
[ConditionalTheory] [ConditionalTheory]
[MemberData(nameof(H2SpecTestCases))] [MemberData(nameof(H2SpecTestCases))]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7299 [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2225", FlakyOn.Helix.All)]
public async Task RunIndividualTestCase(H2SpecTestCase testCase) public async Task RunIndividualTestCase(H2SpecTestCase testCase)
{ {
var hostBuilder = new WebHostBuilder() var hostBuilder = new WebHostBuilder()

2
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
View File

@ -2077,7 +2077,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
} }
[Fact] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore/issues/8138", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1975", FlakyOn.All)]
public async Task ErrorDuringPollWillCloseConnection() public async Task ErrorDuringPollWillCloseConnection()
{ {
bool ExpectedErrors(WriteContext writeContext) bool ExpectedErrors(WriteContext writeContext)