From 89ca7ed08059e0f429661c7e78bbdef4d08ee1ea Mon Sep 17 00:00:00 2001 From: Cesar Blum Silveira Date: Thu, 22 Dec 2016 18:50:47 -0800 Subject: [PATCH] Disable tests that hang after update to CoreFx 4.4. --- .../HttpsTests.cs | 15 ++++++++++----- .../HttpsTests.cs | 15 ++++++++++----- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/test/Microsoft.AspNetCore.Server.WebListener.FunctionalTests/HttpsTests.cs b/test/Microsoft.AspNetCore.Server.WebListener.FunctionalTests/HttpsTests.cs index 2309b9cf7d..058ab551f9 100644 --- a/test/Microsoft.AspNetCore.Server.WebListener.FunctionalTests/HttpsTests.cs +++ b/test/Microsoft.AspNetCore.Server.WebListener.FunctionalTests/HttpsTests.cs @@ -17,7 +17,8 @@ namespace Microsoft.AspNetCore.Server.WebListener { private const string Address = "https://localhost:9090/"; - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_200OK_Success() { using (Utilities.CreateHttpsServer(httpContext => @@ -30,7 +31,8 @@ namespace Microsoft.AspNetCore.Server.WebListener } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_SendHelloWorld_Success() { using (Utilities.CreateHttpsServer(httpContext => @@ -45,7 +47,8 @@ namespace Microsoft.AspNetCore.Server.WebListener } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_EchoHelloWorld_Success() { using (Utilities.CreateHttpsServer(httpContext => @@ -63,7 +66,8 @@ namespace Microsoft.AspNetCore.Server.WebListener } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_ClientCertNotSent_ClientCertNotPresent() { using (Utilities.CreateHttpsServer(async httpContext => @@ -80,7 +84,8 @@ namespace Microsoft.AspNetCore.Server.WebListener } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_ClientCertRequested_ClientCertPresent() { using (Utilities.CreateHttpsServer(async httpContext => diff --git a/test/Microsoft.Net.Http.Server.FunctionalTests/HttpsTests.cs b/test/Microsoft.Net.Http.Server.FunctionalTests/HttpsTests.cs index da34f91cfe..ff8709377a 100644 --- a/test/Microsoft.Net.Http.Server.FunctionalTests/HttpsTests.cs +++ b/test/Microsoft.Net.Http.Server.FunctionalTests/HttpsTests.cs @@ -16,7 +16,8 @@ namespace Microsoft.Net.Http.Server // Note these tests can't use dynamic ports or run concurrently because the ssl cert must be pre-registered with a specific port. private const string Address = "https://localhost:9090/"; - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_200OK_Success() { using (var server = Utilities.CreateHttpsServer()) @@ -31,7 +32,8 @@ namespace Microsoft.Net.Http.Server } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_SendHelloWorld_Success() { using (var server = Utilities.CreateHttpsServer()) @@ -49,7 +51,8 @@ namespace Microsoft.Net.Http.Server } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_EchoHelloWorld_Success() { using (var server = Utilities.CreateHttpsServer()) @@ -70,7 +73,8 @@ namespace Microsoft.Net.Http.Server } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_ClientCertNotSent_ClientCertNotPresent() { using (var server = Utilities.CreateHttpsServer()) @@ -87,7 +91,8 @@ namespace Microsoft.Net.Http.Server } } - [ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] + // Disabled due to SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698) + //[ConditionalFact(Skip = "TODO: Add trait filtering support so these SSL tests don't get run on teamcity or the command line."), Trait("scheme", "https")] public async Task Https_ClientCertRequested_ClientCertPresent() { using (var server = Utilities.CreateHttpsServer())