From 88e14a0bfe4836e7019a097f638692f78e1ff6aa Mon Sep 17 00:00:00 2001 From: Fabien Lavocat Date: Wed, 24 Jan 2018 07:43:13 -0800 Subject: [PATCH] Add constructor for the SelectListItem class --- .../Internal/DefaultDisplayTemplates.cs | 21 +++---------------- .../Rendering/SelectListItem.cs | 10 +++++++++ 2 files changed, 13 insertions(+), 18 deletions(-) diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultDisplayTemplates.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultDisplayTemplates.cs index 34ca71d103..eb071f5807 100644 --- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultDisplayTemplates.cs +++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultDisplayTemplates.cs @@ -64,24 +64,9 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal { return new List { - new SelectListItem - { - Text = Resources.Common_TriState_NotSet, - Value = string.Empty, - Selected = !value.HasValue - }, - new SelectListItem - { - Text = Resources.Common_TriState_True, - Value = "true", - Selected = (value == true), - }, - new SelectListItem - { - Text = Resources.Common_TriState_False, - Value = "false", - Selected = (value == false), - }, + new SelectListItem(Resources.Common_TriState_NotSet, string.Empty, !value.HasValue), + new SelectListItem(Resources.Common_TriState_True, "true", (value == true)), + new SelectListItem(Resources.Common_TriState_False, "false", (value == false)), }; } diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs index a56f3068b2..af32345074 100644 --- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs +++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs @@ -10,6 +10,16 @@ namespace Microsoft.AspNetCore.Mvc.Rendering /// public class SelectListItem { + public SelectListItem() { } + + public SelectListItem(string text, string value, bool selected = false, bool disabled = false) + { + Disabled = disabled; + Selected = selected; + Text = text; + Value = value; + } + /// /// Gets or sets a value that indicates whether this is disabled. /// This property is typically rendered as a disabled="disabled" attribute in the HTML