From 85c051d8da6b42551f10f097719fb86b50935c09 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Fri, 1 Mar 2019 13:37:19 -0800 Subject: [PATCH] Skipping flaky test (#8101) --- .../TempDataInCookiesTest.cs | 1 - .../Mvc.FunctionalTests/TempDataTestBase.cs | 18 +++++++++--------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs b/src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs index 4e217bc025..e3e755de55 100644 --- a/src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs +++ b/src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs @@ -23,7 +23,6 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests protected override HttpClient Client { get; } - [Theory] [InlineData(ChunkingCookieManager.DefaultChunkSize)] [InlineData(ChunkingCookieManager.DefaultChunkSize * 1.5)] diff --git a/src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs b/src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs index c370123994..23c523c170 100644 --- a/src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs +++ b/src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs @@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests { protected abstract HttpClient Client { get; } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task PersistsJustForNextRequest() { // Arrange @@ -47,7 +47,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task ViewRendersTempData() { // Arrange @@ -66,7 +66,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal("Foo", body); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task Redirect_RetainsTempData_EvenIfAccessed() { // Arrange @@ -97,7 +97,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal("Foo", body); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task Peek_RetainsTempData() { // Arrange @@ -130,7 +130,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal("Foo", body); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task ValidTypes_RoundTripProperly() { // Arrange @@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal($"Foo 10 3 10/10/2010 00:00:00 {testGuid.ToString()}", body); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task ResponseWrite_DoesNotCrashSaveTempDataFilter() { // Arrange @@ -176,7 +176,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests var response = await Client.GetAsync("/TempData/SetTempDataResponseWrite"); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task SetInActionResultExecution_AvailableForNextRequest() { // Arrange @@ -207,7 +207,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task SaveTempDataFilter_DoesNotSaveTempData_OnUnhandledException() { // Arrange & Act @@ -225,7 +225,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] public async Task SaveTempDataFilter_DoesNotSaveTempData_OnHandledExceptions() { // Arrange & Act