From 85919008499eaaeac532abe995b291604138abba Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Wed, 2 Nov 2016 11:15:37 -0700 Subject: [PATCH] Fix more test failures caused by connection resets - Avoid sending data that won't be processed. --- .../ResponseTests.cs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ResponseTests.cs b/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ResponseTests.cs index d25b55e06f..5b4b5b73fe 100644 --- a/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ResponseTests.cs +++ b/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/ResponseTests.cs @@ -340,15 +340,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [Fact] public async Task SingleErrorResponseSentWhenAppSwallowsBadRequestException() { + BadHttpRequestException readException = null; + using (var server = new TestServer(async httpContext => { - try - { - await httpContext.Request.Body.ReadAsync(new byte[1], 0, 1); - } - catch (BadHttpRequestException) - { - } + readException = await Assert.ThrowsAsync( + async () => await httpContext.Request.Body.ReadAsync(new byte[1], 0, 1)); }, new TestServiceContext())) { using (var connection = server.CreateConnection()) @@ -357,8 +354,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests "POST / HTTP/1.1", "Transfer-Encoding: chunked", "", - "g", - ""); + "gg"); await connection.ReceiveForcedEnd( "HTTP/1.1 400 Bad Request", "Connection: close", @@ -368,6 +364,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests ""); } } + + Assert.NotNull(readException); } [Fact]