Re-adding Concurrent read/write tests. Fix flakiness. (#650)

test/IISIntegration.FunctionalTests/AppHostConfig/Http.config

@@ -876,6 +876,11 @@
   <location path="" overrideMode="Allow">
     <system.webServer>
       <modules>
+
+        <add name="IsapiFilterModule" lockItem="true" />
+        <add name="BasicAuthenticationModule" lockItem="true" />
+        <add name="IsapiModule" lockItem="true" />
+        <add name="HttpLoggingModule" lockItem="true" />
         <!--
                 <add name="HttpCacheModule" lockItem="true" />
 -->
@@ -883,7 +888,6 @@
         <add name="StaticCompressionModule" lockItem="true" />
         <add name="DefaultDocumentModule" lockItem="true" />
         <add name="DirectoryListingModule" lockItem="true" />
-        <add name="IsapiFilterModule" lockItem="true" />
         <add name="ProtocolSupportModule" lockItem="true" />
         <add name="HttpRedirectionModule" lockItem="true" />
         <add name="ServerSideIncludeModule" lockItem="true" />
@@ -891,7 +895,6 @@
         <add name="AnonymousAuthenticationModule" lockItem="true" />
         <add name="CertificateMappingAuthenticationModule" lockItem="true" />
         <add name="UrlAuthorizationModule" lockItem="true" />
-        <add name="BasicAuthenticationModule" lockItem="true" />
         <add name="WindowsAuthenticationModule" lockItem="true" />
         <!--
                 <add name="DigestAuthenticationModule" lockItem="true" />
@@ -903,8 +906,6 @@
         <add name="RequestFilteringModule" lockItem="true" />
         <add name="CustomLoggingModule" lockItem="true" />
         <add name="CustomErrorModule" lockItem="true" />
-        <add name="IsapiModule" lockItem="true" />
-        <add name="HttpLoggingModule" lockItem="true" />
         <add name="FailedRequestsTracingModule" lockItem="true" />
         <add name="CgiModule" lockItem="true" />
         <add name="FastCgiModule" lockItem="true" />

test/IISIntegration.FunctionalTests/AppHostConfig/Https.config

@@ -876,6 +876,10 @@
     <location path="" overrideMode="Allow">
         <system.webServer>
             <modules>
+              <add name="IsapiFilterModule" lockItem="true" />
+              <add name="BasicAuthenticationModule" lockItem="true" />
+              <add name="IsapiModule" lockItem="true" />
+              <add name="HttpLoggingModule" lockItem="true" />
                 <!--
                 <add name="HttpCacheModule" lockItem="true" />
 -->
@@ -883,7 +887,6 @@
                 <add name="StaticCompressionModule" lockItem="true" />
                 <add name="DefaultDocumentModule" lockItem="true" />
                 <add name="DirectoryListingModule" lockItem="true" />
-                <add name="IsapiFilterModule" lockItem="true" />
                 <add name="ProtocolSupportModule" lockItem="true" />
                 <add name="HttpRedirectionModule" lockItem="true" />
                 <add name="ServerSideIncludeModule" lockItem="true" />
@@ -891,7 +894,6 @@
                 <add name="AnonymousAuthenticationModule" lockItem="true" />
                 <add name="CertificateMappingAuthenticationModule" lockItem="true" />
                 <add name="UrlAuthorizationModule" lockItem="true" />
-                <add name="BasicAuthenticationModule" lockItem="true" />
                 <add name="WindowsAuthenticationModule" lockItem="true" />
                 <!--
                 <add name="DigestAuthenticationModule" lockItem="true" />
@@ -903,8 +905,6 @@
                 <add name="RequestFilteringModule" lockItem="true" />
                 <add name="CustomLoggingModule" lockItem="true" />
                 <add name="CustomErrorModule" lockItem="true" />
-                <add name="IsapiModule" lockItem="true" />
-                <add name="HttpLoggingModule" lockItem="true" />
                 <add name="FailedRequestsTracingModule" lockItem="true" />
                 <add name="CgiModule" lockItem="true" />
                 <add name="FastCgiModule" lockItem="true" />
@@ -1026,4 +1026,4 @@
             </handlers>
         </system.webServer>
     </location>
-</configuration>
+</configuration>

test/IISIntegration.FunctionalTests/AppHostConfig/NtlmAuthentation.config

@@ -876,6 +876,10 @@
     <location path="" overrideMode="Allow">
         <system.webServer>
             <modules>
+              <add name="IsapiFilterModule" lockItem="true" />
+              <add name="BasicAuthenticationModule" lockItem="true" />
+              <add name="IsapiModule" lockItem="true" />
+              <add name="HttpLoggingModule" lockItem="true" />
                 <!--
                 <add name="HttpCacheModule" lockItem="true" />
 -->
@@ -883,7 +887,6 @@
                 <add name="StaticCompressionModule" lockItem="true" />
                 <add name="DefaultDocumentModule" lockItem="true" />
                 <add name="DirectoryListingModule" lockItem="true" />
-                <add name="IsapiFilterModule" lockItem="true" />
                 <add name="ProtocolSupportModule" lockItem="true" />
                 <add name="HttpRedirectionModule" lockItem="true" />
                 <add name="ServerSideIncludeModule" lockItem="true" />
@@ -891,7 +894,6 @@
                 <add name="AnonymousAuthenticationModule" lockItem="true" />
                 <add name="CertificateMappingAuthenticationModule" lockItem="true" />
                 <add name="UrlAuthorizationModule" lockItem="true" />
-                <add name="BasicAuthenticationModule" lockItem="true" />
                 <add name="WindowsAuthenticationModule" lockItem="true" />
                 <!--
                 <add name="DigestAuthenticationModule" lockItem="true" />
@@ -903,8 +905,6 @@
                 <add name="RequestFilteringModule" lockItem="true" />
                 <add name="CustomLoggingModule" lockItem="true" />
                 <add name="CustomErrorModule" lockItem="true" />
-                <add name="IsapiModule" lockItem="true" />
-                <add name="HttpLoggingModule" lockItem="true" />
                 <add name="FailedRequestsTracingModule" lockItem="true" />
                 <add name="CgiModule" lockItem="true" />
                 <add name="FastCgiModule" lockItem="true" />
@@ -1037,4 +1037,4 @@
       </security>
     </system.webServer>
   </location>
-</configuration>
+</configuration>

test/IISIntegration.FunctionalTests/AppHostConfig/WebsocketsNotSupported.config

@@ -876,6 +876,10 @@
     <location path="" overrideMode="Allow">
         <system.webServer>
             <modules>
+              <add name="IsapiFilterModule" lockItem="true" />
+              <add name="BasicAuthenticationModule" lockItem="true" />
+              <add name="IsapiModule" lockItem="true" />
+              <add name="HttpLoggingModule" lockItem="true" />
                 <!--
                 <add name="HttpCacheModule" lockItem="true" />
 -->
@@ -883,7 +887,6 @@
                 <add name="StaticCompressionModule" lockItem="true" />
                 <add name="DefaultDocumentModule" lockItem="true" />
                 <add name="DirectoryListingModule" lockItem="true" />
-                <add name="IsapiFilterModule" lockItem="true" />
                 <add name="ProtocolSupportModule" lockItem="true" />
                 <add name="HttpRedirectionModule" lockItem="true" />
                 <add name="ServerSideIncludeModule" lockItem="true" />
@@ -891,7 +894,6 @@
                 <add name="AnonymousAuthenticationModule" lockItem="true" />
                 <add name="CertificateMappingAuthenticationModule" lockItem="true" />
                 <add name="UrlAuthorizationModule" lockItem="true" />
-                <add name="BasicAuthenticationModule" lockItem="true" />
                 <add name="WindowsAuthenticationModule" lockItem="true" />
                 <!--
                 <add name="DigestAuthenticationModule" lockItem="true" />
@@ -903,8 +905,6 @@
                 <add name="RequestFilteringModule" lockItem="true" />
                 <add name="CustomLoggingModule" lockItem="true" />
                 <add name="CustomErrorModule" lockItem="true" />
-                <add name="IsapiModule" lockItem="true" />
-                <add name="HttpLoggingModule" lockItem="true" />
                 <add name="FailedRequestsTracingModule" lockItem="true" />
                 <add name="CgiModule" lockItem="true" />
                 <add name="FastCgiModule" lockItem="true" />

test/IISIntegration.FunctionalTests/Inprocess/SynchronousReadAndWriteTests.cs

@@ -11,8 +11,8 @@ using System.Threading.Tasks;
 using Microsoft.AspNetCore.Testing.xunit;
 using Xunit;
 
-namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
+namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
-{ 
+{
     [Collection(IISTestSiteCollection.Name)]
     public class SynchronousReadAndWriteTests
     {
@@ -23,7 +23,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
             _fixture = fixture;
         }
 
-        [ConditionalFact (Skip = "See https://github.com/aspnet/IISIntegration/issues/629")]
+        [ConditionalFact]
         public async Task ReadAndWriteSynchronously()
         {
             for (int i = 0; i < 100; i++)
@@ -89,6 +89,8 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
                     }
                 }
 
+                Assert.True(socket.Connected);
+
                 var testString = "hello world";
                 var request = $"POST /ReadAndWriteSlowConnection HTTP/1.0\r\n" +
                     $"Content-Length: {testString.Length}\r\n" +

test/IISIntegration.IISServerFunctionalTests/WebsocketTests.cs

@@ -1,10 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-
-namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
-{
-    public class WebsocketTests
-    {
-    }
-}