From 8928f8446f6a43d8eccdf223e4176754f46f3abe Mon Sep 17 00:00:00 2001 From: bchavez Date: Sun, 27 Aug 2017 17:33:16 -0700 Subject: [PATCH 1/3] House Cleaning - Spell check and grammar. :shower: --- src/Microsoft.AspNet.Identity.AspNetCoreCompat/UserStore.cs | 2 +- .../RoleStore.cs | 2 +- .../CryptographyHelpers.cs | 2 +- src/Microsoft.AspNetCore.Identity/AspNetRoleManager.cs | 2 +- src/Microsoft.AspNetCore.Identity/AspNetUserManager.cs | 2 +- src/Microsoft.AspNetCore.Identity/IdentityConstants.cs | 2 +- src/Microsoft.Extensions.Identity.Core/UserManager.cs | 6 +++--- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Microsoft.AspNet.Identity.AspNetCoreCompat/UserStore.cs b/src/Microsoft.AspNet.Identity.AspNetCoreCompat/UserStore.cs index 204c926b93..1ecee58283 100644 --- a/src/Microsoft.AspNet.Identity.AspNetCoreCompat/UserStore.cs +++ b/src/Microsoft.AspNet.Identity.AspNetCoreCompat/UserStore.cs @@ -12,7 +12,7 @@ namespace Microsoft.AspNet.Identity.CoreCompat where TUser : IdentityUser { /// - /// Default constuctor which uses a new instance of a default EntityDbContext. + /// Default constructor which uses a new instance of a default EntityDbContext. /// public UserStore() : this(new IdentityDbContext()) diff --git a/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/RoleStore.cs b/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/RoleStore.cs index 140d51765e..04745e024c 100644 --- a/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/RoleStore.cs +++ b/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/RoleStore.cs @@ -435,7 +435,7 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore private DbSet RoleClaims { get { return Context.Set(); } } /// - /// Creates a entity representing a role claim. + /// Creates an entity representing a role claim. /// /// The associated role. /// The associated claim. diff --git a/src/Microsoft.AspNetCore.Identity.Service.Core/CryptographyHelpers.cs b/src/Microsoft.AspNetCore.Identity.Service.Core/CryptographyHelpers.cs index 7f997d9ccb..ea7069a3ce 100644 --- a/src/Microsoft.AspNetCore.Identity.Service.Core/CryptographyHelpers.cs +++ b/src/Microsoft.AspNetCore.Identity.Service.Core/CryptographyHelpers.cs @@ -97,7 +97,7 @@ namespace Microsoft.AspNetCore.Identity.Service } var rsaSecurityKey = credentials.Key as RsaSecurityKey; - // Check that the key has either an Asymetric Algorithm assigned or that at least + // Check that the key has either an Asymmetric Algorithm assigned or that at least // one of the RSA parameters are initialized to consider the key "valid". if (rsaSecurityKey != null && (rsaSecurityKey.Rsa != null || rsaSecurityKey.Parameters.Modulus != null)) diff --git a/src/Microsoft.AspNetCore.Identity/AspNetRoleManager.cs b/src/Microsoft.AspNetCore.Identity/AspNetRoleManager.cs index 79e7f6207d..374320bd28 100644 --- a/src/Microsoft.AspNetCore.Identity/AspNetRoleManager.cs +++ b/src/Microsoft.AspNetCore.Identity/AspNetRoleManager.cs @@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Identity } /// - /// The cancellation token assocated with the current HttpContext.RequestAborted or CancellationToken.None if unavailable. + /// The cancellation token associated with the current HttpContext.RequestAborted or CancellationToken.None if unavailable. /// protected override CancellationToken CancellationToken => _cancel; } diff --git a/src/Microsoft.AspNetCore.Identity/AspNetUserManager.cs b/src/Microsoft.AspNetCore.Identity/AspNetUserManager.cs index 6ab80e9397..f4f31e2856 100644 --- a/src/Microsoft.AspNetCore.Identity/AspNetUserManager.cs +++ b/src/Microsoft.AspNetCore.Identity/AspNetUserManager.cs @@ -46,7 +46,7 @@ namespace Microsoft.AspNetCore.Identity } /// - /// The cancellation token assocated with the current HttpContext.RequestAborted or CancellationToken.None if unavailable. + /// The cancellation token associated with the current HttpContext.RequestAborted or CancellationToken.None if unavailable. /// protected override CancellationToken CancellationToken => _cancel; } diff --git a/src/Microsoft.AspNetCore.Identity/IdentityConstants.cs b/src/Microsoft.AspNetCore.Identity/IdentityConstants.cs index 0843a33bd4..e01715dfbc 100644 --- a/src/Microsoft.AspNetCore.Identity/IdentityConstants.cs +++ b/src/Microsoft.AspNetCore.Identity/IdentityConstants.cs @@ -4,7 +4,7 @@ namespace Microsoft.AspNetCore.Identity { /// - /// Represents all the options you can use to configure the cookies middleware uesd by the identity system. + /// Represents all the options you can use to configure the cookies middleware used by the identity system. /// public class IdentityConstants { diff --git a/src/Microsoft.Extensions.Identity.Core/UserManager.cs b/src/Microsoft.Extensions.Identity.Core/UserManager.cs index 7956c06da5..d3179a12c9 100644 --- a/src/Microsoft.Extensions.Identity.Core/UserManager.cs +++ b/src/Microsoft.Extensions.Identity.Core/UserManager.cs @@ -178,7 +178,7 @@ namespace Microsoft.AspNetCore.Identity /// Gets a flag indicating whether the backing user store supports a user authenticator. /// /// - /// true if the backing user store supports a user authenticatior, otherwise false. + /// true if the backing user store supports a user authenticator, otherwise false. /// public virtual bool SupportsUserAuthenticatorKey { @@ -193,7 +193,7 @@ namespace Microsoft.AspNetCore.Identity /// Gets a flag indicating whether the backing user store supports recovery codes. /// /// - /// true if the backing user store supports a user authenticatior, otherwise false. + /// true if the backing user store supports a user authenticator, otherwise false. /// public virtual bool SupportsUserTwoFactorRecoveryCodes { @@ -961,7 +961,7 @@ namespace Microsoft.AspNetCore.Identity var existingUser = await FindByLoginAsync(login.LoginProvider, login.ProviderKey); if (existingUser != null) { - Logger.LogWarning(4, "AddLogin for user {userId} failed because it was already assocated with another user.", await GetUserIdAsync(user)); + Logger.LogWarning(4, "AddLogin for user {userId} failed because it was already associated with another user.", await GetUserIdAsync(user)); return IdentityResult.Failed(ErrorDescriber.LoginAlreadyAssociated()); } await loginStore.AddLoginAsync(user, login, CancellationToken); From 44c58a3042a575b19a26c2ecc03ff7f31949cd99 Mon Sep 17 00:00:00 2001 From: bchavez Date: Fri, 8 Sep 2017 11:17:17 -0700 Subject: [PATCH 2/3] Corrected copy/paste error in XML doc for SignInManager --- src/Microsoft.AspNetCore.Identity/SignInManager.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.AspNetCore.Identity/SignInManager.cs b/src/Microsoft.AspNetCore.Identity/SignInManager.cs index 3da1dfbe4b..f9d948c154 100644 --- a/src/Microsoft.AspNetCore.Identity/SignInManager.cs +++ b/src/Microsoft.AspNetCore.Identity/SignInManager.cs @@ -30,7 +30,7 @@ namespace Microsoft.AspNetCore.Identity /// The factory to use to create claims principals for a user. /// The accessor used to access the . /// The logger used to log messages, warnings and errors. - /// The logger used to log messages, warnings and errors. + /// The scheme provider that is used enumerate the authentication schemes. public SignInManager(UserManager userManager, IHttpContextAccessor contextAccessor, IUserClaimsPrincipalFactory claimsFactory, From 97d488acdaa1d291a88a03b9c9a4feaa03b939b8 Mon Sep 17 00:00:00 2001 From: bchavez Date: Tue, 24 Oct 2017 15:09:45 -0700 Subject: [PATCH 3/3] Fix spelling error in failing test. --- .../UserManagerSpecificationTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.AspNetCore.Identity.Specification.Tests/UserManagerSpecificationTests.cs b/src/Microsoft.AspNetCore.Identity.Specification.Tests/UserManagerSpecificationTests.cs index dd9c4c427b..e982e8e519 100644 --- a/src/Microsoft.AspNetCore.Identity.Specification.Tests/UserManagerSpecificationTests.cs +++ b/src/Microsoft.AspNetCore.Identity.Specification.Tests/UserManagerSpecificationTests.cs @@ -971,7 +971,7 @@ namespace Microsoft.AspNetCore.Identity.Test IdentityResultAssert.IsSuccess(await manager.AddLoginAsync(user, login)); var result = await manager.AddLoginAsync(user, login); IdentityResultAssert.IsFailure(result, _errorDescriber.LoginAlreadyAssociated()); - IdentityResultAssert.VerifyLogMessage(manager.Logger, $"AddLogin for user {await manager.GetUserIdAsync(user)} failed because it was already assocated with another user."); + IdentityResultAssert.VerifyLogMessage(manager.Logger, $"AddLogin for user {await manager.GetUserIdAsync(user)} failed because it was already associated with another user."); } // Email tests