From 84e7faf9be4c318026dbd723854b1f6e709a8e76 Mon Sep 17 00:00:00 2001 From: Kiran Challa Date: Fri, 29 Dec 2017 11:53:50 -0800 Subject: [PATCH] Updated logging in RangeHelper.cs --- .../Microsoft.AspNetCore.RangeHelper.Sources/RangeHelper.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/shared/Microsoft.AspNetCore.RangeHelper.Sources/RangeHelper.cs b/shared/Microsoft.AspNetCore.RangeHelper.Sources/RangeHelper.cs index 8378d301f3..e3c7ccc965 100644 --- a/shared/Microsoft.AspNetCore.RangeHelper.Sources/RangeHelper.cs +++ b/shared/Microsoft.AspNetCore.RangeHelper.Sources/RangeHelper.cs @@ -48,13 +48,14 @@ namespace Microsoft.AspNetCore.Internal var rawRangeHeader = context.Request.Headers[HeaderNames.Range]; if (StringValues.IsNullOrEmpty(rawRangeHeader)) { + logger.LogTrace("Range header's value is empty."); return (false, null); } // Perf: Check for a single entry before parsing it if (rawRangeHeader.Count > 1 || rawRangeHeader[0].IndexOf(',') >= 0) { - logger.LogWarning("Multiple ranges are not supported."); + logger.LogDebug("Multiple ranges are not supported."); // The spec allows for multiple ranges but we choose not to support them because the client may request // very strange ranges (e.g. each byte separately, overlapping ranges, etc.) that could negatively @@ -65,6 +66,7 @@ namespace Microsoft.AspNetCore.Internal var rangeHeader = requestHeaders.Range; if (rangeHeader == null) { + logger.LogTrace("Range header's value is invalid."); // Invalid return (false, null); } @@ -75,6 +77,7 @@ namespace Microsoft.AspNetCore.Internal var ranges = rangeHeader.Ranges; if (ranges == null) { + logger.LogTrace("Range header's value is invalid."); return (false, null); }