Change pin-version to use the coherence build results

Fies #247
This commit is contained in:
Pranav K 2015-07-20 10:23:55 -07:00
parent 14b08da4f3
commit 8271552cc6
6 changed files with 175 additions and 89 deletions

1
.gitignore vendored
View File

@ -15,3 +15,4 @@ StyleCop.Cache
node_modules node_modules
*.snk *.snk
.nuget/NuGet.exe .nuget/NuGet.exe
project.lock.json

View File

@ -56,7 +56,7 @@ functions
"CORS", "CORS",
"Entropy", "Entropy",
}; };
// Doesn't build on Mono since their contracts don't match // Doesn't build on Mono since their contracts don't match
string[] excludeReposOnMono = new[] { "Helios" }; string[] excludeReposOnMono = new[] { "Helios" };
@ -89,9 +89,9 @@ var buildTarget = "compile"
nuget-pack nuspecFile='${Path.Combine(BASE_DIR, "KoreBuild.nuspec")}' packageVersion='${VERSION}' outputDir='${TARGET_DIR}' nuget-pack nuspecFile='${Path.Combine(BASE_DIR, "KoreBuild.nuspec")}' packageVersion='${VERSION}' outputDir='${TARGET_DIR}'
#pack-install .pack #pack-install .pack
nuget-local-publish sourcePackagesDir='${TARGET_DIR}' nuget-local-publish sourcePackagesDir='${TARGET_DIR}'
#git-pull target='pull' #git-pull target='pull'
@{ @{
Parallel.ForEach(repos, repo => Parallel.ForEach(repos, repo =>
{ {
@ -177,7 +177,7 @@ var buildTarget = "compile"
foreach (var repo in GetAllRepos()) foreach (var repo in GetAllRepos())
{ {
CloneOrUpdate(repo); CloneOrUpdate(repo);
GitCommand(repo, "checkout origin/dev -B release"); GitCommand(repo, "checkout origin/dev -B release");
if(!ShouldSkipCopyingNugetConfig(repo)) if(!ShouldSkipCopyingNugetConfig(repo))
@ -223,82 +223,37 @@ var buildTarget = "compile"
-// Pin versions of packages in project.json and updated project.lock.json -// Pin versions of packages in project.json and updated project.lock.json
-// More information https://github.com/aspnet/Universe/wiki/%23pin-version-:-Pinning-package-version-for-a-particular-release-in-project.json -// More information https://github.com/aspnet/Universe/wiki/%23pin-version-:-Pinning-package-version-for-a-particular-release-in-project.json
@{ @{
// NOTE: Before running update the below monikers as needed var coherenceFeed = Environment.GetEnvironmentVariable("COHERENCE_FEED");
var branch = Environment.GetEnvironmentVariable("BUILD_BRANCH"); if (string.IsNullOrEmpty(coherenceFeed))
var stableBranches = new[] {"master"};
var oldPreRelease = Environment.GetEnvironmentVariable("OLD_RELEASE");
var newPreRelease = Environment.GetEnvironmentVariable("NEW_RELEASE");
var excludeReposForJson = new[]
{
"Coherence",
"Coherence-Signed",
"dnvm",
"Entropy"
};
var oldCoreCLRBuild = Environment.GetEnvironmentVariable("CORECLR_RELEASE_BUILD_OLD");
var newCoreCLRBuild = Environment.GetEnvironmentVariable("CORECLR_RELEASE_BUILD_NEW");
var oldCoreCLRPrerelease = Environment.GetEnvironmentVariable("OLD_CORECLR_RELEASE");
var newCoreCLRPrerelease = Environment.GetEnvironmentVariable("NEW_CORECLR_RELEASE");
var oldRoslynPrerelease = Environment.GetEnvironmentVariable("OLD_ROSLYN_RELEASE");
var newRoslynPrerelease = Environment.GetEnvironmentVariable("NEW_ROSLYN_RELEASE");
foreach (var repo in GetAllRepos().Except(excludeReposForJson))
{ {
CloneOrUpdate(repo); throw new Exception("COHERENCE_FEED not specified. Usually this is Packages-NoTimestamp directory of Coherence-Signed.");
}
GitCommand(repo, string.Format("checkout {0}", branch)); var excludeReposForJson = new[]
{
"Coherence",
"Coherence-Signed",
"dnvm",
"Entropy"
};
if(File.Exists(Path.Combine(repo, "build.cmd"))) var repos = GetAllRepos().Except(excludeReposForJson);
Parallel.ForEach(repos, CloneOrUpdate);
foreach (var repo in repos)
{
GitCommand(repo, "checkout master");
if (File.Exists(Path.Combine(repo, "build.cmd")))
{ {
File.Copy(Path.Combine("build-template", "build.cmd"), File.Copy(Path.Combine("build-template", "build.cmd"),
Path.Combine(repo, "build.cmd"), Path.Combine(repo, "build.cmd"),
overwrite: true); overwrite: true);
} }
// Process project.json files to pin version numbers var repoPath = Path.Combine(Directory.GetCurrentDirectory(), repo);
// Replace version in project.json
foreach(var file in Directory.GetFiles(repo,"project.json", SearchOption.AllDirectories))
{
var builder = new StringBuilder();
var contents = File.ReadAllLines(file);
foreach(var jsonEntry in contents) Exec("dnx", string.Format(@".\tools\PinVersion run ""{0}"" ""{1}""", repo, coherenceFeed), string.Empty);
{
if(jsonEntry.Contains("\"System.") || jsonEntry.Contains("CSharp"))
{
var oldSearchExp = BuildVersionExpression(branch, oldCoreCLRPrerelease, oldCoreCLRBuild);
var newReplaceExp = BuildVersionExpression(branch, newCoreCLRPrerelease, newCoreCLRBuild);
builder.AppendLine(jsonEntry.Replace(oldSearchExp, newReplaceExp));
}
else if(jsonEntry.Contains("CodeAnalysis."))
{
var oldSearchExp = BuildVersionExpression(branch, oldRoslynPrerelease);
var newReplaceExp = BuildVersionExpression(branch, newRoslynPrerelease);
builder.AppendLine(jsonEntry.Replace(oldSearchExp, newReplaceExp));
}
else if(jsonEntry.Contains("IdentityModel"))
{
// IdentityModel packages don't have a stable build and are updated very frequently on the NuGet feed
builder.AppendLine(jsonEntry);
}
else
{
var oldSearchExp = BuildVersionExpression(branch, oldPreRelease);
var newReplaceExp = BuildVersionExpression(branch, newPreRelease);
var newEntry = ProcessExcludesForPackages(jsonEntry, stableBranches.Contains(branch));
builder.AppendLine(newEntry.Replace(oldSearchExp, newReplaceExp));
}
}
File.WriteAllText(file, builder.ToString());
}
// Build projects to produce project.lock.json // Build projects to produce project.lock.json
Exec("build.cmd", "compile", repo); Exec("build.cmd", "compile", repo);
@ -321,11 +276,11 @@ var buildTarget = "compile"
{ {
GitCommand(repo, string.Format("add -f {0}", gitFilePath)); GitCommand(repo, string.Format("add -f {0}", gitFilePath));
} }
} }
GitCommand(repo, "commit -am \"Updating json files to pin versions and build.cmd to pin KoreBuild and DNX\""); GitCommand(repo, "commit -am \"Updating json files to pin versions and build.cmd to pin KoreBuild and DNX\"");
GitCommand(repo, string.Format("push origin {0}:{0} -f", branch)); GitCommand(repo, "push origin master:master -f");
} }
} }
@ -380,8 +335,8 @@ var buildTarget = "compile"
@{ @{
var failed = new Dictionary<string, Exception>(); var failed = new Dictionary<string, Exception>();
var skipped = new List<string>(); var skipped = new List<string>();
foreach(var repo in repos) foreach(var repo in repos)
{ {
var blockName = string.Format("Building {0}", repo); var blockName = string.Format("Building {0}", repo);
if (IsTeamCity) if (IsTeamCity)
@ -391,7 +346,7 @@ var buildTarget = "compile"
try try
{ {
Log.Info(blockName); Log.Info(blockName);
if (SKIP_NO_CREDENTIALS) if (SKIP_NO_CREDENTIALS)
{ {
if (!Directory.Exists(repo)) if (!Directory.Exists(repo))
@ -411,7 +366,7 @@ var buildTarget = "compile"
{ {
Exec("build.cmd", buildTarget, repo); Exec("build.cmd", buildTarget, repo);
} }
Log.Info(string.Format("Build {0} succeeded", repo)); Log.Info(string.Format("Build {0} succeeded", repo));
} }
catch(Exception ex) catch(Exception ex)
@ -419,7 +374,7 @@ var buildTarget = "compile"
Log.Warn(string.Format("Build {0} failed: {1}", repo, ex.Message)); Log.Warn(string.Format("Build {0} failed: {1}", repo, ex.Message));
failed[repo] = ex; failed[repo] = ex;
} }
finally finally
{ {
if (IsTeamCity) if (IsTeamCity)
{ {
@ -451,7 +406,7 @@ var buildTarget = "compile"
Log.Info(string.Format("Build {0} succeeded", repo)); Log.Info(string.Format("Build {0} succeeded", repo));
} }
} }
if (failed.Any()) if (failed.Any())
{ {
throw new Exception("One or more repos failed to build"); throw new Exception("One or more repos failed to build");
@ -460,7 +415,7 @@ var buildTarget = "compile"
#only-install target='install' #only-install target='install'
@{ @{
foreach(var repo in repos) foreach(var repo in repos)
{ {
if (IsMono) if (IsMono)
{ {
@ -472,7 +427,7 @@ var buildTarget = "compile"
} }
} }
} }
#run-snapshot-manager #run-snapshot-manager
@{ @{
Exec(@".nuget\nuget.exe", @"restore -out packages tools\TCDependencyManager\packages.config", ""); Exec(@".nuget\nuget.exe", @"restore -out packages tools\TCDependencyManager\packages.config", "");
@ -484,7 +439,7 @@ var buildTarget = "compile"
#git-status description='Show status of repos known by Universe' #git-status description='Show status of repos known by Universe'
@{ @{
foreach(var repo in repos) foreach(var repo in repos)
{ {
GitStatus(repo); GitStatus(repo);
} }
@ -499,7 +454,7 @@ var buildTarget = "compile"
{ {
throw new Exception("git-clean cancelled"); throw new Exception("git-clean cancelled");
} }
foreach(var repo in repos) foreach(var repo in repos)
{ {
GitClean(repo); GitClean(repo);
} }
@ -590,7 +545,7 @@ functions
return url.StartsWith("https://", System.StringComparison.OrdinalIgnoreCase); return url.StartsWith("https://", System.StringComparison.OrdinalIgnoreCase);
} }
static bool IsAccessible(string key) static bool IsAccessible(string key)
{ {
var req = WebRequest.CreateHttp("https://github.com/aspnet/" + key); var req = WebRequest.CreateHttp("https://github.com/aspnet/" + key);
@ -601,12 +556,12 @@ functions
} }
catch (WebException ex) catch (WebException ex)
{ {
if (ex.Response != null && if (ex.Response != null &&
((HttpWebResponse)ex.Response).StatusCode == HttpStatusCode.NotFound) ((HttpWebResponse)ex.Response).StatusCode == HttpStatusCode.NotFound)
{ {
return false; return false;
} }
// Ignore any other exception. They should surface as part of git clone with well-known messages. // Ignore any other exception. They should surface as part of git clone with well-known messages.
} }
return true; return true;
@ -646,7 +601,7 @@ functions
if (useHttps && if (useHttps &&
!IsAccessible(repo)) !IsAccessible(repo))
{ {
if (SKIP_NO_CREDENTIALS) if (SKIP_NO_CREDENTIALS)
{ {
// This is used on the XPlat CI. Must return because otherwise git will wait for user // This is used on the XPlat CI. Must return because otherwise git will wait for user
// input and hang the build // input and hang the build
@ -687,7 +642,7 @@ functions
.Replace("]", "|]"); .Replace("]", "|]");
} }
// Currently there are two packages that need to be special cased. // Currently there are two packages that need to be special cased.
// TODO: Revisit as this is changed in the near future. // TODO: Revisit as this is changed in the near future.
string ProcessExcludesForPackages(string jsonEntry, bool stable=false) string ProcessExcludesForPackages(string jsonEntry, bool stable=false)
{ {
@ -710,7 +665,7 @@ functions
builder.Append(preRelease); builder.Append(preRelease);
} }
// If buildnumber is provided, append. // If buildnumber is provided, append.
// This for CORE CLR packages // This for CORE CLR packages
if(!String.IsNullOrEmpty(buildNumber)) if(!String.IsNullOrEmpty(buildNumber))
{ {

22
tools/PinVersion.sln Normal file
View File

@ -0,0 +1,22 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.23107.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "PinVersion", "PinVersion\PinVersion.xproj", "{3D3B5750-0C24-4F1C-9304-B5E4D85CF5A0}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{3D3B5750-0C24-4F1C-9304-B5E4D85CF5A0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{3D3B5750-0C24-4F1C-9304-B5E4D85CF5A0}.Debug|Any CPU.Build.0 = Debug|Any CPU
{3D3B5750-0C24-4F1C-9304-B5E4D85CF5A0}.Release|Any CPU.ActiveCfg = Release|Any CPU
{3D3B5750-0C24-4F1C-9304-B5E4D85CF5A0}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
EndGlobal

View File

@ -0,0 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">14.0</VisualStudioVersion>
<VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
</PropertyGroup>
<Import Project="$(VSToolsPath)\DNX\Microsoft.DNX.Props" Condition="'$(VSToolsPath)' != ''" />
<PropertyGroup Label="Globals">
<ProjectGuid>3d3b5750-0c24-4f1c-9304-b5e4d85cf5a0</ProjectGuid>
<RootNamespace>PinVersion</RootNamespace>
<BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">..\artifacts\obj\$(MSBuildProjectName)</BaseIntermediateOutputPath>
<OutputPath Condition="'$(OutputPath)'=='' ">..\artifacts\bin\$(MSBuildProjectName)\</OutputPath>
</PropertyGroup>
<PropertyGroup>
<SchemaVersion>2.0</SchemaVersion>
</PropertyGroup>
<Import Project="$(VSToolsPath)\DNX\Microsoft.DNX.targets" Condition="'$(VSToolsPath)' != ''" />
</Project>

View File

@ -0,0 +1,74 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.IO;
using System.Linq;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using NuGet;
namespace PinVersion
{
public class Program
{
public void Main(string[] args)
{
if (args.Length != 2)
{
Console.Error.WriteLine("Usage <repository-path> <package source>");
}
var repositoryPath = args[0];
var packageSource = args[1];
var packageRepository = PackageRepositoryFactory.Default.CreateRepository(packageSource);
foreach (var file in Directory.EnumerateFiles(repositoryPath, "project.json", SearchOption.AllDirectories))
{
var projectJson = JObject.Parse(File.ReadAllText(file));
var directoryName = Path.GetFileName(Path.GetDirectoryName(file));
var latestPackage = packageRepository.FindPackage(directoryName);
if (latestPackage != null)
{
((JValue)projectJson["version"]).Value = latestPackage.Version.ToNormalizedString();
}
var frameworkDependencies = projectJson["frameworks"]
?.Cast<JProperty>()
?.Select(f => ((JObject)f.Value)["dependencies"])
?? Enumerable.Empty<JToken>();
var dependencies = Enumerable.Concat(new[] { projectJson["dependencies"] }, frameworkDependencies)
.Where(d => d != null)
.SelectMany(d => d)
.Cast<JProperty>();
foreach (var dependency in dependencies)
{
latestPackage = packageRepository.FindPackage(dependency.Name);
if (latestPackage != null)
{
if (dependency.Value.Type == JTokenType.Object)
{
// "key": { "version": "1.0.0-*", "type": "build" }
var value = (JObject)dependency.Value;
value["version"] = latestPackage.Version.ToNormalizedString();
}
else
{
// "key": "version"
dependency.Value = latestPackage.Version.ToNormalizedString();
}
}
}
using (var fileWriter = new JsonTextWriter(new StreamWriter(file)))
{
fileWriter.Formatting = Formatting.Indented;
fileWriter.Indentation = 4;
projectJson.WriteTo(fileWriter);
}
}
}
}
}

View File

@ -0,0 +1,15 @@
{
"version": "1.0.0-*",
"dependencies": {
"Newtonsoft.Json": "6.0.8",
"NuGet.Core": "2.8.6"
},
"commands": {
"PinVersion": "PinVersion"
},
"frameworks": {
"dnx451": { }
}
}