From 8241acf3a1f7f1da4d0a0643d8e900e700985975 Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Tue, 17 Apr 2018 18:00:04 +1200 Subject: [PATCH] Boop --- .../ServerLogScope.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs b/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs index 6f01448bcb..61dd375b72 100644 --- a/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs +++ b/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs @@ -3,7 +3,6 @@ using System; using System.Collections.Concurrent; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; namespace Microsoft.AspNetCore.SignalR.Tests @@ -19,12 +18,12 @@ namespace Microsoft.AspNetCore.SignalR.Tests public ServerLogScope(ServerFixture serverFixture, ILoggerFactory loggerFactory, IDisposable wrappedDisposable) { _serverFixture = serverFixture; + _serverFixture.ServerLogged += ServerFixtureOnServerLogged; + _loggerFactory = loggerFactory; _wrappedDisposable = wrappedDisposable; - _scopeLogger = loggerFactory.CreateLogger(typeof(ServerLogScope)); _serverLoggers = new ConcurrentDictionary(StringComparer.Ordinal); - - _serverFixture.ServerLogged += ServerFixtureOnServerLogged; + _scopeLogger = loggerFactory.CreateLogger(nameof(ServerLogScope)); _scopeLogger.LogInformation("Server log scope started."); } @@ -38,10 +37,10 @@ namespace Microsoft.AspNetCore.SignalR.Tests public void Dispose() { - _scopeLogger.LogInformation("Server log scope disposing."); - _serverFixture.ServerLogged -= ServerFixtureOnServerLogged; + _scopeLogger.LogInformation("Server log scope stopped."); + _wrappedDisposable?.Dispose(); } }