From 8188f593ad25a9fa33c5be57a8ffbfc219c7e98c Mon Sep 17 00:00:00 2001 From: Pranav K Date: Tue, 28 Apr 2015 17:41:19 -0700 Subject: [PATCH] Fix excplicit cast of HashSet to IReadOnlyCollection to allow tests to succeed in machines with only 4.5.1. --- .../Rendering/Html/DefaultHtmlGenerator.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.AspNet.Mvc.Core/Rendering/Html/DefaultHtmlGenerator.cs b/src/Microsoft.AspNet.Mvc.Core/Rendering/Html/DefaultHtmlGenerator.cs index 5e53d76a4a..6e7f2f0f76 100644 --- a/src/Microsoft.AspNet.Mvc.Core/Rendering/Html/DefaultHtmlGenerator.cs +++ b/src/Microsoft.AspNet.Mvc.Core/Rendering/Html/DefaultHtmlGenerator.cs @@ -852,7 +852,9 @@ namespace Microsoft.AspNet.Mvc.Rendering } } - return (IReadOnlyCollection)currentValues; + // HashSet<> implements IReadOnlyCollection<> as of 4.6, but does not for 4.5.1. If the runtime cast succeeds, + // avoid creating a new collection. + return (currentValues as IReadOnlyCollection) ?? currentValues.ToArray(); } internal static string EvalString(ViewContext viewContext, string key, string format)