huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replaced Span<T>.Fill(0) with Span<T>.Clear() (#20023)

This commit is contained in:
Günther Foidl 2020-04-10 22:18:37 +02:00 committed by GitHub
parent 9cab3e2602
commit 810969084a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Components/Server/src/BlazorPack/SequenceOfT.cs
View File

@ -443,7 +443,7 @@ namespace Nerdbank.Streams
// If we store references, clear them to allow the objects to be GC'd. // If we store references, clear them to allow the objects to be GC'd.
if (!IsValueTypeElement) if (!IsValueTypeElement)
{ {
this.AvailableMemory.Span.Slice(startIndex, length).Fill(default); this.AvailableMemory.Span.Slice(startIndex, length).Clear();
} }
} }
} }

2
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TestBase.cs
View File

@ -545,7 +545,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
HPackHeaderWriter.BeginEncodeHeaders(_hpackEncoder, GetHeadersEnumerator(headers), payload, out var length); HPackHeaderWriter.BeginEncodeHeaders(_hpackEncoder, GetHeadersEnumerator(headers), payload, out var length);
var padding = buffer.Slice(extendedHeaderLength + length, padLength); var padding = buffer.Slice(extendedHeaderLength + length, padLength);
padding.Fill(0); padding.Clear();
frame.PayloadLength = extendedHeaderLength + length + padLength; frame.PayloadLength = extendedHeaderLength + length + padLength;

4
src/Shared/Http2cat/Http2Utilities.cs
View File

@ -343,7 +343,7 @@ namespace Microsoft.AspNetCore.Http2Cat
HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length); HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length);
var padding = buffer.Slice(extendedHeaderLength + length, padLength); var padding = buffer.Slice(extendedHeaderLength + length, padLength);
padding.Fill(0); padding.Clear();
frame.PayloadLength = extendedHeaderLength + length + padLength; frame.PayloadLength = extendedHeaderLength + length + padLength;
@ -431,7 +431,7 @@ namespace Microsoft.AspNetCore.Http2Cat
HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length); HPackHeaderWriter.BeginEncodeHeaders(GetHeadersEnumerator(headers), payload, out var length);
var padding = buffer.Slice(extendedHeaderLength + length, padLength); var padding = buffer.Slice(extendedHeaderLength + length, padLength);
padding.Fill(0); padding.Clear();
frame.PayloadLength = extendedHeaderLength + length + padLength; frame.PayloadLength = extendedHeaderLength + length + padLength;

2
src/Shared/HttpSys/RequestProcessing/NativeRequestContext.cs
View File

@ -53,7 +53,7 @@ namespace Microsoft.AspNetCore.HttpSys.Internal
// No size limit // No size limit
_backingBuffer = MemoryPool<byte>.Shared.Rent(newSize); _backingBuffer = MemoryPool<byte>.Shared.Rent(newSize);
} }
_backingBuffer.Memory.Span.Fill(0);// Zero the buffer _backingBuffer.Memory.Span.Clear();
_memoryHandle = _backingBuffer.Memory.Pin(); _memoryHandle = _backingBuffer.Memory.Pin();
_nativeRequest = (HttpApiTypes.HTTP_REQUEST*)((long)_memoryHandle.Pointer + _bufferAlignment); _nativeRequest = (HttpApiTypes.HTTP_REQUEST*)((long)_memoryHandle.Pointer + _bufferAlignment);