From 807e8ccd472d536d2c80931d182d25611cc29ef5 Mon Sep 17 00:00:00 2001
From: John Luo <johluo@microsoft.com>
Date: Sat, 14 Nov 2020 17:05:55 -0800
Subject: [PATCH] Fix API baseline check when building site extensions (#27841)

* Include API files when building site extensions

* Test SiteEx build on PR

* Revert test code

* Disable the check all together

* revert test change
---
 src/SiteExtensions/Sdk/HostingStartup/HostingStartup.csproj   | 2 ++
 src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Shipped.txt   | 4 ----
 src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Unshipped.txt | 1 -
 src/SiteExtensions/Sdk/SiteExtension.targets                  | 1 +
 4 files changed, 3 insertions(+), 5 deletions(-)
 delete mode 100644 src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Shipped.txt
 delete mode 100644 src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Unshipped.txt

diff --git a/src/SiteExtensions/Sdk/HostingStartup/HostingStartup.csproj b/src/SiteExtensions/Sdk/HostingStartup/HostingStartup.csproj
index 471247e378..452c2ca4c9 100644
--- a/src/SiteExtensions/Sdk/HostingStartup/HostingStartup.csproj
+++ b/src/SiteExtensions/Sdk/HostingStartup/HostingStartup.csproj
@@ -4,6 +4,8 @@
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
     <OutputType>Exe</OutputType>
     <DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions>
+    <!-- No need to track public APIs of this tool. -->
+    <AddPublicApiAnalyzers>false</AddPublicApiAnalyzers>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Shipped.txt b/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Shipped.txt
deleted file mode 100644
index 3e35270583..0000000000
--- a/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Shipped.txt
+++ /dev/null
@@ -1,4 +0,0 @@
-#nullable enable
-Program
-Program.Program() -> void
-static Program.Main() -> void
diff --git a/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Unshipped.txt b/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Unshipped.txt
deleted file mode 100644
index 7dc5c58110..0000000000
--- a/src/SiteExtensions/Sdk/HostingStartup/PublicAPI.Unshipped.txt
+++ /dev/null
@@ -1 +0,0 @@
-#nullable enable
diff --git a/src/SiteExtensions/Sdk/SiteExtension.targets b/src/SiteExtensions/Sdk/SiteExtension.targets
index e11ead7af3..e65dcf08d4 100644
--- a/src/SiteExtensions/Sdk/SiteExtension.targets
+++ b/src/SiteExtensions/Sdk/SiteExtension.targets
@@ -42,6 +42,7 @@
 
     <ItemGroup>
       <_TemplateFiles Include="$(MSBuildThisFileDirectory)\HostingStartup\*.cs*" />
+      <_TemplateFiles Include="$(MSBuildThisFileDirectory)\HostingStartup\PublicAPI.*.txt*" />
       <!--
         Always use Major.Minor.0 so that if we have to produce a new SiteExtension during a patch build it will still work for non-patch runtimes.
         i.e. 3.0.0 dotnet will search for 3.0.0 and below and wouldn't find a 3.0.1 folder path