From 7f4d10775cf21b282275b47b914612d5493a4cee Mon Sep 17 00:00:00 2001
From: Nate McMaster <natemcmaster@users.noreply.github.com>
Date: Thu, 8 Nov 2018 16:57:07 -0800
Subject: [PATCH] Add signcheck exclusions (#3985)

---
 build/repo.props                    | 3 +++
 eng/signcheck.exclusions.txt        | 5 +++++
 src/Framework/Directory.Build.props | 2 +-
 3 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 eng/signcheck.exclusions.txt

diff --git a/build/repo.props b/build/repo.props
index 9b866315e8..2c14e6176a 100644
--- a/build/repo.props
+++ b/build/repo.props
@@ -13,6 +13,9 @@
 
     <DependencyPackageDir>$(RepositoryRoot).deps\build\</DependencyPackageDir>
     <SignedDependencyPackageDir>$(RepositoryRoot).deps\Signed\Packages\</SignedDependencyPackageDir>
+    <SignCheckExclusionsFile>$(RepositoryRoot)eng\signcheck.exclusions.txt</SignCheckExclusionsFile>
+    <!-- This creates false-positives on many of the native .dll's we produce or re-distribute from other teams. -->
+    <DisableSignCheckStrongName>true</DisableSignCheckStrongName>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/eng/signcheck.exclusions.txt b/eng/signcheck.exclusions.txt
new file mode 100644
index 0000000000..72a47fb4ba
--- /dev/null
+++ b/eng/signcheck.exclusions.txt
@@ -0,0 +1,5 @@
+content/sdk/*/AppHostTemplate/apphost.exe;AspNetCoreRuntime.*.nupkg; Exclude the apphost because this is expected to be code-signed by customers after the SDK modifies it.
+content/*.js;Microsoft.DotNet.Web.Spa.ProjectTemplates.*.nupkg; Exclude JavaScript files from codesigning in project templates
+content/*.js;Microsoft.DotNet.Web.ProjectTemplates.*.nupkg; Exclude JavaScript files from codesigning in project templates
+Templates/*.js;Microsoft.VisualStudio.Web.CodeGenerators.Mvc.*.nupkg; Exclude JavaScript files from codesigning in code generators
+*.js;signalr-*-javadoc.jar; Exclude JavaScript files in the generated javadocs
diff --git a/src/Framework/Directory.Build.props b/src/Framework/Directory.Build.props
index d96d5b2e8d..df110bdbcd 100644
--- a/src/Framework/Directory.Build.props
+++ b/src/Framework/Directory.Build.props
@@ -15,7 +15,7 @@
   <Import Condition="Exists('..\..\obj\dependencies.g.props') AND '$(DotNetPackageVersionPropsPath)' == ''" Project="..\..\obj\dependencies.g.props" />
 
   <PropertyGroup Condition=" '$(MSBuildProjectExtension)' == '.shfxproj' ">
-    <OutputPath>$(ArtifactsConfigurationDir)$(SharedFxRid)\$(MSBuildProjectName)\</OutputPath>
+    <OutputPath>$(RepositoryRoot)bin\fx\$(SharedFxRid)\$(MSBuildProjectName)\</OutputPath>
     <BaseIntermediateOutputPath>$(RepositoryRoot)obj\fx\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
 
     <CrossgenSymbolsOutput Condition=" '$(CrossgenOutput)' == 'false' OR '$(SharedFxRid)' == 'osx-x64'">false</CrossgenSymbolsOutput>